Received-SPF: pass (google.com: domain of linux-kernel+bounces-164404-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Tue, 30 Apr 2024 13:37:33 -0300
From: Jason Gunthorpe <jgg@nvidia.com>
To: Nicolin Chen <nicolinc@nvidia.com>
Cc: will@kernel.org, robin.murphy@arm.com, joro@8bytes.org,
	thierry.reding@gmail.com, vdumpa@nvidia.com, jonathanh@nvidia.com,
	linux-kernel@vger.kernel.org, iommu@lists.linux.dev,
	linux-arm-kernel@lists.infradead.org, linux-tegra@vger.kernel.org
Subject: Re: [PATCH v6 2/6] iommu/arm-smmu-v3: Add CS_NONE quirk
Message-ID: <20240430163733.GT941030@nvidia.com>
References: <cover.1714451595.git.nicolinc@nvidia.com>
 <81d79f51c69604a38ea4f72c8ac2c573c52e8609.1714451595.git.nicolinc@nvidia.com>
 <20240430142201.GQ941030@nvidia.com>
 <ZjEcs4rY1HpPz4Oa@Asurada-Nvidia>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZjEcs4rY1HpPz4Oa@Asurada-Nvidia>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?HJfnBUn7+tI1BcY9gdjsc+561JvaTFOhBIIPBdnhlOGBfVLiQCEugkCS6D6J?=
 =?us-ascii?Q?uR3o893fgqU2ig65klcLweh1H4NQczm0T2HZGarPwONMVUeK5vMAEjNTSW4A?=
 =?us-ascii?Q?Uol9vuwcEhe+75bVh3iUCg0sL5AROvWhNc3ZJH2jPI/52jQ24M9LigNLtr56?=
 =?us-ascii?Q?3swFQrtfaPGvaHCkuGe4zet7uaKxhDNEz1mhFiBSHmdN2UzzshbW+GySrOZm?=
 =?us-ascii?Q?WjcLsTCIVOS/BsoCU83YwuEcV08NTgJo7H0cgXIkEcXuYuImU8od/bH34pwh?=
 =?us-ascii?Q?XpPeydZuQi68o3sVInacVpIcxwp0uh+Sj23G2PAo7jIyPSH0FgrSRt0ZKdXx?=
 =?us-ascii?Q?b2vJiKtQsWBsyH3bQBkP32ebwZoOKY69rYXMPSTQM0fGUefMOpx97Hs2MlYt?=
 =?us-ascii?Q?ROk0RjilADOXNv8aqv7LXD4FGiKuI3jeABKNAjrVfF89SH3h94iQ4PnlxXsi?=
 =?us-ascii?Q?atQwujpbzYaaKO8Y/hU3rjaw6xjRisyNtKpvwac8jh4zeRsrNmRz84sZ/cKh?=
 =?us-ascii?Q?A5WxmvsA4lnWg25Rjhcmxbi08u/Cp/prKjJhY6bvcEL7lfZCSIJo7ZdIAGhl?=
 =?us-ascii?Q?bNsEI+uDn9KKiRu0icrOOHjKeyXcvERZLYAMp+JP0d5OLEe+DfjWq8i5S6CU?=
 =?us-ascii?Q?0isu3sMADeoHLMV/8z1xh9YPMNy1jeEF9Nc2xsSp7wqpgQjpD9PquxCeAs5+?=
 =?us-ascii?Q?nXfQVgDh68LQo9dj7//BWk/iREIi4fyfVvvmbM+vF2mT2/EkA0RkUsq6MKyU?=
 =?us-ascii?Q?+h4ckdXWReGjIbZO4ZI0dEGbuDX1ISMjGrroYM+zg9kGg/uyzgpP2/ZuAi3n?=
 =?us-ascii?Q?pQArVK+yqhJjYHG4HBsCaEni9PBDwye6SqcR3xd2rndh20NXn3N8sHhll3En?=
 =?us-ascii?Q?lYaqcY4hxu+4L/umkJaPP/lNssw1bDL9HizVaEs814NpuWXKtcT4dl9QDmPx?=
 =?us-ascii?Q?jLqhQ6xW5WdWJ81oCpikodgBCiR2zG5t96ZB+tMdSD3R6CYH5sIwEV5n/xaK?=
 =?us-ascii?Q?7Hj6tqc+tKWqaArKFSym5KxAcueL+YRDLlH3vJrwzG4Q98tXNGp5OxpVq35x?=
 =?us-ascii?Q?XO71iJ4oohiFpd8AeBFy6fRC7Ns+nS1jOBYqvSLH1dDUA25nXxJshEbFFLrp?=
 =?us-ascii?Q?uuUl+b2WwS+rY3PyX9ZlSW1ODOYjClWkZHCON714Iz+zLmY5ODiS2cBhDLUK?=
 =?us-ascii?Q?Y0vEfaO1XJ1+zhRx2KAbaBH/KFMRtAO/JmBj3u4k5NTvtU6Fte3jn5NB2dOm?=
 =?us-ascii?Q?BwTqtQb7HhwArKe1MazdiUi8tsJsIee1UcI21Z7HIiMtVtZ/wOS+DMs8DWAV?=
 =?us-ascii?Q?DA9zr5LLFy6OB8eUqlywObf8dALALvMDRxYI3orZBYkz7dWfl2138liAt2SQ?=
 =?us-ascii?Q?Qzl50bPybKsX6VZRZwKouJuxjQWLDYkpeQzjwdRmXPTcemoboRV46D2YaH/g?=
 =?us-ascii?Q?34U40O4ailH2eN1LpVMJUrWkmslx6QPNITC4P9HQNt/Zk8E/NmoPQrdAiIGV?=
 =?us-ascii?Q?/8jP3LwElW1PdBDi73qUnZPGF8d2b3LRvSIuIKzczZF7IokcFcGae7jWb+4S?=
 =?us-ascii?Q?At+RCeVR7V5TZTcpp36L6BdEUgF649fdJfhYp4GB?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e2609e41-91f7-4367-b252-08dc6933d6b6
X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB3849.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Apr 2024 16:37:34.7369
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2LhipoxOScgs9VyS1e88YPMWLmuC2Ja8c1Ct7LWYb1XJWID+Z+0SWq/HVKuz8X7W
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4190

On Tue, Apr 30, 2024 at 09:30:43AM -0700, Nicolin Chen wrote:
> >  	queue_write(Q_ENT(q, cons), cmd, q->ent_dwords);
> 
> Here is the only caller for "msi=false". Maybe we could just do:
> +	arm_smmu_cmdq_build_sync_cmd(cmd, smmu, q, cons);
> 
> So, no need of "bool msi"? It would slightly change the behavior
> though, a SYNC for ARM_SMMU_OPT_MSIPOLL should be still a SYNC.

I don't know, I didn't try to figure out what to stick for prod in
that case. It is probably OK to convert an error entry into a MSI
sync if it works out?

Jason