Received-SPF: pass (google.com: domain of linux-kernel+bounces-164407-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Tue, 30 Apr 2024 09:42:04 -0700
From: Dan Williams <dan.j.williams@intel.com>
To: Robert Richter <rrichter@amd.com>, "Rafael J. Wysocki"
	<rafael@kernel.org>, Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar
	<mingo@redhat.com>, Borislav Petkov <bp@alien8.de>, Dave Hansen
	<dave.hansen@linux.intel.com>, <x86@kernel.org>, Andy Lutomirski
	<luto@kernel.org>, Peter Zijlstra <peterz@infradead.org>, Alison Schofield
	<alison.schofield@intel.com>, Dan Williams <dan.j.williams@intel.com>
CC: <linux-acpi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-cxl@vger.kernel.org>, Robert Richter <rrichter@amd.com>, Derick Marks
	<derick.w.marks@intel.com>, "H. Peter Anvin" <hpa@zytor.com>, Len Brown
	<lenb@kernel.org>
Subject: Re: [PATCH v6 1/7] x86/numa: Fix SRAT lookup of CFMWS ranges with
 numa_fill_memblks()
Message-ID: <66311f5c59e15_10c212947f@dwillia2-mobl3.amr.corp.intel.com.notmuch>
References: <20240430092200.2335887-1-rrichter@amd.com>
 <20240430092200.2335887-2-rrichter@amd.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20240430092200.2335887-2-rrichter@amd.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?/u8CqbI9+O562LphGK8/ymy0rUJrII2LmIup6HPhZmciuQLwxrcwAvXUsZ9D?=
 =?us-ascii?Q?p6Si6idCt+afXUSju1ezJl8WlVnuR1UfBAzNPNbm3xien8wNmjs9+k/bEpJc?=
 =?us-ascii?Q?nKAF7oS1E4eDDnal+mica/u2emJOKn0iM4GFSJeyLLCjHqunZ5WOqyEiFN0i?=
 =?us-ascii?Q?AlGAWCuUD2D0GjKW19KzCUH9R32T4baNVsAU/mU2CdXKcRsnt7nSU8EAU/PC?=
 =?us-ascii?Q?jMmNsfHBXNEDeT9AkY3CAStflJMLp18T6pM54WPxh3jdNj4OwRfUxBJIL/G2?=
 =?us-ascii?Q?K86JraDbF1H+bYJ7A22SJ4mdhdFcKu8oqLfqnn1msL0RZZYbPExgJyB/j99j?=
 =?us-ascii?Q?rJFZxlhXQPTFbBVnO2dkyQjo3Ll7gWse6+38BjRIaBSxa5eYP2TPxzZJLGcf?=
 =?us-ascii?Q?+ImFFyoLYVx/F2LjuD3Vg3Ij248XrKTF9r7dVLEM985Kal8CS9TNvek3GGJJ?=
 =?us-ascii?Q?T7Mb1FyE+XFJtL+R8taTsvyFm9hEXcwotmS473wjktSmcURnBXNC+GazIG7C?=
 =?us-ascii?Q?b5fOYjR82rBz4ImNgDU3VQuZpJAU2piafOW9a7kLu3yN/a+f0Us1USms9RAP?=
 =?us-ascii?Q?HY+9VlQIluuThnAKMWvzlgLVSH+hyeAiTuHNEQh9ZTFttawSpVrtXK7DDN8P?=
 =?us-ascii?Q?RA1Nr424GlSVyTgVJ2Brp5fYJfw8/STSsdAMVX8C17r8tFptwPTMZYJ2N6QL?=
 =?us-ascii?Q?nrYlJZqMQx9XUlOgUfJ+zUYTt69eyGdTR+V87zdkBbveOfful6OgiuXU6c41?=
 =?us-ascii?Q?slNe+mw9eiZYcxyehiFflhGucPlZxOOAjllfkReTzUmS3KcWSe9IenwnBI+Z?=
 =?us-ascii?Q?aGhGrbLTgLsEVqwXOoi1BrPypOziRsIvbaEldy7fFekN2nzMpU3Ot2u2D4ul?=
 =?us-ascii?Q?2p9gkeNxLDarpqGyHJm27rvC6WLbe00OtG1tjYFJlPRMtITFYBDvFSMy08kD?=
 =?us-ascii?Q?LLiLcVGIamf/A6WV/qP6r0xpHB1rkYolRGuSw2N67r8jS38/urzhHyVqplyD?=
 =?us-ascii?Q?vptWyuve0opoNKcB6+GcVig3ijXXKCs8rlsD8uVbxTRanQ2EW1I1X2v/Pdu/?=
 =?us-ascii?Q?eXodqOafoqY+VCaSKyCZh48t2S9iFrSkdrofOmckVay/DP5d/yefRAv/c6W5?=
 =?us-ascii?Q?snHvt1UX18yPtLz41xi3FQm3OV4Drl4uFRh9uG744X4yujO2+XV/bQuHSdvF?=
 =?us-ascii?Q?+hSbhqH8NRe09RVT8jQXu6CWe7nMzESMrXeZmuO2ZpN9kX/VD2PFFUWIHYS9?=
 =?us-ascii?Q?lKynp4a0IsRn/9gIFn/YPG4GtTytJnGK/3s2WAcmzp3ffh+PlKmsAxwObUfR?=
 =?us-ascii?Q?qp+wtjD1d8KOL/mDM6H8Eq0P53xra+JF4xx9syfx0SdWtCTjvxo4RLHrgdDu?=
 =?us-ascii?Q?tLN2aaRqobJCD1s9l7MySC35U73sHu5RiJabi6x5SRR5OCQbavuUPrJTDaR2?=
 =?us-ascii?Q?UIMI1d7tPxTXCL1E0ZZK+EfgNnEe1hww2CY29lBcTH1zVUYmXMhOq+LNrB7c?=
 =?us-ascii?Q?u8yo1NvnI5XEevJCey7KKe5kdr2APp3NePo3z00tja5MvjL/ibKzpL9gS4Om?=
 =?us-ascii?Q?FI1++Ix7E7Z34uCVycsgxalGvS8S6t4ak/wCDL6xjtAkhRCKHTYywehrgYvO?=
 =?us-ascii?Q?lg=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: f49fcb40-b663-4ba0-82b6-08dc6934796b
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Apr 2024 16:42:07.7179
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: KU9Gkt28QB1B29fD5KnomPdB/HJrQXs6ViFZc4kbIqY1idkxVqyfuTk3qDt7Q4PmLxxPzjjVrLdL1dvvZq34863FPO5Q4l7lK9J5Wrh161k=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6908
X-OriginatorOrg: intel.com

Robert Richter wrote:
> For configurations that have the kconfig option NUMA_KEEP_MEMINFO
> disabled numa_fill_memblks() only returns with NUMA_NO_MEMBLK (-1).
> SRAT lookup fails then because an existing SRAT memory range cannot be
> found for a CFMWS address range. This causes the addition of a
> duplicate numa_memblk with a different node id and a subsequent page
> fault and kernel crash during boot.
> 
> Fix this by making numa_fill_memblks() always available regardless of
> NUMA_KEEP_MEMINFO.
> 
> The fix also removes numa_fill_memblks() from sparsemem.h using
> __weak.
> 
> From Dan:
> 
> """
> It just feels like numa_fill_memblks() has absolutely no business being
> defined in arch/x86/include/asm/sparsemem.h.
> 
> The only use for numa_fill_memblks() is to arrange for NUMA nodes to be
> applied to memory ranges hot-onlined by the CXL driver.
> 
> It belongs right next to numa_add_memblk(), and I suspect
> arch/x86/include/asm/sparsemem.h was only chosen to avoid figuring out
> what to do about the fact that linux/numa.h does not include asm/numa.h
> and that all implementations either provide numa_add_memblk() or select
> the generic implementation.
> 
> So I would prefer that this do the proper fix and get
> numa_fill_memblks() completely out of the sparsemem.h path.
> 
> Something like the following which boots for me.
> """
> 
> Note that the issue was initially introduced with [1]. But since
> phys_to_target_node() was originally used that returned the valid node
> 0, an additional numa_memblk was not added. Though, the node id was
> wrong too, a message is seen then in the logs:
> 
>  kernel/numa.c:  pr_info_once("Unknown target node for memory at 0x%llx, assuming node 0\n",
> 
> [1] commit fd49f99c1809 ("ACPI: NUMA: Add a node and memblk for each
>     CFMWS not in SRAT")
> 
> Suggested-by: Dan Williams <dan.j.williams@intel.com>
> Link: https://lore.kernel.org/all/66271b0072317_69102944c@dwillia2-xfh.jf.intel.com.notmuch/
> Fixes: 8f1004679987 ("ACPI/NUMA: Apply SRAT proximity domain to entire CFMWS window")
> Cc: Derick Marks <derick.w.marks@intel.com>
> Cc: Dan Williams <dan.j.williams@intel.com>
> Cc: Alison Schofield <alison.schofield@intel.com>
> Signed-off-by: Robert Richter <rrichter@amd.com>

Looks good,

Reviewed-by: Dan Williams <dan.j.williams@intel.com>