Received-SPF: pass (google.com: domain of linux-kernel+bounces-164500-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Tue, 30 Apr 2024 18:15:31 +0100
From: Conor Dooley <conor@kernel.org>
To: Alisa-Dariana Roman <alisadariana@gmail.com>
Cc: michael.hennerich@analog.com, linux-iio@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	alexandru.tachici@analog.com, lars@metafoo.de, jic23@kernel.org,
	robh@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	conor+dt@kernel.org, lgirdwood@gmail.com, broonie@kernel.org,
	andy@kernel.org, nuno.sa@analog.com, marcelo.schmitt@analog.com,
	bigunclemax@gmail.com, dlechner@baylibre.com, okan.sahin@analog.com,
	fr0st61te@gmail.com, alisa.roman@analog.com,
	marcus.folkesson@gmail.com, schnelle@linux.ibm.com,
	liambeguin@gmail.com
Subject: Re: [PATCH v7 4/6] dt-bindings: iio: adc: Add single-channel property
Message-ID: <20240430-perplexed-obedience-91e4bbc158e5@spud>
References: <20240430162946.589423-1-alisa.roman@analog.com>
 <20240430162946.589423-5-alisa.roman@analog.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="PDQmOlRp3irkveLm"
Content-Disposition: inline
In-Reply-To: <20240430162946.589423-5-alisa.roman@analog.com>


--PDQmOlRp3irkveLm
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Apr 30, 2024 at 07:29:44PM +0300, Alisa-Dariana Roman wrote:
> Devices that have both single-ended channels and differential channels
> cause a bit of confusion when the channels are configured in the
> devicetree.
>=20
> Clarify difference between these two types of channels for such devices
> by adding single-channel property alongside diff-channels. They should
> be mutually exclusive.

I think that this mutual exclusion and the requirement for reg in the
absence of either property should be enforced by the binding, not
described in a commit message or free-form text in the property
description.

>=20
> Devices that have only single-ended channels can still use reg property
> to reference a channel like before.
>=20
> Suggested-by: Jonathan Cameron <jic23@kernel.org>
> Signed-off-by: Alisa-Dariana Roman <alisa.roman@analog.com>
> ---
>  Documentation/devicetree/bindings/iio/adc/adc.yaml | 8 ++++++++
>  1 file changed, 8 insertions(+)
>=20
> diff --git a/Documentation/devicetree/bindings/iio/adc/adc.yaml b/Documen=
tation/devicetree/bindings/iio/adc/adc.yaml
> index 36775f8f71df..0c3eae580732 100644
> --- a/Documentation/devicetree/bindings/iio/adc/adc.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/adc.yaml
> @@ -38,6 +38,14 @@ properties:
>        The first value specifies the positive input pin, the second
>        specifies the negative input pin.
> =20
> +  single-channel:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    description:

> +      When devices combine single

s/single/single-ended/, no?

Cheers,
Conor.

> and differential channels, allow the channel
> +      for a single element to be specified, independent of reg (as for
> +      differential channels). If this and diff-channels are not present =
reg
> +      shall be used instead.
> +
>    settling-time-us:
>      description:
>        Time between enabling the channel and first stable readings.
> --=20
> 2.34.1
>=20

--PDQmOlRp3irkveLm
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZjEnMgAKCRB4tDGHoIJi
0nmFAP0SFmFJ06QVr/ZUb8POUYIM+y3lJg9ACZUMhkbdpdaIbgEAlT+Fr0iOnvsi
3Fopg90rdUWM/dPtiohMVjLK6+URqA0=
=6E9G
-----END PGP SIGNATURE-----

--PDQmOlRp3irkveLm--