Received-SPF: pass (google.com: domain of linux-kernel+bounces-164512-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <c2fd505a-1d4e-411a-80d4-c088843313d6@amd.com>
Date: Tue, 30 Apr 2024 13:28:37 -0400
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v4 12/15] drm/amd/display: Only use hard-float, not
 altivec on powerpc
To: Samuel Holland <samuel.holland@sifive.com>,
 Andrew Morton <akpm@linux-foundation.org>,
 linux-arm-kernel@lists.infradead.org, x86@kernel.org
Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
 linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org,
 Christoph Hellwig <hch@lst.de>, loongarch@lists.linux.dev,
 amd-gfx@lists.freedesktop.org, Michael Ellerman <mpe@ellerman.id.au>,
 Alex Deucher <alexander.deucher@amd.com>
References: <20240329072441.591471-1-samuel.holland@sifive.com>
 <20240329072441.591471-13-samuel.holland@sifive.com>
Content-Language: en-US
From: Harry Wentland <harry.wentland@amd.com>
In-Reply-To: <20240329072441.591471-13-samuel.holland@sifive.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?aVR0emlKdE9ZaDJwOE1EL1gwZFNudHhvNzRxU3ZLSWIwNThyRlQwY3BtcDZw?=
 =?utf-8?B?c0loTFhKYXJtNitxWG0veWtsUkQ1WHNaYUNKZlF3TjZmWEdzazdncXhmazds?=
 =?utf-8?B?QjlSZkJScXlTVHovNjRsQXJ6ZFBCZEExY2VtZmpkMDFGNmVZV0ZvU1VwVnFC?=
 =?utf-8?B?cnFNcTNvMFBUaHJlZy9Dakg0Y3dKdWliZ2cydG5LVVI2WklrNWdDZjczYWF3?=
 =?utf-8?B?TU96MC9iVk5oQTBGUEllTUlaMTRienRXRUk3RUZDbDByYytFTmMxM2pDV1Fr?=
 =?utf-8?B?MUFuMk0vOVd3OUg2dXgrbnNpb0FhdE1zMFp2MTYzWk5FR1pFSiszWWl4bG9w?=
 =?utf-8?B?ZFFtTHpvWTdlMUpaUDdMaTlkem5pbVJXcnhIRTdKT3JDOWsreGo0MnI4dUNq?=
 =?utf-8?B?QjFxdjhGRWxKeEVkQlozYjR0RzdPSXlTTGdPZnRzRDI1RW41SHhaZWx0dUU4?=
 =?utf-8?B?Snd2cDVlb3ZXMkJFQTNXanNzMDdXVy9nWGR0dk40ZFJWTUFhSTFUMkNnWG1H?=
 =?utf-8?B?eEZqNmVsdmxxU2pwVHhaR0VEK2tRMGFaWUY2SkFhTmtaNHF3SjcyUlE1bmJ0?=
 =?utf-8?B?cnF3OGYycldnRFZpRHM2TmsxeG1wM010Wjc1R1lFZ05KenY0dGQ1aVk2MVRr?=
 =?utf-8?B?cHN2ekduS2NMalMyMEdyZnlMUXBLQnJjelhvKzdGSGVCQVQra2ovM25ONkhN?=
 =?utf-8?B?U3NjNzNxWHptWVFuL0FsMURZaFFZYXc1VVVsVGdsQ2RTWVpkME1hdTlWcCt1?=
 =?utf-8?B?cVFwY003ZSt4c2ZNbnQvalRONUhrUXpvdFNuT1VDc2wyMWwvemtMOEhkYUJQ?=
 =?utf-8?B?QlBNY3dPOGpDK3c4ZXNjVmt0Y2Z1cG5uL0hmcC92Qzl3cHViRTE3K0ZrUEg5?=
 =?utf-8?B?Ym8yMlZhTVJPbDF2MVNCRm5GZ2tBc1MwSUwza3pkTTVsbkcyeGI2YzVHODJI?=
 =?utf-8?B?ekx0RTNyT09qT0UzNnRzbEw4dmxhWURwN3JhdHVpUDkwSGVIRGMvcFFyMUI1?=
 =?utf-8?B?TWlHQU11RG4rTlQ4UUVhMmVGMkt6T2cxbGMrRjBBUFB1QzZxWkZsSGp0ZFlk?=
 =?utf-8?B?TnNGODdjZmtnM0pvcFJYWTFtd0habCszMFAzV09Ra3VUWXlEaWI4WWRuMDBk?=
 =?utf-8?B?SmJOd2dIek4vNElWbU5PQklLdlBUQS96azR5bWliN1g4OTBKSHVUTmNabmlq?=
 =?utf-8?B?WHQ4ZVM0Q1M2MFJrbVdmSnNMWStsQ1FvaWNPUHZ5Q21UdFVmVzNqVWx4cHF6?=
 =?utf-8?B?TmlkZHhBZUxnbzh5WnNsK1hLdVlEMFJzUllzM0xCUnYxYVllanVXaEszd0J2?=
 =?utf-8?B?V3pxaVlvT0RBSGR6L1hSc2dncnVSNnNPS05vZjQ1RytZWDFkZXNxVTU4MG5Z?=
 =?utf-8?B?NU1sNjBabGVIRE0yOTQzWCttVVprTkxleGxvRXYxTW9IQUFwK0tnSFdRYW9F?=
 =?utf-8?B?RHRaMEQ5ZHRKSllWeHdkaGl0a3ozWGRpL1gyOFNQUDVKTnlIbWlpNVZTODE1?=
 =?utf-8?B?eHBiblNybys1c05BUllVRGNlTFU0cDI0cjZiVGtiMnoycUp5cTRna0dRcTBi?=
 =?utf-8?B?bVBoSHhNSHlFa1p4Y1lNU3Z4SjI5bjQ2N09ITnhTUHlXOGhYdlZtRnQ0cXND?=
 =?utf-8?B?Y3ZScTNuL3YzMVFYYUtWaGZsQW4wYlRTaW55QWh6dkF6eUorbmtvVTFJU0xx?=
 =?utf-8?B?RTRiVVhMa0o0cWZrUDZ5YzFYNzJ4WjNuU0c2U3F6VU82dkI2T1pJaXlIb1hW?=
 =?utf-8?B?TEQyUjdhaHlUYWRVVGdwaE83QUsyUjZXbWZ0VEphVE5zem9Zc0RMQXIwdml1?=
 =?utf-8?B?TW5sL2N4M3BWeDNhN1diV21YZzljN0V2RVo0Q2xIVFBEMGUxeFh4MzlZc1BJ?=
 =?utf-8?B?THpjbE01RnNwMTdiUk10SmRNSnZRSG83QXhkMGs2QUROQjVqTlcvaUJ0Z3N2?=
 =?utf-8?B?SEFCY3dXemxBRWVWU0NyTGdCQmJFM1IxK1BPUHRoZE0xeGI5VW0xcHJOS2pw?=
 =?utf-8?B?NG5QalVtQVBnQ0tHTTZRWkhOYjBVN0dlUUNmRkRMa3c5NnRDUTdJa2JKR2VH?=
 =?utf-8?B?K2Z2MHRkMk5ZWXRRRWV6ZktyY09aRHVTakVFRFJXMDYwai83aWYzWWk1ZUh3?=
 =?utf-8?Q?q6EcKyauALuVzmBBi3FlxMZD8?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 89c8bf1f-1a6f-45fe-58ff-08dc693afb2f
X-MS-Exchange-CrossTenant-AuthSource: CO6PR12MB5427.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Apr 2024 17:28:42.5166
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: WxAdDidFwh+KWt+TifQA8t8UOoHX29w/cwELUQ8CipUgYA67W/e0wpIaoCi12S0FGGvxAgoSklnbwnlqbaOydw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW6PR12MB8999

On 2024-03-29 03:18, Samuel Holland wrote:
> From: Michael Ellerman <mpe@ellerman.id.au>
> 
> The compiler flags enable altivec, but that is not required; hard-float
> is sufficient for the code to build and function.
> 
> Drop altivec from the compiler flags and adjust the enable/disable code
> to only enable FPU use.
> 
> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
> Acked-by: Alex Deucher <alexander.deucher@amd.com>
> Signed-off-by: Samuel Holland <samuel.holland@sifive.com>

Acked-by: Harry Wentland <harry.wentland@amd.com>

Harry

> ---
> 
> (no changes since v2)
> 
> Changes in v2:
>  - New patch for v2
> 
>  drivers/gpu/drm/amd/display/amdgpu_dm/dc_fpu.c | 12 ++----------
>  drivers/gpu/drm/amd/display/dc/dml/Makefile    |  2 +-
>  drivers/gpu/drm/amd/display/dc/dml2/Makefile   |  2 +-
>  3 files changed, 4 insertions(+), 12 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/dc_fpu.c b/drivers/gpu/drm/amd/display/amdgpu_dm/dc_fpu.c
> index 4ae4720535a5..0de16796466b 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/dc_fpu.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/dc_fpu.c
> @@ -92,11 +92,7 @@ void dc_fpu_begin(const char *function_name, const int line)
>  #if defined(CONFIG_X86) || defined(CONFIG_LOONGARCH)
>  		kernel_fpu_begin();
>  #elif defined(CONFIG_PPC64)
> -		if (cpu_has_feature(CPU_FTR_VSX_COMP))
> -			enable_kernel_vsx();
> -		else if (cpu_has_feature(CPU_FTR_ALTIVEC_COMP))
> -			enable_kernel_altivec();
> -		else if (!cpu_has_feature(CPU_FTR_FPU_UNAVAILABLE))
> +		if (!cpu_has_feature(CPU_FTR_FPU_UNAVAILABLE))
>  			enable_kernel_fp();
>  #elif defined(CONFIG_ARM64)
>  		kernel_neon_begin();
> @@ -125,11 +121,7 @@ void dc_fpu_end(const char *function_name, const int line)
>  #if defined(CONFIG_X86) || defined(CONFIG_LOONGARCH)
>  		kernel_fpu_end();
>  #elif defined(CONFIG_PPC64)
> -		if (cpu_has_feature(CPU_FTR_VSX_COMP))
> -			disable_kernel_vsx();
> -		else if (cpu_has_feature(CPU_FTR_ALTIVEC_COMP))
> -			disable_kernel_altivec();
> -		else if (!cpu_has_feature(CPU_FTR_FPU_UNAVAILABLE))
> +		if (!cpu_has_feature(CPU_FTR_FPU_UNAVAILABLE))
>  			disable_kernel_fp();
>  #elif defined(CONFIG_ARM64)
>  		kernel_neon_end();
> diff --git a/drivers/gpu/drm/amd/display/dc/dml/Makefile b/drivers/gpu/drm/amd/display/dc/dml/Makefile
> index c4a5efd2dda5..59d3972341d2 100644
> --- a/drivers/gpu/drm/amd/display/dc/dml/Makefile
> +++ b/drivers/gpu/drm/amd/display/dc/dml/Makefile
> @@ -31,7 +31,7 @@ dml_ccflags := $(dml_ccflags-y) -msse
>  endif
>  
>  ifdef CONFIG_PPC64
> -dml_ccflags := -mhard-float -maltivec
> +dml_ccflags := -mhard-float
>  endif
>  
>  ifdef CONFIG_ARM64
> diff --git a/drivers/gpu/drm/amd/display/dc/dml2/Makefile b/drivers/gpu/drm/amd/display/dc/dml2/Makefile
> index acff3449b8d7..7b51364084b5 100644
> --- a/drivers/gpu/drm/amd/display/dc/dml2/Makefile
> +++ b/drivers/gpu/drm/amd/display/dc/dml2/Makefile
> @@ -30,7 +30,7 @@ dml2_ccflags := $(dml2_ccflags-y) -msse
>  endif
>  
>  ifdef CONFIG_PPC64
> -dml2_ccflags := -mhard-float -maltivec
> +dml2_ccflags := -mhard-float
>  endif
>  
>  ifdef CONFIG_ARM64