Received-SPF: pass (google.com: domain of linux-kernel+bounces-164516-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240430010628.430427-1-edliaw@google.com> <2024043037-debate-capsize-e44c@gregkh>
In-Reply-To: <2024043037-debate-capsize-e44c@gregkh>
From: Edward Liaw <edliaw@google.com>
Date: Tue, 30 Apr 2024 10:29:43 -0700
Message-ID: <CAG4es9VL8CdROKVygYi3YAo3ZuugXgiyt6uhf+3yq6s8iKfQeg@mail.gmail.com>
Subject: Re: [PATCH 6.6.y] kselftest: Add a ksft_perror() helper
To: Greg KH <gregkh@linuxfoundation.org>
Cc: stable@vger.kernel.org, Shuah Khan <shuah@kernel.org>, kernel-team@android.com, 
	Mark Brown <broonie@kernel.org>, Kees Cook <keescook@chromium.org>, 
	Shuah Khan <skhan@linuxfoundation.org>, linux-kselftest@vger.kernel.org, 
	linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, Apr 30, 2024 at 12:51=E2=80=AFAM Greg KH <gregkh@linuxfoundation.or=
g> wrote:
>
> On Tue, Apr 30, 2024 at 01:06:27AM +0000, Edward Liaw wrote:
> > From: Mark Brown <broonie@kernel.org>
> >
> > [ Upstream commit 907f33028871fa7c9a3db1efd467b78ef82cce20 ]
> >
> > The standard library perror() function provides a convenient way to pri=
nt
> > an error message based on the current errno but this doesn't play nicel=
y
> > with KTAP output. Provide a helper which does an equivalent thing in a =
KTAP
> > compatible format.
> >
> > nolibc doesn't have a strerror() and adding the table of strings requir=
ed
> > doesn't seem like a good fit for what it's trying to do so when we're u=
sing
> > that only print the errno.
> >
> > Signed-off-by: Mark Brown <broonie@kernel.org>
> > Reviewed-by: Kees Cook <keescook@chromium.org>
> > Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
> > Stable-dep-of: 071af0c9e582 ("selftests: timers: Convert posix_timers t=
est to generate KTAP output")
> > Signed-off-by: Edward Liaw <edliaw@google.com>
> > ---
> >  tools/testing/selftests/kselftest.h | 14 ++++++++++++++
> >  1 file changed, 14 insertions(+)
>
> This commit is already in 6.6.29, why submit it again?

Hi Greg,
I double checked and I don't see this commit in 6.6.29.   As far as I
can tell the earliest it has been merged is in 6.7.1.  Do you mind
rechecking?

Thank you,
Edward

>
> confused,
>
> greg k-h