Received-SPF: pass (google.com: domain of linux-kernel+bounces-164521-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240430060612.2171650-1-shakeel.butt@linux.dev> <20240430060612.2171650-7-shakeel.butt@linux.dev>
In-Reply-To: <20240430060612.2171650-7-shakeel.butt@linux.dev>
From: "T.J. Mercier" <tjmercier@google.com>
Date: Tue, 30 Apr 2024 10:32:05 -0700
Message-ID: <CABdmKX2-5k7o9P0LDkghr5EFLwe=42aBU9kVfd05+4-Uf41WiA@mail.gmail.com>
Subject: Re: [PATCH v3 6/8] mm: cleanup WORKINGSET_NODES in workingset
To: Shakeel Butt <shakeel.butt@linux.dev>
Cc: Andrew Morton <akpm@linux-foundation.org>, Johannes Weiner <hannes@cmpxchg.org>, 
	Michal Hocko <mhocko@kernel.org>, Roman Gushchin <roman.gushchin@linux.dev>, 
	Muchun Song <muchun.song@linux.dev>, Yosry Ahmed <yosryahmed@google.com>, kernel-team@meta.com, 
	linux-mm@kvack.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, Apr 29, 2024 at 11:06=E2=80=AFPM Shakeel Butt <shakeel.butt@linux.d=
ev> wrote:
>
> WORKINGSET_NODES is not exposed in the memcg stats and thus there is no
> need to use the memcg specific stat update functions for it. In future
> if we decide to expose WORKINGSET_NODES in the memcg stats, we can
> revert this patch.
>
> Signed-off-by: Shakeel Butt <shakeel.butt@linux.dev>
> Reviewed-by: Roman Gushchin <roman.gushchin@linux.dev>

Reviewed-by: T.J. Mercier <tjmercier@google.com>

> ---
>
> Changes since v2:
> - N/A
>
>  mm/workingset.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/mm/workingset.c b/mm/workingset.c
> index f2a0ecaf708d..c22adb93622a 100644
> --- a/mm/workingset.c
> +++ b/mm/workingset.c
> @@ -618,6 +618,7 @@ struct list_lru shadow_nodes;
>  void workingset_update_node(struct xa_node *node)
>  {
>         struct address_space *mapping;
> +       struct page *page =3D virt_to_page(node);
>
>         /*
>          * Track non-empty nodes that contain only shadow entries;
> @@ -633,12 +634,12 @@ void workingset_update_node(struct xa_node *node)
>         if (node->count && node->count =3D=3D node->nr_values) {
>                 if (list_empty(&node->private_list)) {
>                         list_lru_add_obj(&shadow_nodes, &node->private_li=
st);
> -                       __inc_lruvec_kmem_state(node, WORKINGSET_NODES);
> +                       __inc_node_page_state(page, WORKINGSET_NODES);
>                 }
>         } else {
>                 if (!list_empty(&node->private_list)) {
>                         list_lru_del_obj(&shadow_nodes, &node->private_li=
st);
> -                       __dec_lruvec_kmem_state(node, WORKINGSET_NODES);
> +                       __dec_node_page_state(page, WORKINGSET_NODES);
>                 }
>         }
>  }
> @@ -742,7 +743,7 @@ static enum lru_status shadow_lru_isolate(struct list=
_head *item,
>         }
>
>         list_lru_isolate(lru, item);
> -       __dec_lruvec_kmem_state(node, WORKINGSET_NODES);
> +       __dec_node_page_state(virt_to_page(node), WORKINGSET_NODES);
>
>         spin_unlock(lru_lock);
>
> --
> 2.43.0
>