Received-SPF: pass (google.com: domain of linux-kernel+bounces-164540-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Tue, 30 Apr 2024 18:40:24 +0100
From: Conor Dooley <conor@kernel.org>
To: "Rob Herring (Arm)" <robh@kernel.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] yamllint: Drop excluding quoted values with ',' from
 checks
Message-ID: <20240430-unsnap-eskimo-444052f98b7d@spud>
References: <20240426195438.2771968-1-robh@kernel.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="RPjVfbQMebod70Rs"
Content-Disposition: inline
In-Reply-To: <20240426195438.2771968-1-robh@kernel.org>


--RPjVfbQMebod70Rs
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Apr 26, 2024 at 02:54:37PM -0500, Rob Herring (Arm) wrote:
> From: Rob Herring <robh@kernel.org>
>=20
> Strings with commas were excluded from checks because yamllint had false
> positives for flow style maps and sequences which need quotes when
> values contain commas. This issue has been fixed as of the 1.34 release,
> so drop the work-around.

Hmm, is this a bit aggressive of an upgrade? I only checked Debian since
it is what this machine uses, and it only seems to be shipping 1.33 in
testing & unstable.

>=20
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
>  Documentation/devicetree/bindings/.yamllint | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/Documentation/devicetree/bindings/.yamllint b/Documentation/=
devicetree/bindings/.yamllint
> index 358c88813937..fadbc6ad3c76 100644
> --- a/Documentation/devicetree/bindings/.yamllint
> +++ b/Documentation/devicetree/bindings/.yamllint
> @@ -7,7 +7,7 @@ rules:
>    quoted-strings:
>      required: only-when-needed
>      extra-allowed:
> -      - '[$^,[]'
> +      - '[$^[]'
>        - '^/$'
>    line-length:
>      # 80 chars should be enough, but don't fail if a line is longer
> --=20
> 2.43.0
>=20

--RPjVfbQMebod70Rs
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZjEtCAAKCRB4tDGHoIJi
0oFZAQD0JBzhXISrZJ4yB/rFSb4WQ9ET9q36W46JBQkBp3DuDwD9Fy+2z/xA/BqS
5K9c2nPGOH0eVUV/wZAlbDEuwRbcOgk=
=nE9f
-----END PGP SIGNATURE-----

--RPjVfbQMebod70Rs--