Received-SPF: pass (google.com: domain of linux-kernel+bounces-164550-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Tue, 30 Apr 2024 20:47:58 +0300
From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Edward Liaw <edliaw@google.com>
Cc: linux-kernel@vger.kernel.org, Shuah Khan <shuah@kernel.org>,
	"Eric W. Biederman" <ebiederm@xmission.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-kselftest@vger.kernel.org, kernel-team@android.com
Subject: Re: [PATCH] selftests/kcmp: Remove unused open mode
Message-ID: <ZjEuzoUMX1S19QGb@grain>
References: <20240429234610.191144-1-edliaw@google.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240429234610.191144-1-edliaw@google.com>
User-Agent: Mutt/2.2.12 (2023-09-09)

On Mon, Apr 29, 2024 at 11:46:09PM +0000, Edward Liaw wrote:
> Android bionic warns that open modes are ignored if O_CREAT or O_TMPFILE
> aren't specified.  The permissions for the file are set above:
> 
> 	fd1 = open(kpath, O_RDWR | O_CREAT | O_TRUNC, 0644);
> 
> Fixes: d97b46a64674 ("syscalls, x86: add __NR_kcmp syscall")
> Signed-off-by: Edward Liaw <edliaw@google.com>

Thanks!

Reviewed-by: Cyrill Gorcunov <gorcunov@gmail.com>