Received-SPF: pass (google.com: domain of linux-kernel+bounces-164558-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Precedence: bulk
MIME-Version: 1.0
References: <20240426195438.2771968-1-robh@kernel.org> <20240430-unsnap-eskimo-444052f98b7d@spud>
In-Reply-To: <20240430-unsnap-eskimo-444052f98b7d@spud>
From: Rob Herring <robh@kernel.org>
Date: Tue, 30 Apr 2024 12:53:07 -0500
Message-ID: <CAL_JsqJLEku=NT-JPE7cijdhPFEQm+i+cghOt6e4+LNOGP8oPg@mail.gmail.com>
Subject: Re: [PATCH] yamllint: Drop excluding quoted values with ',' from checks
To: Conor Dooley <conor@kernel.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, 
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, Apr 30, 2024 at 12:40=E2=80=AFPM Conor Dooley <conor@kernel.org> wr=
ote:
>
> On Fri, Apr 26, 2024 at 02:54:37PM -0500, Rob Herring (Arm) wrote:
> > From: Rob Herring <robh@kernel.org>
> >
> > Strings with commas were excluded from checks because yamllint had fals=
e
> > positives for flow style maps and sequences which need quotes when
> > values contain commas. This issue has been fixed as of the 1.34 release=
,
> > so drop the work-around.
>
> Hmm, is this a bit aggressive of an upgrade? I only checked Debian since
> it is what this machine uses, and it only seems to be shipping 1.33 in
> testing & unstable.

Humm, yeah and that's what the bot is running...

It's only required if you don't want warnings. The issue for me is if
we don't enable this, we get new cases we have to go fix. I could
enable it only on the bot (with some work), but then I get 'I ran the
checks and didn't see this'.

There is also a new check for quoted keys that I want to enable. I
haven't done that because then 1.34 is really required as yamllint
will error out on unknown (to older versions) checks. That's what
really drives the minimum version.

I'll hold off on this at least until it lands in debian.

Rob