Received-SPF: pass (google.com: domain of linux-kernel+bounces-164565-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Tue, 30 Apr 2024 19:00:57 +0100
From: Simon Horman <horms@kernel.org>
To: Shi-Sheng Yang <fourcolor4c@gmail.com>
Cc: matttbe@kernel.org, martineau@kernel.org, davem@davemloft.net,
	edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
	geliang@kernel.org, netdev@vger.kernel.org, mptcp@lists.linux.dev,
	linux-kernel@vger.kernel.org,
	Shi-Sheng Yang <james1qaz2wsx12qw@gmail.com>
Subject: Re: [PATCH] mptcp: subflow.c: fix typo
Message-ID: <20240430180057.GB2575892@kernel.org>
References: <20240429225033.3920874-1-james1qaz2wsx12qw@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240429225033.3920874-1-james1qaz2wsx12qw@gmail.com>

On Tue, Apr 30, 2024 at 06:50:33AM +0800, Shi-Sheng Yang wrote:
> Replace 'greceful' with 'graceful'.
> 
> Signed-off-by: Shi-Sheng Yang <james1qaz2wsx12qw@gmail.com>

Hi Shi-Sheng Yang,

Elsewhere in the same file 'earlier' is mispelt as 'eariler'.
Could you consider fixing that too?

Better still, could you consider running codespell over
net/mptcp/ and fixing (the non false-positives) that it flags?

If you do repost then I think an appropriate prefix
would be 'mctp: ' rather than 'mctp: subflow.c ',
as this follows the pattern in git history.

And I think the target tree should be net-next.
That is, the patch should be based on net-next and
it should be designated in the subject.

e.g. Subject: [PATCH v2 net-next] mptcp: fix typos in comments

Lastly, please keep in mind that 24h should elapse
before posting a new version.

Link: https://docs.kernel.org/process/maintainer-netdev.html

..