Received-SPF: pass (google.com: domain of linux-kernel+bounces-164616-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Tue, 30 Apr 2024 11:50:46 -0700
From: Ira Weiny <ira.weiny@intel.com>
To: Tony Luck <tony.luck@intel.com>, Ira Weiny <ira.weiny@intel.com>
CC: Dave Jiang <dave.jiang@intel.com>, Dan Williams
	<dan.j.williams@intel.com>, Jonathan Cameron <jonathan.cameron@huawei.com>,
	Smita Koralahalli <Smita.KoralahalliChannabasappa@amd.com>, Shiju Jose
	<shiju.jose@huawei.com>, Dan Carpenter <dan.carpenter@linaro.org>, "Yazen
 Ghannam" <yazen.ghannam@amd.com>, Davidlohr Bueso <dave@stgolabs.net>,
	"Alison Schofield" <alison.schofield@intel.com>, Vishal Verma
	<vishal.l.verma@intel.com>, Ard Biesheuvel <ardb@kernel.org>,
	<linux-efi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-cxl@vger.kernel.org>, "Rafael J. Wysocki" <rafael@kernel.org>,
	Borislav Petkov <bp@alien8.de>
Subject: Re: [PATCH v4 1/2] acpi/ghes: Process CXL Component Events
Message-ID: <66313d869fff9_1c68422945a@iweiny-mobl.notmuch>
References: <20240426-cxl-cper3-v4-0-58076cce1624@intel.com>
 <20240426-cxl-cper3-v4-1-58076cce1624@intel.com>
 <ZjE5O87IxxMAoaFz@agluck-desk3>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <ZjE5O87IxxMAoaFz@agluck-desk3>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?HOHyX3D5LJB84D0JnUSkN8kMiYWOhPaFrkm5f+JqJNw2iqwwt9DIXE18Cc/q?=
 =?us-ascii?Q?G3fDqyRwY1GFyo+8kQMf0uXw8HqdbBO2Ji6x9z6H8JbDxZNRW++6cjVXj9ud?=
 =?us-ascii?Q?ChbKL0nTByYtAGK6S3bUcwDCPHADeGQg+0Dh2s2TvAs0t0k0SuT4Md1aYIUV?=
 =?us-ascii?Q?+q05QXF3q5E2Pfa28/zsWHN3m59h1DI9/tXUS9VAP0+W2aK0/oCLbo7YbKci?=
 =?us-ascii?Q?qyb6y7SosLo05cnfVC7kGy4i6Sr/jcaA4f3luehXDhp+xIEhpm+TCEflFwbE?=
 =?us-ascii?Q?YwQ/7471CDl+7ngikFHeuYM4oQ91aMeOoQuUhU5bK5kkPMbiHSmTaTx++1P2?=
 =?us-ascii?Q?dMCL59aFRxmMEjEBirFKDzyp3hyY0eKkZud9fjg6RkBQBo5zPPijNQ8sl7tw?=
 =?us-ascii?Q?3n4qrPt8jMiuoPrzp4giF8kP/Re7BEuv3esJPuSrAsrLvdDfovHtja5BmRTJ?=
 =?us-ascii?Q?XzukceiqJh33XutDeZA9WVnwwKnmspZ79SEOZHns006sLnWrMptb20GgSdll?=
 =?us-ascii?Q?tMETGcsWzDpyGOPl2kUlSw+fKZxbuURZ1T5yJYyd4N9hygt4ge+dV5CAXVnj?=
 =?us-ascii?Q?3pO6aMoaTqv9eY9E/Zt3MlnRjnvckJf8Md8DAGxQ7y0JvtzrYBI9cAAF+jGv?=
 =?us-ascii?Q?ntrQ+tlnkiBi37odl56pDnp/hpgqNpKruTEN+ouqwXfiMiVPtEeb5xNkLf1w?=
 =?us-ascii?Q?uqZcHFM6kBT/90C0tVI1R2+S7NgoMOjGx+5v5V5jnA+iSA+t2k0VACd7qsev?=
 =?us-ascii?Q?0INYxjMCqoxF4C0qJBNX+XIksFghTKtq1eV7tNqZlgdE3bBtmZ/9v00LPMGf?=
 =?us-ascii?Q?a4jdFKEgFRLbw7UzB5lkZbwUusjS2NBSRK6BMvIObPdFwDkxJBSPOl/7c1IM?=
 =?us-ascii?Q?4QFTTYiI4rtkd8oEJcQ2/aD9NiiQgbt10Sl5/j09CdXDaNuF7JySgnEdFD41?=
 =?us-ascii?Q?woqrOg9Fu5NSSvPXanlHYQoSGw44gVJQKJRnxCBZ1HBRc2XsA5UzeEJycchu?=
 =?us-ascii?Q?FffCR/D8619zQP/NG7oQNDKfwDKB+kLH35dLmy1J0f1KWOa4qz/KsDXGhL5Z?=
 =?us-ascii?Q?IpIVK8LxpUpREAzkfNCTsE4/lyLvdd2uoANJ8IqG9yv7xptlKhkCeBQ7zxBj?=
 =?us-ascii?Q?lG2/sNLf5fFYC6xmVl7yFBsqYmkKhnQYwtIkyAqfSEo6k2Gx3Cp7/37tite/?=
 =?us-ascii?Q?jlAdvi9ArJeiZqBsEWc3zNZZY3rswrC5fM2lkt3Eaxp4uZAIVWeOskC0FGUg?=
 =?us-ascii?Q?GnAotIgwaUCy8XICoRw7+akBSgzBnZcSeBpeb3D7PpPYOQ0/bJes/BZceUkg?=
 =?us-ascii?Q?a5ij3PJHj8G52imrQElQiGNLrghnHSreo5hHyIOpJ7R8zdvXhvwfBG28VIQy?=
 =?us-ascii?Q?xapUjs7/b1YOy9c0ceF2QKu+cRcjGOknopbRWeTzpuiRMjEji1E4CHpTTsJh?=
 =?us-ascii?Q?FEB0ivFHCS7rrk3xMGA+ehGB4tuv92+MlU9ywuBombuF6vWn0SuuPmUcxgMP?=
 =?us-ascii?Q?tBXH/rnINVjbUdaYmSlGLWWCFFNbJH2JkuSZJIK66Bv6+yUv+tRVpvbNOUqA?=
 =?us-ascii?Q?kHzNXyoXnjw80SUQmEc41iNtn/XRP+VBxijFOMGB?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 11d91210-c05e-4362-a42a-08dc694674dc
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6733.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Apr 2024 18:50:51.1652
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: fAAr+owm9Y33WmJyfqs+fPvrnsaDwDfIfBf8g0eo2II1olEHHP4Pkkvkg2m+odNSEDGyHb6eEcn0QeYo2zJ85Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4520
X-OriginatorOrg: intel.com

Tony Luck wrote:
> On Fri, Apr 26, 2024 at 08:34:00PM -0700, Ira Weiny wrote:
> > @@ -707,6 +805,18 @@ static bool ghes_do_proc(struct ghes *ghes,
> >  		}
> >  		else if (guid_equal(sec_type, &CPER_SEC_PROC_ARM)) {
> >  			queued = ghes_handle_arm_hw_error(gdata, sev, sync);
> > +		} else if (guid_equal(sec_type, &CPER_SEC_CXL_GEN_MEDIA_GUID)) {
> > +			struct cxl_cper_event_rec *rec = acpi_hest_get_payload(gdata);
> > +
> > +			cxl_cper_post_event(CXL_CPER_EVENT_GEN_MEDIA, rec);
> > +		} else if (guid_equal(sec_type, &CPER_SEC_CXL_DRAM_GUID)) {
> > +			struct cxl_cper_event_rec *rec = acpi_hest_get_payload(gdata);
> > +
> > +			cxl_cper_post_event(CXL_CPER_EVENT_DRAM, rec);
> > +		} else if (guid_equal(sec_type, &CPER_SEC_CXL_MEM_MODULE_GUID)) {
> > +			struct cxl_cper_event_rec *rec = acpi_hest_get_payload(gdata);
> > +
> > +			cxl_cper_post_event(CXL_CPER_EVENT_MEM_MODULE, rec);
> >  		} else {
> >  			void *err = acpi_hest_get_payload(gdata);
> 
> You pass "rec" to cxl_cper_post_event() in all these cases for later
> processing in context where you can sleep to get locks. But that's
> just a pointer somewhere into the "gdata" error record received from
> BIOS.
> 
> What's the lifetime of that record?
>

The lifetime is contained to the cxl_cper_post_envent() which does not
block.  The kfifo_put() copies the data to a cxl specific record to be
used by the CXL thread for processing.

>
> Can it be re-used/overwritten
> before that other kernel thread gets around to looking at it?

Yes because the CXL kernel thread has its own copy in the kfifo.

Ira