Received-SPF: pass (google.com: domain of linux-kernel+bounces-164641-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240429040441.748479-1-sathyanarayanan.kuppuswamy@linux.intel.com>
 <Zi9hFbrIfyDhrA5R@smile.fi.intel.com>
In-Reply-To: <Zi9hFbrIfyDhrA5R@smile.fi.intel.com>
From: "Rafael J. Wysocki" <rafael@kernel.org>
Date: Tue, 30 Apr 2024 21:31:18 +0200
Message-ID: <CAJZ5v0g7omX=OcObvEAs=ArpW9s+C8CvuW7Ew5EzQfuVDhpZjQ@mail.gmail.com>
Subject: Re: [PATCH v2] ACPI: Move acpi_blacklisted() declaration to asm/acpi.h
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>, 
	Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
Cc: "Rafael J . Wysocki" <rafael.j.wysocki@intel.com>, linux-acpi@vger.kernel.org, 
	linux-kernel@vger.kernel.org, Len Brown <lenb@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, Apr 29, 2024 at 10:58=E2=80=AFAM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> On Sun, Apr 28, 2024 at 09:04:41PM -0700, Kuppuswamy Sathyanarayanan wrot=
e:
> > The function acpi_blacklisted() is defined only when CONFIG_X86 is
> > enabled and is only used by X86 arch code. To align with its usage and
> > definition conditions, move its declaration to asm/acpi.h
>
> FWIW,
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

I have replaced the v1 that was applied some time ago with this one.

> ...
>
> >  extern char acpi_video_backlight_string[];
> >  extern long acpi_is_video_device(acpi_handle handle);
> > -extern int acpi_blacklisted(void);
>
> I would replace it with a blank line (to me it seems the above and below =
are
> different groups from semantic point of view, but Rafael may correct me).

And I have added the blank line as suggested.

> >  extern void acpi_osi_setup(char *str);
> >  extern bool acpi_osi_is_win8(void);
>
> --

Thanks!