Received: by 2002:ab2:60d1:0:b0:1f7:5705:b850 with SMTP id i17csp59160lqm; Tue, 30 Apr 2024 12:42:10 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCX6Q3WZ2UMiNZUAQzXJKuOpeKae+iiwEoeqhqfblDyuoVvL0qCG75aZ692/ZAP59wfaDOTZbyNUuKl1CXJa6Fk6CtLFnOuJ5IpPz2l3RQ== X-Google-Smtp-Source: AGHT+IE/fXYT9uKamFA+XSGBMVk72WU5vLD5jd2G6uI4v4S4wGEDvaHi+odirxxfrgh5DL86tH3w X-Received: by 2002:a17:906:f6d9:b0:a55:5958:cb00 with SMTP id jo25-20020a170906f6d900b00a555958cb00mr3051799ejb.38.1714506129992; Tue, 30 Apr 2024 12:42:09 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1714506129; cv=pass; d=google.com; s=arc-20160816; b=wCIHUV1BlmWycSA7eLW/BI6Ntsi6hGUA/Zk3utRqCdARFCzFaVJae/w3/i+IzulamF 6E11wuuE9W9mLp34RHuXX9WYPmQtC2gj8Z6lk7IPYFEUgdLH/A4rJcGSMoh4aVBUDIP0 xwgIjYt3FPMlTIvCvGGM4o53RfDViVhfgC3R9hp+9Ld76Go1gtzqwonRQUmXrvrut/zO 5opIu+zgsewyxSYPmF8RZeQIOnt9K6yzfRZQC+0eELPEc/W+dISusgCi0DpX9klk9bzG A/nJUQ0yaOLOGORqEzExnPVYg5YgK/934JKsgLkq0vuUrt89fJ1WWlvumhprghsdoIvj wy9w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=organization:in-reply-to:content-disposition:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:references :message-id:subject:cc:to:from:date:dkim-signature; bh=mrGUaeD9PjgAFWjYzYFq/3IJq0bvsbIT+MflNWonerQ=; fh=rUqV4QUrxLT6/HuCE2QQiPAo/V6NNQsQKpbFhhGN9bw=; b=rVSp2g8mDFYSMfFFs+IVo7Ik/6cn7WcF99qiIuym3g6KdTD63ga4uT9ClSY6x0rUcj 3j29Rq7zxwTv6MCuxQDcOq5b31oK8kgJOucJbZ9xyR/mn6fMilHaCgrLgRdugJSIRJ6B PVRg4pm+6CfdCgC+XueNIuFbxOZS9YwzQ0kwoFT1vWbk3thZ5sTiXydb/Jbv6X3lf45y sk4KO9vI9Oouunz4Q4fnQv5buaDTysW1cBTpUsn4J44vTHltBAYGhjbkAEUmgkrvx4BB duYUMCFlL7Gx4Xzig6pEZDy2p9FKSfRht5N76ANgbPfY4B0aXNad8Y8GkEz9ROYrxOrO CP6g==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="RfER//q/"; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-164290-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-164290-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id ga34-20020a1709070c2200b00a55b01a75b1si13211545ejc.363.2024.04.30.12.42.09 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Apr 2024 12:42:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-164290-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="RfER//q/"; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-164290-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-164290-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 6B3F01F247C8 for ; Tue, 30 Apr 2024 15:37:31 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id BB87014375A; Tue, 30 Apr 2024 15:37:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="RfER//q/" Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 945011527AF; Tue, 30 Apr 2024 15:37:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714491442; cv=none; b=W04MOAsgir5ZIDR7+8OAdNJA91HO1rkpzPoqWEVxSImOrrtn30OdW8CMvhLB/F8fb2n9lpDYTAm9ozDwfNF7Wr6KyaF+9ArMJv1+iO7/EOCabGu3mhVg43DDU9KsqarQWO3geatTLqBAR0qdac8V2pPkddN/NZGai6V/mKl+XUE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714491442; c=relaxed/simple; bh=e6pUJhjQW6nIxwf6P9VZRO76v+TpkWhCfGxiUDE2B0g=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=EHDxba8cKFxrqNf1G4nk9OOT6Xm8u1L2KuXbRo6DuWeOL9IQ2BgphpHBzTNHvDnAyCDfzFOFCtA+R42K9NGwTvCXYriSYh+FS+DknIAKBnkE7BAwNVUH5uQAB/1Y6OG4Lqg/qcrxM2pwrIxh7zdyjng5tMjr+qrL+fFo/aAhbTY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=RfER//q/; arc=none smtp.client-ip=192.198.163.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1714491441; x=1746027441; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=e6pUJhjQW6nIxwf6P9VZRO76v+TpkWhCfGxiUDE2B0g=; b=RfER//q/JVV2Br/gNtB6FfDyZbqKhzkqDy9CGsQDRsSSNbPDyIqD2s4m /YU84PRmXCO2aCJRdhmPCEHcWqT95KduuI7s/K5JRAboQ7+H34hU1fzxU TIKh5wYsA9/3JOzBXobTcmKjnPKXSbSao0yJL9LyRpe3RYOHQVK3imSFv Kq8zTFsw1c2h5YaWsk8ZPlxljFDdnVUHnwyCBv+od0FU7o6mo/Vv6tEZQ qSPD5Y5fNMF4K7K+32M/esH9J8TeWsSszXeQK6xAIfiq8dtYNrSidhU9z uMyPAK/n+mT18Ih8aYzlxg65Y248xxsNAPxyV65J//OsuVsvaohTVO3Wy Q==; X-CSE-ConnectionGUID: VK/tX2m3ROqkKszHPlpmGw== X-CSE-MsgGUID: fgwYYLZWSdayBjKfWt0OXA== X-IronPort-AV: E=McAfee;i="6600,9927,11060"; a="35591262" X-IronPort-AV: E=Sophos;i="6.07,242,1708416000"; d="scan'208";a="35591262" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Apr 2024 08:37:20 -0700 X-CSE-ConnectionGUID: cY3uSIQgQAymBhD7ehXS2w== X-CSE-MsgGUID: X5dBi9jNReG7s0mpWyUYWA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,242,1708416000"; d="scan'208";a="57678464" Received: from smile.fi.intel.com ([10.237.72.54]) by fmviesa001.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Apr 2024 08:37:17 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1s1pXe-00000002i84-3wjG; Tue, 30 Apr 2024 18:37:14 +0300 Date: Tue, 30 Apr 2024 18:37:14 +0300 From: Andy Shevchenko To: Petar Stoykov Cc: linux-iio@vger.kernel.org, Jonathan Cameron , Krzysztof Kozlowski , Lars-Peter Clausen , Rob Herring , Angel Iglesias , Conor Dooley , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v2 0/3] Add support for Sensirion SDP500 Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Tue, Apr 30, 2024 at 05:27:17PM +0200, Petar Stoykov wrote: > From c4437fd0ea296c4c964b1fb924144ae24a2ce443 Mon Sep 17 00:00:00 2001 > From: Petar Stoykov > Date: Mon, 29 Apr 2024 16:41:30 +0200 > Subject: [PATCH 0/3] Add support for Sensirion SDP500 > > This patch series It's not. I mean from the email chaining perspective. Have you forgotten to add --thread to git format-patch? Also, what is that in above? > introduces support for Sensirion SDP500 in the IIO > subsystem. The series is split into three patches: > > 1. The first patch adds the device tree bindings. > 2. The second patch implements the device driver. > 3. The third patch updates the MAINTAINERS file. > > The driver is relatively simple. It provides a way to read the measured > differential pressure directly in Pa, as the device has a fixed scale > factor of 1/60. When an applications wants to read the pressure value, > 3 bytes are read from the device, 2 are data and 1 is CRC8. If the crc > check passes, the calculated pressure value is returned in Pa units. > > The initialization of the device just starts the measurement process. > > We have been using this device and driver in a product development for > almost a year now. There the pressure is read every 25ms and is used in a > control loop. We have not even seen crc errors. We are using the > "linux-imx" repository and not the mainline one but I see no risky kernel > functions in use so it should be fine here too. > > All feedback is appreciated! Thank you for taking the time to review this. -- With Best Regards, Andy Shevchenko