Received-SPF: pass (google.com: domain of linux-kernel+bounces-164709-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Precedence: bulk
MIME-Version: 1.0
References: <20240430162946.589423-1-alisa.roman@analog.com> <20240430162946.589423-7-alisa.roman@analog.com>
In-Reply-To: <20240430162946.589423-7-alisa.roman@analog.com>
From: Andy Shevchenko <andy.shevchenko@gmail.com>
Date: Tue, 30 Apr 2024 23:33:15 +0300
Message-ID: <CAHp75VcHa31nXwFwSJCnRvPTZ8K-5KBrM0jxAnyHh8jzPHE48Q@mail.gmail.com>
Subject: Re: [PATCH v7 6/6] iio: adc: ad7192: Add AD7194 support
To: Alisa-Dariana Roman <alisadariana@gmail.com>
Cc: michael.hennerich@analog.com, linux-iio@vger.kernel.org, 
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, 
	alexandru.tachici@analog.com, lars@metafoo.de, jic23@kernel.org, 
	robh@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, 
	lgirdwood@gmail.com, broonie@kernel.org, andy@kernel.org, nuno.sa@analog.com, 
	marcelo.schmitt@analog.com, bigunclemax@gmail.com, dlechner@baylibre.com, 
	okan.sahin@analog.com, fr0st61te@gmail.com, alisa.roman@analog.com, 
	marcus.folkesson@gmail.com, schnelle@linux.ibm.com, liambeguin@gmail.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, Apr 30, 2024 at 7:30=E2=80=AFPM Alisa-Dariana Roman
<alisadariana@gmail.com> wrote:
>
> Unlike the other AD719Xs, AD7194 has configurable channels. The user can
> dynamically configure them in the devicetree.
>
> Also modify config AD7192 description for better scaling.

..

> +static int ad7194_parse_channels(struct iio_dev *indio_dev)
> +{
> +       struct device *dev =3D indio_dev->dev.parent;
> +       struct iio_chan_spec *ad7194_channels;
> +       struct fwnode_handle *child;
> +       struct iio_chan_spec ad7194_chan =3D AD7193_CHANNEL(0, 0, 0);
> +       struct iio_chan_spec ad7194_chan_diff =3D AD7193_DIFF_CHANNEL(0, =
0, 0, 0);
> +       struct iio_chan_spec ad7194_chan_temp =3D AD719x_TEMP_CHANNEL(0, =
0);
> +       struct iio_chan_spec ad7194_chan_timestamp =3D IIO_CHAN_SOFT_TIME=
STAMP(0);
> +       unsigned int num_channels, index =3D 0;
> +       u32 ain[2];
> +       int ret;
> +
> +       num_channels =3D device_get_child_node_count(dev);
> +       if (num_channels > AD7194_CH_MAX_NR)
> +               return dev_err_probe(dev, -EINVAL,
> +                                    "Too many channels: %u\n", num_chann=
els);
> +
> +       num_channels +=3D AD7194_CH_BASE_NR;
> +
> +       ad7194_channels =3D devm_kcalloc(dev, num_channels,
> +                                      sizeof(*ad7194_channels), GFP_KERN=
EL);
> +       if (!ad7194_channels)
> +               return -ENOMEM;
> +
> +       indio_dev->channels =3D ad7194_channels;
> +       indio_dev->num_channels =3D num_channels;
> +
> +       device_for_each_child_node(dev, child) {

You wanted _scoped version...

> +               ret =3D fwnode_property_read_u32_array(child, "diff-chann=
els",
> +                                                    ain, ARRAY_SIZE(ain)=
);
> +               if (ret =3D=3D 0) {
> +                       ret =3D ad7194_validate_ain_channel(dev, ain[0]);
> +                       if (ret)

..otherwise here is the reference count leakage.

> +                               return ret;
> +
> +                       ret =3D ad7194_validate_ain_channel(dev, ain[1]);
> +                       if (ret)

Or here.

> +                               return ret;
> +
> +                       *ad7194_channels =3D ad7194_chan_diff;
> +                       ad7194_channels->scan_index =3D index++;
> +                       ad7194_channels->channel =3D ain[0];
> +                       ad7194_channels->channel2 =3D ain[1];
> +                       ad7194_channels->address =3D AD7194_CH(ain[0], ai=
n[1]);
> +               } else {
> +                       ret =3D fwnode_property_read_u32(child, "single-c=
hannel",
> +                                                      &ain[0]);
> +                       if (ret) {
> +                               fwnode_handle_put(child);
> +                               return ret;
> +                       }
> +
> +                       ret =3D ad7194_validate_ain_channel(dev, ain[0]);
> +                       if (ret)

Or here.

> +                               return ret;
> +
> +                       *ad7194_channels =3D ad7194_chan;
> +                       ad7194_channels->scan_index =3D index++;
> +                       ad7194_channels->channel =3D ain[0];
> +                       ad7194_channels->address =3D AD7194_CH(ain[0], 0)=
;
> +               }
> +               ad7194_channels++;
> +       }
> +
> +       *ad7194_channels =3D ad7194_chan_temp;
> +       ad7194_channels->scan_index =3D index++;
> +       ad7194_channels->address =3D AD7194_CH_TEMP;
> +       ad7194_channels++;
> +
> +       *ad7194_channels =3D ad7194_chan_timestamp;
> +       ad7194_channels->scan_index =3D index;
> +
> +       return 0;
> +}

--=20
With Best Regards,
Andy Shevchenko