Received-SPF: pass (google.com: domain of linux-kernel+bounces-164721-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <43cbaf90-7af3-4742-97b7-2ea587b16174@intel.com>
Date: Tue, 30 Apr 2024 13:47:07 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v19 101/130] KVM: TDX: handle ept violation/misconfig exit
To: Isaku Yamahata <isaku.yamahata@intel.com>, Chao Gao <chao.gao@intel.com>
CC: <kvm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<isaku.yamahata@gmail.com>, Paolo Bonzini <pbonzini@redhat.com>,
	<erdemaktas@google.com>, Sean Christopherson <seanjc@google.com>, Sagi Shahar
	<sagis@google.com>, Kai Huang <kai.huang@intel.com>, <chen.bo@intel.com>,
	<hang.yuan@intel.com>, <tina.zhang@intel.com>,
	<isaku.yamahata@linux.intel.com>
References: <cover.1708933498.git.isaku.yamahata@intel.com>
 <f05b978021522d70a259472337e0b53658d47636.1708933498.git.isaku.yamahata@intel.com>
 <Zgoz0sizgEZhnQ98@chao-email>
 <20240403184216.GJ2444378@ls.amr.corp.intel.com>
Content-Language: en-US
From: Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20240403184216.GJ2444378@ls.amr.corp.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TTU2amJGK05zWFlYRzc5Zi9zMG15dERQTTdYTWRMa2piRGNFNWlDSHEwNlVB?=
 =?utf-8?B?bWZxUUF3TThrQXRORFV5T21Uc01wcnJXUUNJY1cyM2JEcm9Cd2hVaC9iS1Rq?=
 =?utf-8?B?dGpiMW5WTU11RmZuVkJobWxMTUZ1NDVWeE13VnlwSndhbUc0bUdseERlSlFT?=
 =?utf-8?B?bzVXcHFJam1SVXliUGJ3dkVSRHdTblkzUmVIcXQ0Rm1MRTVDM3E2VVRIelJa?=
 =?utf-8?B?b05BOUZ2cXRVcFFYcjdIQmhFNHhCVk1QUmNCUXhtRkNISnRBSUhPeVJrZ0d6?=
 =?utf-8?B?Q2NUU0VTbnZYKzlER0treGJITXc1Ui9EK1Mza3gzbVdEUkU3VlgyWW1oL3Qz?=
 =?utf-8?B?Qkc4RU0zMzBMakZaNG1lOG9INTJ6SzA3RHdnMjZ3TGZLOGdXbjFvOHlleWVa?=
 =?utf-8?B?ZEtHazJMMmJKTTloUzE0cnJOdE5WSE1uUXd5SkVJZk52azhYRndoVmxOclBF?=
 =?utf-8?B?YS9pQ0lqa3VINEphY1lBQ2RMRW1aR0lOT1N5alB0SmNTYUVBM3ROTmV5K01G?=
 =?utf-8?B?UVRXb1k1Mi80cFdyYUd3ZnIwVWIyeDZnakQzb1orVGUxeEN5a2JIeGN2Z2Nu?=
 =?utf-8?B?dllPSUs1VEwzQVhlYklJNks2L3lVTGFnNElyRVlyemdWU0c2T1NxSHBxcktm?=
 =?utf-8?B?V250b20xWGx2NlkzME1hRHhVc3NUUzNqVHhTam1PNVhmSU1pb0ZrWktGNTZ4?=
 =?utf-8?B?SmhmMldzU2pyNGM3QmZpZXN5TVNhb1lOcXJsVStZYUdvTDdudFVIWUs1b3li?=
 =?utf-8?B?Rk95K2E5NnlaV0RteDh0QVdVKzkwaU1BNmw1S0MzS2ZPbFppZU03SEtaR29K?=
 =?utf-8?B?ZjRxNEV3d3VTRGtQakU2MHVXNlI0bkhma2lNRVdkWTJ2ZEdRZXFUNG1qdzRu?=
 =?utf-8?B?QlZ4SjNManBQQnhlcVQ1RnVhUEE3TlBwTmVQSXlIV3R3VSs2NFJBNU80c3FC?=
 =?utf-8?B?N0ZIVDZFQWFkSk9KVWE2dG5Ka3hOUWJ6bnh2Ky85dmdoc2FabkZDK3pVZnRi?=
 =?utf-8?B?MFZwVVFBUzFrclQxV09ibUF0WDMrYWh3OEpQakVoV3plNXJkRWlHcmZSY2JY?=
 =?utf-8?B?WmRaNmxaU1RzN2tHOXZ0OXp4Y1g3ZDJJRktjUkwwbytPcU5zU1BFUDFhMGp4?=
 =?utf-8?B?ZXBlMkQ2am9oMnE3QllROVoxZ2FCUE95blB5dERlZHB2UUh4WHVlNmRmeW9x?=
 =?utf-8?B?czFocFFQR0s3RzRoR01BOURMbkoreG42NUUzS251MjJrT0J1d3gxME4xb0NQ?=
 =?utf-8?B?WE1Bd0E3L2UxeEY5d1hTclVNRGE0dndmeTVzMGFpZEpxUnFRNXVUTnNEWVlW?=
 =?utf-8?B?WTNTMmZtMW04dHAxeVZ4emIzb081M3FJY3RYMEU0SnFHOVJmckp6bkRsQkNM?=
 =?utf-8?B?TTdaNi9wMm1jRFpZMXpaVDdMdkdKTzZrYU5XT3BjRVFKOXlUU1RIZ3hIZHli?=
 =?utf-8?B?Tkg2WFV0UDF2N1d1SHhWVDIwMlAyQ2t1YnR0WWNIY3kyZytWWENNTHNCdjlS?=
 =?utf-8?B?R1Z6S0RGV1dnU0lwbjZkalJPRURvdjlkd2F3TWlzMWJWbUpsMnJFVm5GT2E4?=
 =?utf-8?B?a2I3TjFjRXhZcTc1WEhpNThuWlhiTmJrYXlZekR1c2QxdGc1UEhRZ21zYU9S?=
 =?utf-8?B?UkhPNVZGblBvMEV2M1RiNi9teVExbjh6VHk4QXJnTHhJdXBtc3hobm5CNVla?=
 =?utf-8?B?eW81Y0lSZWk1VTFJeGYxY0ZFL2lzaTJLbHFURkNXeGFqaGg1c3NKclY0ZVZr?=
 =?utf-8?B?OThPUFJBaVhTb0FIcThLZVFQNHpnYlo3c3NwWENNdXE4R3BPUzRqcGtxU0VL?=
 =?utf-8?B?bzJoQWsvc1ZXdlpvYzQ3U0JvZTZIYzdjcm9LcnUyY29qVkZRd3dwRFQxYlhW?=
 =?utf-8?B?ZzlybnhtWkF0b25qOVFWbDZhaTNhblByWFpOSWhBY2ZsMmd5Vk9vakg1c2Fm?=
 =?utf-8?B?dWMwUy9FRDJtOTBhNGlzWTN6UDN5dk8rZ1dZWDZIU2pjbWVxZ1JMZThjenJ0?=
 =?utf-8?B?OEU2VnZOeTF6SVRjeEpVT3Ztc1pWT28vOE1GYXI2QkFZZjRadWtxanIvQm1a?=
 =?utf-8?B?WHA1ZWtGS0JFRm5TbThzZGZQWG52ZGZTaWdkK2VDQ3VmNHJNQ1FvdUhLUm9P?=
 =?utf-8?B?cmVFVkkyZ0xZRkVJZGp4R2JwdjNFYUJIa2hjUnhFOGtiTFR5Q293N2lkZVFK?=
 =?utf-8?B?VUE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: f0ff1ac8-eb90-43ff-24b8-08dc6956b52c
X-MS-Exchange-CrossTenant-AuthSource: SN7PR11MB7566.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Apr 2024 20:47:11.0729
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Bno/BnvyuaATE4PLCg1jcj4JoHYK76yvyDgNl94faPrmUK4nYYkrMDaFY2cDhIJY6JI7riPnqs0CQr/GeUppzb5S0nhyqGhEHoSdFWhW8B8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR11MB6296
X-OriginatorOrg: intel.com

Hi Isaku,

On 4/3/2024 11:42 AM, Isaku Yamahata wrote:
> On Mon, Apr 01, 2024 at 12:10:58PM +0800,
> Chao Gao <chao.gao@intel.com> wrote:
> 
>>> +static int tdx_handle_ept_violation(struct kvm_vcpu *vcpu)
>>> +{
>>> +	unsigned long exit_qual;
>>> +
>>> +	if (kvm_is_private_gpa(vcpu->kvm, tdexit_gpa(vcpu))) {
>>> +		/*
>>> +		 * Always treat SEPT violations as write faults.  Ignore the
>>> +		 * EXIT_QUALIFICATION reported by TDX-SEAM for SEPT violations.
>>> +		 * TD private pages are always RWX in the SEPT tables,
>>> +		 * i.e. they're always mapped writable.  Just as importantly,
>>> +		 * treating SEPT violations as write faults is necessary to
>>> +		 * avoid COW allocations, which will cause TDAUGPAGE failures
>>> +		 * due to aliasing a single HPA to multiple GPAs.
>>> +		 */
>>> +#define TDX_SEPT_VIOLATION_EXIT_QUAL	EPT_VIOLATION_ACC_WRITE
>>> +		exit_qual = TDX_SEPT_VIOLATION_EXIT_QUAL;
>>> +	} else {
>>> +		exit_qual = tdexit_exit_qual(vcpu);
>>> +		if (exit_qual & EPT_VIOLATION_ACC_INSTR) {
>>
>> Unless the CPU has a bug, instruction fetch in TD from shared memory causes a
>> #PF. I think you can add a comment for this.
> 
> Yes.
> 
> 
>> Maybe KVM_BUG_ON() is more appropriate as it signifies a potential bug.
> 
> Bug of what component? CPU. If so, I think KVM_EXIT_INTERNAL_ERROR +
> KVM_INTERNAL_ERROR_UNEXPECTED_EXIT_REASON is more appropriate.
> 

Is below what you have in mind?

diff --git a/arch/x86/kvm/vmx/tdx.c b/arch/x86/kvm/vmx/tdx.c
index 499c6cd9633f..bd30b4c4d710 100644
--- a/arch/x86/kvm/vmx/tdx.c
+++ b/arch/x86/kvm/vmx/tdx.c
@@ -1305,11 +1305,18 @@ static int tdx_handle_ept_violation(struct kvm_vcpu *vcpu)
 	} else {
 		exit_qual = tdexit_exit_qual(vcpu);
 		if (exit_qual & EPT_VIOLATION_ACC_INSTR) {
+			/*
+			 * Instruction fetch in TD from shared memory
+			 * causes a #PF.
+			 */
 			pr_warn("kvm: TDX instr fetch to shared GPA = 0x%lx @ RIP = 0x%lx\n",
 				tdexit_gpa(vcpu), kvm_rip_read(vcpu));
-			vcpu->run->exit_reason = KVM_EXIT_EXCEPTION;
-			vcpu->run->ex.exception = PF_VECTOR;
-			vcpu->run->ex.error_code = exit_qual;
+			vcpu->run->exit_reason = KVM_EXIT_INTERNAL_ERROR;
+			vcpu->run->internal.suberror =
+				KVM_INTERNAL_ERROR_UNEXPECTED_EXIT_REASON;
+			vcpu->run->internal.ndata = 2;
+			vcpu->run->internal.data[0] = EXIT_REASON_EPT_VIOLATION;
+			vcpu->run->internal.data[1] = vcpu->arch.last_vmentry_cpu;
 			return 0;
 		}
 	}

Thank you

Reinette