Received-SPF: pass (google.com: domain of linux-kernel+bounces-164735-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <1ce3c1873130ff696101f781b4df239b.sboyd@kernel.org>
Content-Type: text/plain; charset="utf-8"
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20240430184656.357805-1-krzysztof.kozlowski@linaro.org>
References: <20240430184656.357805-1-krzysztof.kozlowski@linaro.org>
Subject: Re: [GIT PULL fixes PATCH] clk: samsung: Revert "clk: Use device_get_match_data()"
From: Stephen Boyd <sboyd@kernel.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>, Sylwester Nawrocki <s.nawrocki@samsung.com>, Chanwoo Choi <cw00.choi@samsung.com>, Alim Akhtar <alim.akhtar@samsung.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>, Michael Turquette <mturquette@baylibre.com>, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org
Date: Tue, 30 Apr 2024 14:24:47 -0700
User-Agent: alot/0.10

Quoting Krzysztof Kozlowski (2024-04-30 11:46:56)
> From: Marek Szyprowski <m.szyprowski@samsung.com>
>=20
> device_get_match_data() function should not be used on the device other
> than the one matched to the given driver, because it always returns the
> match_data of the matched driver. In case of exynos-clkout driver, the
> original code matches the OF IDs on the PARENT device, so replacing it
> with of_device_get_match_data() broke the driver.
>=20
> This has been already pointed once in commit 2bc5febd05ab ("clk: samsung:
> Revert "clk: samsung: exynos-clkout: Use of_device_get_match_data()"").
> To avoid further confusion, add a comment about this special case, which
> requires direct of_match_device() call to pass custom IDs array.
>=20
> This partially reverts commit 409c39ec92a35e3708f5b5798c78eae78512cd71.
>=20
> Cc: <stable@vger.kernel.org>
> Fixes: 409c39ec92a3 ("clk: Use device_get_match_data()")
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> Link: https://lore.kernel.org/r/20240425075628.838497-1-m.szyprowski@sams=
ung.com
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---

Applied to clk-fixes