Received-SPF: pass (google.com: domain of linux-kernel+bounces-164743-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <9f4323025c9d25313ecf26327848fc62.sboyd@kernel.org>
Content-Type: text/plain; charset="utf-8"
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <128dc42a50bfe166993205108a5b23cd.sboyd@kernel.org>
References: <20240422232404.213174-1-sboyd@kernel.org> <20240422232404.213174-6-sboyd@kernel.org> <128dc42a50bfe166993205108a5b23cd.sboyd@kernel.org>
Subject: Re: [PATCH v4 05/10] platform: Add test managed platform_device/driver APIs
From: Stephen Boyd <sboyd@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, patches@lists.linux.dev, kunit-dev@googlegroups.com, linux-kselftest@vger.kernel.org, devicetree@vger.kernel.org, Brendan Higgins <brendan.higgins@linux.dev>, David Gow <davidgow@google.com>, Rae Moar <rmoar@google.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Rafael J . Wysocki <rafael@kernel.org>, Rob Herring <robh@kernel.org>, Saravana Kannan <saravanak@google.com>, Daniel Latypov <dlatypov@google.com>, Christian Marangi <ansuelsmth@gmail.com>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, Maxime Ripard <maxime@cerno.tech>
To: Michael Turquette <mturquette@baylibre.com>, Stephen Boyd <sboyd@kernel.org>
Date: Tue, 30 Apr 2024 14:32:06 -0700
User-Agent: alot/0.10

Quoting Stephen Boyd (2024-04-24 11:11:21)
> Quoting Stephen Boyd (2024-04-22 16:23:58)
> > diff --git a/drivers/base/test/platform_kunit.c b/drivers/base/test/pla=
tform_kunit.c
[...]
> > +
> > +       /*
> > +        * Wait for the driver to probe (or at least flush out of the d=
eferred
> > +        * workqueue)
> > +        */
> > +       wait_for_device_probe();
>=20
> Should this be removed? I was thinking that this isn't a pure wrapper
> around platform_driver_register() because it has this wait call.  Maybe
> it's better to have some other kunit API that can wait for a specific
> device to probe and timeout if it doesn't happen in that amount of time.
> That API would use the bus notifiers and look for
> BUS_NOTIFY_BOUND_DRIVER. Or maybe that function could setup a completion
> that the test can wait on.

I have an implementation that does this that I'll send.