Received-SPF: pass (google.com: domain of linux-kernel+bounces-164772-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Precedence: bulk
MIME-Version: 1.0
References: <ZjAWMQCJdrxZkvkB@google.com> <CAKf6xpvzrCHAsbokGu_+7P0H=n4T=dsRN81msJjW6yVMcEZi6g@mail.gmail.com>
In-Reply-To: <CAKf6xpvzrCHAsbokGu_+7P0H=n4T=dsRN81msJjW6yVMcEZi6g@mail.gmail.com>
From: Jason Andryuk <jandryuk@gmail.com>
Date: Tue, 30 Apr 2024 18:25:13 -0400
Message-ID: <CAKf6xpsiLbZN=v2G052kuwPLNxmmbt4uoZAM21Zr+RtH0YD8kA@mail.gmail.com>
Subject: Re: [PATCH v2] Input: try trimming too long modalias strings
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org, Hans de Goede <hdegoede@redhat.com>, 
	Benjamin Tissoires <benjamin.tissoires@redhat.com>, Peter Hutterer <peter.hutterer@who-t.net>, 
	linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, Apr 29, 2024 at 9:04=E2=80=AFPM Jason Andryuk <jandryuk@gmail.com> =
wrote:
>
> On Mon, Apr 29, 2024 at 5:50=E2=80=AFPM Dmitry Torokhov
> <dmitry.torokhov@gmail.com> wrote:
> >
> > If an input device declares too many capability bits then modalias
> > string for such device may become too long and not fit into uevent
> > buffer, resulting in failure of sending said uevent. This, in turn,
> > may prevent userspace from recognizing existence of such devices.
> >
> > This is typically not a concern for real hardware devices as they have
> > limited number of keys, but happen with synthetic devices such as
> > ones created by xen-kbdfront driver, which creates devices as being
> > capable of delivering all possible keys, since it doesn't know what
> > keys the backend may produce.
> >
> > To deal with such devices input core will attempt to trim key data,
> > in the hope that the rest of modalias string will fit in the given
> > buffer. When trimming key data it will indicate that it is not
> > complete by placing "+," sign, resulting in conversions like this:
> >
> > old: k71,72,73,74,78,7A,7B,7C,7D,8E,9E,A4,AD,E0,E1,E4,F8,174,
> > new: k71,72,73,74,78,7A,7B,7C,+,
> >
> > This should allow existing udev rules continue to work with existing
> > devices, and will also allow writing more complex rules that would
> > recognize trimmed modalias and check input device characteristics by
> > other means (for example by parsing KEY=3D data in uevent or parsing
> > input device sysfs attributes).
> >
> > Note that the driver core may try adding more uevent environment
> > variables once input core is done adding its own, so when forming
> > modalias we can not use the entire available buffer, so we reduce
> > it by somewhat an arbitrary amount (96 bytes).
> >
> > Reported-by: Jason Andryuk <jandryuk@gmail.com>
> > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
>
> Tested-by: Jason Andryuk <jandryuk@gmail.com>
>
> I don't have the gdm setup available to test, but loginctl looks good
> showing the Xen Virtual Keyboard assigned to a seat:
> # loginctl seat-status seat0
> seat0
>          Devices:
>                   =E2=94=9C=E2=94=80/sys/devices/LNXSYSTM:00/LNXPWRBN:00/=
input/input0
>                   =E2=94=82 input:input0 "Power Button"
>                   =E2=94=9C=E2=94=80/sys/devices/LNXSYSTM:00/LNXSLPBN:00/=
input/input1
>                   =E2=94=82 input:input1 "Sleep Button"
>                   =E2=94=9C=E2=94=80/sys/devices/platform/i8042/serio0/in=
put/input2
>                   =E2=94=82 input:input2 "AT Translated Set 2 keyboard"
>                   =E2=94=9C=E2=94=80/sys/devices/platform/i8042/serio1/in=
put/input4
>                   =E2=94=82 input:input4 "ImExPS/2 Generic Explorer Mouse=
"
>                   =E2=94=9C=E2=94=80/sys/devices/virtual/input/input5
>                   =E2=94=82 input:input5 "Xen Virtual Keyboard"
>                   =E2=94=82 =E2=94=94=E2=94=80/sys/devices/virtual/input/=
input5/event4
>                   =E2=94=82   input:event4
>                   =E2=94=94=E2=94=80/sys/devices/virtual/input/input6
>                     input:input6 "Xen Virtual Pointer"

What do you think about Cc: stable@vger.kernel.org?  I'd like to get
the Xen Keyboard working as widely as possible, so I'd like it
backported if possible.

Thanks,
Jason