Received-SPF: pass (google.com: domain of linux-kernel+bounces-164825-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Tue, 30 Apr 2024 17:06:15 -0700
From: Ashok Raj <ashok.raj@intel.com>
To: "Chang S. Bae" <chang.seok.bae@intel.com>
CC: <linux-kernel@vger.kernel.org>, <x86@kernel.org>,
	<platform-driver-x86@vger.kernel.org>, <tglx@linutronix.de>,
	<mingo@redhat.com>, <bp@alien8.de>, <dave.hansen@linux.intel.com>,
	<hdegoede@redhat.com>, <ilpo.jarvinen@linux.intel.com>,
	<tony.luck@intel.com>, <jithu.joseph@intel.com>, Ashok Raj
	<ashok.raj@intel.com>
Subject: Re: [PATCH 2/2] platform/x86/intel/ifs: Initialize AMX state for the
 scan test
Message-ID: <ZjGHdwDXxhhqXANq@a4bf019067fa.jf.intel.com>
References: <20240430212508.105117-1-chang.seok.bae@intel.com>
 <20240430212508.105117-3-chang.seok.bae@intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20240430212508.105117-3-chang.seok.bae@intel.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?okWEOboQnmOt5A/Nn6GGGV0AMw5+7uQMCupQczhYAqiufvbeYuVU8J8QosHD?=
 =?us-ascii?Q?WVcGWzkhNggM7gy0d9ztZdaKUYgmi5n6itedpTVSaF9uZRhGzC6qGmT5uoKD?=
 =?us-ascii?Q?g+ZhM/rM2IBMljdrOS28HlnZutS739oInj2Upe2JaDFSz3RkWT4GpUQuPVql?=
 =?us-ascii?Q?uB1iQI/2OQeJM7LkkX+FPbmgnhr4azh9/3cXO3I6cmWpL4AEYEho3Soz7EcK?=
 =?us-ascii?Q?/+ngTRStlLCIU+uyTbkZUQ3laAURL9ueLxGPGKbFwHUJOpaWz0MXcv5Y65E3?=
 =?us-ascii?Q?4UAyPbUb2KjC2PEajtK3WMv9QlHuyqcCyns7DfLBc7Hb86JBQaZoGdmRRjns?=
 =?us-ascii?Q?W/1m9b++abI3g/fl/WfjLr+zO3ZQkjAbLCrIMUDNwZ3gOiE/DNjC3oaHlPZn?=
 =?us-ascii?Q?pkACKnskQFfHfklmCWnQZ6vQ+Xn/yuy6RSGdEOCXfoLdlQlV73YrqrQwepMp?=
 =?us-ascii?Q?lPpPP+M+VuxpD5wWu1SNQOPc1bEWofLkS8KjUpGIcIRg/9IY99ZNaIoa8oxX?=
 =?us-ascii?Q?lEFF21qyqFPUAhufCIYqWHKQXcftG2GR6xKNcY2536Dc6SM0LZbO1VuvPex1?=
 =?us-ascii?Q?odH95o9TVbD48/bXTIsr1RViDfxjyiruEfvyK4wgskbeC2MZ3uxU0vIOssx5?=
 =?us-ascii?Q?/MJ/3VliA1iHBONQytNSN/K4u2Ybhr6GCiM8CG3PnlfurmgE0KEvXcMnQd0X?=
 =?us-ascii?Q?BXkut/Lqo8Ota8ahTrxn7z85O3W/zGAAueOkqfsQf1cNmlnCJon2P0nNKIjg?=
 =?us-ascii?Q?OE8XeCPuZEMPCHjs7bSnY3s0O+qrcxTTVg2zjL9AXuaJbhT7MHDkZFoq9JqB?=
 =?us-ascii?Q?/kNA4ug5xt/RGi4DUfhczhXz3sOLs3hZ/xE1SsFb9l0Tcyr/4TLp8HvPmck+?=
 =?us-ascii?Q?oXL1+eV4i9vyudvLa8+d1XemMR+KjyJmKSM8lkGuYcEQm6BaVD+ehphiRz1n?=
 =?us-ascii?Q?oQsgS1RJlJIjTILD6Sb48fCz0XbqV4I46tjixi3WRSHajRyX41tl4l4yxcPc?=
 =?us-ascii?Q?DCNjvAcNq/rdO5/YsAv2TSTDkJYukKcYeL/LgtXJTkrKutSXNXrpWsNBORPr?=
 =?us-ascii?Q?zjjx8y1EOCInfg+4fNyXMVzSzPKeKx+ofVwtuUDNRaY7knF6ChosdO0O68vj?=
 =?us-ascii?Q?g6847hD4dTno4/h84a+1Bh5qQwK4+yg34cgZ54GPLF67VWGF5X+yVATrwDcx?=
 =?us-ascii?Q?a9R4TUZsEVcJGc23pFdDIfqW9MH16DjH3bA30kDjQc9J6ID8h7rJStTI5dsL?=
 =?us-ascii?Q?RLGU2G9h4qGOp5zqVXBbqv0ZUqdeK6phQf40aeyEOsNDpeRcHoJwJv5kkDG/?=
 =?us-ascii?Q?/rVJBv2xyzF8C7KRqWwblrJdlvHdqjCn4f3mH09UaSGqVmADqKs6e6BEvCl9?=
 =?us-ascii?Q?SBDwkOhIFP1BR6rvp9Ec+GGgs3ahXhEsAdgvN64Sj2Zlj3oMme5hMHx/2Nyu?=
 =?us-ascii?Q?5NB3d9vGPRSl75J4oRkZxfle7bOkqAI3Xy5YnjWM6n34XqzZhE/M3rCumDab?=
 =?us-ascii?Q?1gOtl27xWxmNFoVk1CkYrS9U3DSfaCI3Gq7Wyo1FgXJVO7XIgBJoeAu0xj1A?=
 =?us-ascii?Q?xl64ocyWMUYVQWuHlYCeyLMnbiW6jDrJuBIOCnhl?=
X-MS-Exchange-CrossTenant-Network-Message-Id: c7fa8c8d-bd3d-4df5-e96d-08dc69728840
X-MS-Exchange-CrossTenant-AuthSource: SJ1PR11MB6201.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 May 2024 00:06:21.4770
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: k0TsIA0XlDgXOGKT2ij6aivF4vgQj/BcHBj4tXPra0cd2XxAIy5DPMOTy+tnu8wbP3+hC0kCjnP+AH1zUoJ/7w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5199
X-OriginatorOrg: intel.com

On Tue, Apr 30, 2024 at 02:25:08PM -0700, Bae, Chang Seok wrote:
> The scan test does not start when the AMX state remains active and is not
> re-initialized. With the extension of kernel_fpu_begin_mask(), the driver
> code can now initialize the state properly.

Avoid "re-initialized" and maybe use the same SDM language here as well?

	Infield Scan aborts if AMX state is not in initialized state. Use
	the kernel_fpu_begin_mask(KFPU_AMX) to ensure AMX state is initialized.

> 
> Introduce custom FPU handling wrappers to ensure compliant with the
> established FPU API semantics, as kernel_fpu_begin() exclusively sets
> legacy states. This follows the EFI case from commit b0dc553cfc9d
> ("x86/fpu: Make the EFI FPU calling convention explicit").

The EFI and commit mention is worthy of prior use, but the first line
isn't reading well... Maybe

	Introduce custom FPU handling wrappers to ensure compliance with the 
	established FPU API semantics.  This change follows the EFI case from 
	commit b0dc553cfc9d ("x86/fpu: Make the EFI FPU calling convention explicit").

I dropped the note about legacy states, I didn't quite know how to word
that.

> 
> Then, use these wrappers to surround the MSR_ACTIVATE_SCAN write to
> minimize the critical section. To prevent unnecessary delays, invoke
> ifs_fpu_begin() before entering the rendezvous loop.
> 
> Signed-off-by: Chang S. Bae <chang.seok.bae@intel.com>
> Reviewed-by: Jithu Joseph <jithu.joseph@intel.com>
> Tested-by: Jithu Joseph <jithu.joseph@intel.com>