Received-SPF: pass (google.com: domain of linux-kernel+bounces-164853-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Precedence: bulk
MIME-Version: 1.0
References: <20240410170825.1132324-1-ben.levinsky@amd.com>
 <24bd320a-ba89-4ad0-a905-6915e00b705d@amd.com> <1ce0b581-4613-4899-ada1-5d322f006890@amd.com>
In-Reply-To: <1ce0b581-4613-4899-ada1-5d322f006890@amd.com>
From: Jassi Brar <jassisinghbrar@gmail.com>
Date: Tue, 30 Apr 2024 20:39:00 -0500
Message-ID: <CABb+yY0vTioFvQJcfxvLkODVMfQfKxnQnLYMJ8MXBwKO357AqA@mail.gmail.com>
Subject: Re: Fwd: [PATCH v3 0/3] mailbox: zynqmp: Enable Bufferless IPIs for
 Versal based SOCs
To: Ben Levinsky <ben.levinsky@amd.com>
Cc: Tanmay Shah <tanmay.shah@amd.com>, Michal Simek <michal.simek@amd.com>, 
	shubhrajyoti.datta@amd.com, linux-kernel@vger.kernel.org, 
	linux-arm-kernel@lists.infradead.org, gregkh@linuxfoundation.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, Apr 25, 2024 at 9:40=E2=80=AFAM Ben Levinsky <ben.levinsky@amd.com>=
 wrote:
>
> Ping For Review

It's a beautiful patchset :)

-jassi


> > -------- Forwarded Message --------
> > Subject: [PATCH v3 0/3] mailbox: zynqmp: Enable Bufferless IPIs for Ver=
sal based SOCs
> > Date: Wed, 10 Apr 2024 10:08:22 -0700
> > From: Ben Levinsky <ben.levinsky@amd.com>
> > To: jassisinghbrar@gmail.com, michal.simek@amd.com, shubhrajyoti.datta@=
amd.com, tanmay.shah@amd.com, linux-kernel@vger.kernel.org, linux-arm-kerne=
l@lists.infradead.org
> >
> > For Xilinx-AMD Versal and Versal NET SOC's there exist also
> > inter-processor-interrupts (IPIs) without IPI Message Buffers. For thes=
e
> > enable use of IPI Mailbox driver for send/receive as well.
> >
> > This is enabled with new compatible string: "xlnx,versal-ipi-mailbox"
> >
> > Original, buffered usage for ZynqMP based SOC is still supported.
> >
> > Note that Versal bindings are already present in xlnx,zynqmp-ipi-mailbo=
x.yaml
> >
> > v2:
> > - formatting in 2/3 patch
> > - remove extra handling in 3/3 versal_ipi_setup()
> > v3:
> > 1/3 - removed additional newline to avoid
> > ./scripts/checkpatch.pl --strict -f drivers/mailbox/zynqmp-ipi-mailbox.=
c
> > CHECK: Please don't use multiple blank lines
> > #434: FILE: drivers/mailbox/zynqmp-ipi-mailbox.c:434:
> > +
> > +
> > 2/3 - remove unused variable dev
> > drivers/mailbox/zynqmp-ipi-mailbox.c:565:24: warning: variable 'dev' se=
t but not
> > used [-Wunused-but-set-variable]
> >          struct device *mdev, *dev;
> > 3/3 - remove unused variable dev
> >                                ^
> > drivers/mailbox/zynqmp-ipi-mailbox.c:666:24: warning: variable 'dev' se=
t but not
> > used [-Wunused-but-set-variable]
> >          struct device *mdev, *dev;
> >                                ^
> >
> > Ben Levinsky (3):
> >   mailbox: zynqmp: Move of_match structure closer to usage
> >   mailbox: zynqmp: Move buffered IPI setup to of_match selected routine
> >   mailbox: zynqmp: Enable Bufferless IPI usage on Versal-based SOC's
> >
> >  drivers/mailbox/zynqmp-ipi-mailbox.c | 257 ++++++++++++++++++++++-----
> >  1 file changed, 212 insertions(+), 45 deletions(-)
> >