Received: by 2002:ab2:60d1:0:b0:1f7:5705:b850 with SMTP id i17csp207278lqm; Tue, 30 Apr 2024 19:03:34 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWr1/5YsuOzHhwHyq1hSXeev0519uFoSvukkIy4CmRcn/+FfGquF2taHuSC65zOGo/UmWRgz9VzfmqgGud1Qt7DGoqfZOYP+/udsyervw== X-Google-Smtp-Source: AGHT+IGIwV8pqbVhFuYpFcAZv6r3HdWvyUrBN/jI1LhzgFqo4avWtoanUqpZwb2jnVhig0AgO1H/ X-Received: by 2002:a05:6358:2911:b0:18d:8ef1:e77c with SMTP id y17-20020a056358291100b0018d8ef1e77cmr1343235rwb.15.1714529014002; Tue, 30 Apr 2024 19:03:34 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1714529013; cv=pass; d=google.com; s=arc-20160816; b=tH3dvXAhGqZ9zfMRaMnUNXEZv2A8yeL7y2x0V7VI+18W4DiqTy7lVFOMgqm30h5IzD uaZRLARNh9ArNsqYHnqpv0HmslOWOeuQHfNw2AXgzHRLXrxheyDex0QTBVJtfUZ8IzcR pLB0S0SrQIBZAzOMGbERvvyBkycqMI2NP7l/fp2xpeESKjL+QsGZZPkld8PcsATeBIAh axPvHjThfC7RUpKWSOWBd3Oef6d1IGSmieP8kkekynD1/snKQjZSnEgJZCDs8oG3IZci GuuuV+XmIYw/RjloPIP2zQdnA5FB19BjFbBWVcUU4Nt+ddZof2KDOzMuIDDUc7STQhCw reYg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=bR49xaQqf2EtWuxmvAHo/WUoAKQ7jYEcPM6xu1xi7BI=; fh=OkFNywlVXDtZvkpKXHpPKfb5GWwX5WOjUCNgEULD9Gc=; b=IMMaTJPJzynF+CKpyPE4IfnIPWdtxIZ+Ux+tO0kwCStL6Oua5JIcpkSKCNF3pw5LWY j4X61xcq/JG8DTVISEuRbW5sHApzuw3wtGWNOcOnSNF1QiudQp/kX5VQlPSgHBBBELfB oxdDoXHsykQY25J91IX9nBedU8GShtYSV25P87uWpR/pCgQe99HROrDnytCR3skQCY8P uYxKWIql2od457qPqhp9yNacAx2JGRLnM84elejsUi/CA/YSbtztPHijlQhetGqZ1C1q UdDyfoC149MdFERKEeqqx9WssTUTbvTd8TpXPjfAbvVQewgGyBgRrKh5jjJM9vr7VzrC udpA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=FJg1SnMW; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-164864-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-164864-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id h38-20020a632126000000b005d6b61e24afsi22155374pgh.763.2024.04.30.19.03.33 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Apr 2024 19:03:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-164864-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=FJg1SnMW; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-164864-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-164864-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 1E4B7B21F28 for ; Wed, 1 May 2024 02:03:32 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id BD43D8C1A; Wed, 1 May 2024 02:03:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="FJg1SnMW" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E4B2463C7; Wed, 1 May 2024 02:03:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714529001; cv=none; b=PgtGd5MbuebZpNJ2kcA8yRa6oFG+NdiodmSKuXTF1uwKeSp47DuPlkhcJGTJAZiQM3LPNgwAXHx7+fD6Bwgxmk+jAc/2O2SrN4q6Ook6WSGPf/hecnWEq8eBBarBq4ydKBiRLFZM+LK7Tun9+ggojC4YjwosCTU0u9W3QH0EKpQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714529001; c=relaxed/simple; bh=ZcMpz/Wv8CT3mvGrg/z6E1WF+I8cLy7mpj6GPX9bvDE=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=EfXoaxcinSrPWdkAFd2moe4z+D5H82Ex2BcwXYxMCsA+MKklGGLC5pzZ7VXHAP43QiEalGCKcrx7dBKG9mfRReJHAxaFFNp0ST3fdzpn7zE18zzSZb7pNYNP7DpjJDgLfszr4796SlznxG9eeXgoQPsb+FbhkoUz5z0XgrnGVKk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=FJg1SnMW; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 13F9DC2BBFC; Wed, 1 May 2024 02:03:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1714529000; bh=ZcMpz/Wv8CT3mvGrg/z6E1WF+I8cLy7mpj6GPX9bvDE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=FJg1SnMWFvXGH83pF5VqXLSHYYTM1REsS8WC6rtBJYbYf5DJG0gcpUQCehrFQdSPp SK2q96NbHsaWv8mHbTby0SM4E018eltJ2zEUHQDHbytYFU22fY89UE6nTbXHRlec01 Gw+xeXftaIhvn31fjr4eADCEyUzj08azlCn842F4l6eIuSBVhMYt+d4Tvc5/WTTrS+ wHf8AVlmONb/M6FWNJT29ctz76j33UUmEicKtMoLqozu21PkUdHseI+GFTVGaaPnxU Hf1FqakBFeiQbsIGroylFly57dgWXZxmqW5lqckLSHauQ++181ajspKfHA0sFdcydG u3xGE73+f9x3A== Date: Tue, 30 Apr 2024 19:03:19 -0700 From: Jakub Kicinski To: Sabrina Dubroca Cc: Breno Leitao , "David S. Miller" , Eric Dumazet , Paolo Abeni , leit@meta.com, "open list:NETWORKING DRIVERS" , open list Subject: Re: [PATCH net-next] net: loopback: Do not allocate tstats explicitly Message-ID: <20240430190319.13296ace@kernel.org> In-Reply-To: References: <20240429085559.2841918-1-leitao@debian.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 29 Apr 2024 15:47:05 +0200 Sabrina Dubroca wrote: > (nit on the subject: you mention "tstats", but the code actually uses > lstats. I guess that's not worth a v2) Good catch, corrected when applying - 3b5933e99c32 ("net: loopback: Do not allocate lstats explicitly") in net-next. -- pw-bot: accept