Received-SPF: pass (google.com: domain of linux-kernel+bounces-164873-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Wed, 1 May 2024 11:19:05 +0900
From: Mark Brown <broonie@kernel.org>
To: Alina Yu <alina_yu@richtek.com>
Cc: lgirdwood@gmail.com, linux-kernel@vger.kernel.org,
	johnny_lai@richtek.com, cy_huang@richtek.com
Subject: Re: [PATCH v2 2/4] regulator: rtq2208: Fix LDO to be compatible with
 both fixed and adjustable vout
Message-ID: <ZjGmmYWHu-ZQQdIh@finisterre.sirena.org.uk>
References: <cover.1714467553.git.alina_yu@richtek.com>
 <ffeecd61c194df1f7f049bd50cb2bbbad3cf1025.1714467553.git.alina_yu@richtek.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="yl7/Eyy5kVACNkCg"
Content-Disposition: inline
In-Reply-To: <ffeecd61c194df1f7f049bd50cb2bbbad3cf1025.1714467553.git.alina_yu@richtek.com>


--yl7/Eyy5kVACNkCg
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Apr 30, 2024 at 05:58:25PM +0800, Alina Yu wrote:

> In this patch, LDO's adjustable and fixed Vout settings are compatible.
> The LDO Vout ability depends on the init_data->constraints.
> If adjustable, the Vout can be set to either 1800mV or 3300mV.

> +		if (init_data->constraints.min_uV == init_data->constraints.max_uV) {
> +			desc->n_voltages = 1;
> +			desc->fixed_uV = init_data->constraints.min_uV;
> +			desc->ops = &rtq2208_regulator_ldo_fix_ops;
> +		} else {
> +			desc->n_voltages = ARRAY_SIZE(rtq2208_ldo_volt_table);
> +			desc->volt_table = rtq2208_ldo_volt_table;
> +			desc->ops = &rtq2208_regulator_ldo_adj_ops;
> +		}

Why are you making this change?  The operations supported by the
regulator don't change depending on if the system is going to chnage the
voltage.

--yl7/Eyy5kVACNkCg
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmYxppYACgkQJNaLcl1U
h9ApSgf+LgoXJNxcFSw3tb07ue63Ba7DUWaYbOaUrYuzQic4YN68AXn7b79upQWH
LmAuIwHrohpDbvgPh2xNoC+sQhs6EHa6Pb9TlXelRg2Um4mMVGdrOWV34+wTgtm8
NdTOMLI1Y6uhYQZaxtZ5PN4TU/hjbqdUYfObsU4k6kjTbrmhlNXhH2BsM0gmQhg3
UiaWeMd7puJxf1SLu7vVWtOwFR/aGk4Yiy3hcJc0InTeHISdT3N5A3U/56UT/L65
0JDauDxcX1dPLnYcMLQx1mN44cAz0GgLbpzrGVnCW+9Pdc4lrcBAuJ32k6GzuSYv
VJ1NIXVocd4Sg2zZi/r8BemcjzmnhQ==
=F+eV
-----END PGP SIGNATURE-----

--yl7/Eyy5kVACNkCg--