Received: by 2002:ab2:60d1:0:b0:1f7:5705:b850 with SMTP id i17csp222684lqm; Tue, 30 Apr 2024 20:00:02 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWLyON+7K0Iey2V01S4dj/Z83RTq3VoqVw3ls8IrK9ec1Hbq4KxfGZYqtw8VhyjwIIJz2l5/DpVvCqKE+rgAUz/DfsLaU3QBdPV+s4jQg== X-Google-Smtp-Source: AGHT+IGTh/CFm/SagDPH03LcF3GFcgJDfJHbKtKORDL84NooSsGGhfUY1hjM0GAwLQmcJxxnSR2t X-Received: by 2002:ac8:5884:0:b0:437:9fdb:97d4 with SMTP id t4-20020ac85884000000b004379fdb97d4mr1196451qta.33.1714532402067; Tue, 30 Apr 2024 20:00:02 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1714532402; cv=pass; d=google.com; s=arc-20160816; b=Lue4FHFzjhDFIsvXMsOs+zZMo0gHzgbFA0o8bIRSNtPOQ9f7dB6mtPy7WR+3fqhl57 kCAuXY5LQsAjcxP1tRSJ1viroOpRakot75tSNPJQos9+MaDzTqjZncUmYsRH1bTpkAn7 9ifNrH7U70PGXRC2O1pi6AmxPdtdhcW6ag1L/Z5dT8RpRP/E2jKFP8MR2P6CJzpRUCCP muuRctV38XlnLePv2IXxeaPaQtA0U4MqrRC8hFQ9/8y0wCKG6aF0qfHqA0/nQGGoDgOv NBPSx8k1eGZXMhCCFkt9Va047JzYLvXC6XqYjkdm0qHySBFQ0gT7T1sqMyGD4NembTzQ +wTg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:date :subject:cc:to:from:message-id:dkim-signature; bh=d1tAv7N4r9JF1f3d8ExotiV9kCZfuFGqR1t9KPkg68o=; fh=AovN9xYJvAzmyWFnz7cW6avI/uCZi/IGlMhCFIRaIHM=; b=W1fhibnsTJuCcpLl+4Rs5twHqDSXAB+PN7C6V1MxMZOFzzv1NuMfH4QVuSGQGPmomV nfJULEW3/JOI9AXTFQOw0aRMUt7fZJTcrW7RLbsv8vox2IwkGQKnUzJcLgxpfyz169AC V28wYI9XI7VKuXPLPQqqywj0ixR6+rZ33ftF0dj0EE0/afgFZO1cdxub5VJlVHdrqS8+ YzT9ABxYeYHKjmF0X5HOrXM3mNIQFcyR6ilMZ4ylkSw1+0SC4qAMsqBJJIL9SIF/3xZI 8BJnd9dFM9nYqqpriJDnuOGuPH+DGzaKyXRwjAyQKB5nO6N5/lnXItcxJPGjehn1o8Nn VWBQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@qq.com header.s=s201512 header.b=u9k5afcU; arc=pass (i=1 spf=pass spfdomain=qq.com dkim=pass dkdomain=qq.com dmarc=pass fromdomain=qq.com); spf=pass (google.com: domain of linux-kernel+bounces-164881-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-164881-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=qq.com Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id r15-20020a05622a034f00b0043ad4cfa02esi7116642qtw.284.2024.04.30.20.00.01 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Apr 2024 20:00:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-164881-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@qq.com header.s=s201512 header.b=u9k5afcU; arc=pass (i=1 spf=pass spfdomain=qq.com dkim=pass dkdomain=qq.com dmarc=pass fromdomain=qq.com); spf=pass (google.com: domain of linux-kernel+bounces-164881-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-164881-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=qq.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 30E201C22612 for ; Wed, 1 May 2024 03:00:01 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 65F761EA91; Wed, 1 May 2024 02:59:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=qq.com header.i=@qq.com header.b="u9k5afcU" Received: from out203-205-251-53.mail.qq.com (out203-205-251-53.mail.qq.com [203.205.251.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E7A491BDE6; Wed, 1 May 2024 02:59:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=203.205.251.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714532394; cv=none; b=iIGb7nvpTqfUCmCblF7qaKY/5zM7ILCP1o2dcY1TbOs/QwP9D3sjkJjaLm5HTmmITA/z0PcNlHQ896mxQOlbynEqebxAFYPxwhKaZSGDiJeDRwqu8DDg8UONovgJU5enux5heRVVztf5/lzOgru55y3+syeE5fVqUC8YAqjr8Ug= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714532394; c=relaxed/simple; bh=d1tAv7N4r9JF1f3d8ExotiV9kCZfuFGqR1t9KPkg68o=; h=Message-ID:From:To:Cc:Subject:Date:In-Reply-To:References: MIME-Version; b=S8IEdnE0kN1Ei8cVfo0JtEv/+ilxBGJlr6zASkg7eV/0i+4WFv7SeFkIzCkYUQ5vPLTwfb1J1dfLuEAwc/zBQp4UIuBU2GxwouLg69qPkI29r6ZvcMW20odYiaqxA5cZaTtRZJWiwx1HbjvRb0xQVDQvKw3pTphTm0+9lVe2lM4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=qq.com; spf=pass smtp.mailfrom=qq.com; dkim=pass (1024-bit key) header.d=qq.com header.i=@qq.com header.b=u9k5afcU; arc=none smtp.client-ip=203.205.251.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=qq.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=qq.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qq.com; s=s201512; t=1714532373; bh=d1tAv7N4r9JF1f3d8ExotiV9kCZfuFGqR1t9KPkg68o=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=u9k5afcUfWsKcQgPH1Wgu5Dl/BzvS6u2ExYXE2bpYS8yMQKxZs7Ud3EweV3jyRbNj ndSl+ds0IPZEauehjRnRQJTtgKSkQBW/e6ABJ2/XPfrdam/gcMH/ZKAXQ1GStYi4ck AFYdsDfYdlNBKPDBlMNUEdRbYPk753oPM4YFxiqQ= Received: from localhost.localdomain ([58.213.8.145]) by newxmesmtplogicsvrszb9-1.qq.com (NewEsmtp) with SMTP id EDE08A34; Wed, 01 May 2024 10:59:30 +0800 X-QQ-mid: xmsmtpt1714532370tjm9c2u5n Message-ID: X-QQ-XMAILINFO: OZZSS56D9fAjxGKrQADUKsPokn/M5v6KjP59P/aUwioO25gjK3CbXLdUHBmY5a ekm4emHbJQkzcEKm2hvLtBvKcLOaV/+Ut3Uhwd5g/ozh4VXaWblwj5BJjzrZPMEkj4UtaqcsTymG e8vDIaw5qLrbzw9uDMQhLii30+bieExBE3zyFEbAY+Kz9SC36m639PhjOB2y2DDYjpaFyQ5RINCb zDQoLjGTZKdzcPV/48CZyElQqZhalSWV5pHqXqpyDt0wOn8hrvJmezN9z9VWpqW7rdAroVeHmcB8 zUb+pQoS+mkNQ5G+3P2uGm1XExWovdddxYycB7LMqdSM+GjmZVLbA2pnkrIUR/zvted+2xaSbVwj cyBXqWjcSj0Y+AFWN+UF+eJXoJRJ0wWfaSAGY1GPOX5jXGZ0zZ5XfMU49AgChcxqFnqdUatM/vJi FSfX4fN0JDKJtFdsttvCOTolpahvcrsYP5/RzQD5zRaaa7UaFLoXJqFcjJADdxxV/LzI3PQypXkF RaNBBfnDLcHSm8Aggj/I/LvNN2VsUd/C9L11YQKlyKfoi4sv1JyF9pf51wFgkDiNEFtv+8snRdrf WGiIJcJ6YyXOfON5nVtKiJva4HOwpXPbqmEFU7zURn/Lv/dbUcfQxYDxgaUHVcJrxheVRWALeBAJ qdeyd6pCul/ePl2ek1fD8vQOGfRXNKC9qrBvM5tyNrGOmi3s5holmlbklF4jYVEorTT8cX18ew0O 7XVfF6D+tGuA+/+7mk+07x2z7SlO98VVl94Hdr6u2OyENxieWlvMRQ7DzY47ifxiTd5w9i2s26i7 YQgXtVaoxIgOsV3qGZuITFm/vVk/ixFAA9jfhuy6VkmWrrDNoVVjk0fwiX97C7AJaUP7+z2t+LrJ 7rUvZIRlAfcYLqN5/81cLsOYzVPpd2BTXW+3IXY22ZluDEoiIYS4iFJx89ujIcnuSCLN/q4vHKqk r09YWqtXkCA7ppX6iat67k1EAGtpP2yWVeO6TkN88s2zTqAl7siiUJVUh1Yol9 X-QQ-XMRINFO: Mp0Kj//9VHAxr69bL5MkOOs= From: linke li To: ardb@kernel.org Cc: bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, lilinke99@qq.com, linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org, mingo@redhat.com, tglx@linutronix.de, x86@kernel.org, xujianhao01@gmail.com Subject: Re: [PATCH] x86/efi: mark racy access on efi_rts_work.efi_rts_id Date: Wed, 1 May 2024 10:59:28 +0800 X-OQ-MSGID: <20240501025928.63749-1-lilinke99@qq.com> X-Mailer: git-send-email 2.39.3 (Apple Git-146) In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit > Why is this the only reference that needs an annotation? In the function efi_runtime_services_init(), the if check on efi_rts_work.efi_rts_id in line 728 uses READ_ONCE(), and the comment explains that this is to reduce reports from KTSAN. I propose that the check in line 754 undergoes a similar treatment for consistency and to potentially reduce sanitizer reports. Thank you.