Received-SPF: pass (google.com: domain of linux-kernel+bounces-164969-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Subject: Re: [PATCH v4 1/2] acpi/ghes: Process CXL Component Events
To: Ira Weiny <ira.weiny@intel.com>, Dave Jiang <dave.jiang@intel.com>,
 Dan Williams <dan.j.williams@intel.com>,
 Jonathan Cameron <jonathan.cameron@huawei.com>,
 Shiju Jose <shiju.jose@huawei.com>
Cc: Dan Carpenter <dan.carpenter@linaro.org>,
 Yazen Ghannam <yazen.ghannam@amd.com>, Davidlohr Bueso <dave@stgolabs.net>,
 Alison Schofield <alison.schofield@intel.com>,
 Vishal Verma <vishal.l.verma@intel.com>, Ard Biesheuvel <ardb@kernel.org>,
 linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org,
 linux-cxl@vger.kernel.org, "Rafael J. Wysocki" <rafael@kernel.org>,
 Tony Luck <tony.luck@intel.com>, Borislav Petkov <bp@alien8.de>
References: <20240426-cxl-cper3-v4-0-58076cce1624@intel.com>
 <20240426-cxl-cper3-v4-1-58076cce1624@intel.com>
From: Smita Koralahalli <Smita.KoralahalliChannabasappa@amd.com>
Message-ID: <02b42a2f-9e0c-2895-47dc-d176ee320e7b@amd.com>
Date: Tue, 30 Apr 2024 23:36:49 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.4.0
In-Reply-To: <20240426-cxl-cper3-v4-1-58076cce1624@intel.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?YXU2OS9wNForNEtjOHpxQmYrVWIzUnd3ZGdsSU15OHhPNmNoRDg2aUZOUWNh?=
 =?utf-8?B?bFdCMEI5clFyQ2FuS0tBbzhRMWZwMkV6VDVWN3ZiZ0NkNDgzNFJacXRHNHJj?=
 =?utf-8?B?UTJCSkhzWUpqYlRkb2FWeEFXMjF4VlY1bkFXR2hQWWxOSWFNNUk3Qk1qTExN?=
 =?utf-8?B?NVRPbXZ1VWl5aTVMZTYrb2VpY3g3TDVXZ09lU09hemJqR1lHbEI5UjRxRm9v?=
 =?utf-8?B?eEhEaGxRUWhET2kyOExkRk83b0xQMUx3N0dBVlkyT05hdDNMejFMR2JIazJx?=
 =?utf-8?B?MXZSNUlpcVVBK1FyeW8rd3BPeUNSelo2allXcVV5d3pudFBsZHgrVkRydXdr?=
 =?utf-8?B?K2lTVGFiRktTRlJEeUMzNGRNTnJYUWQxTFQyK3RaWE00eFJ6UGRXVjRqRm5C?=
 =?utf-8?B?L3BuTE1RdE1ORUdpaVlGTlRJcjE1b24weURqL3ZjaWxxc245QWlhZTQ2OHNm?=
 =?utf-8?B?c05LanZKYmZvc2ptZkNEandlN0RTZmVoaG9tZGE5QVE4UjZRb0tidjJqWXlO?=
 =?utf-8?B?RVVPdDBJTDRuRURYMDhOZENIejcrUDRmYUlNNTNjK3RheEY4R043Q3RWUFky?=
 =?utf-8?B?MVVYQlVXWllKcFFMZVV2L3J1bGltdjZCVVREYUVJcVFIRWl3VHlWVGpoKyt6?=
 =?utf-8?B?d1VTa2E5c1J6SFBMZjZ0azhnaWlGbkhUSTdqZWxITUJOQzJwRjAzN2Z1RkxV?=
 =?utf-8?B?TUtaL0ZnaVMvVG1TekNPZWdUZVExRWd3T1JIZlRKdHBZdUd3UmRnckpCMzFv?=
 =?utf-8?B?VXNLWkEwaURLbk5EaDlYQURJQmlITWF4aGEwaHhESXNBRjZwd1MvWTZYWkp5?=
 =?utf-8?B?a0pXSVIrVjlPTERSY3E2THh6d0xmZFl5c3FPNnRsUURVU01SK0xYUWJjOTZB?=
 =?utf-8?B?R2RLSDNjZUhiMldkbFd1Q1N4NkRLOGRPaVJuS2M1S3d2NTR5WStyU25GM0xU?=
 =?utf-8?B?NHlDT2NiZHdQYTArdEpOWURxbkFSZUM0SnN5ZWNoU0IwR3lDUlgwSm5Ibzc1?=
 =?utf-8?B?d0ZYZmF1M2FvZUpCZjhjdjJHVndCa1EyYW1hTWRHVmI0Z1p1bEtNUmFMdlhE?=
 =?utf-8?B?Yit0M1l1OUdvTGowc0Y2VXdJcGRUT29BZ2ZPYzNLVWhVRmM0VVVLUVAybitE?=
 =?utf-8?B?MldwZUZoSzl2RUthcG5PTUJRUzNrcHROeTdXVDFNbURZTXRXWlcyb3pWNzU1?=
 =?utf-8?B?azEzNmFYMWFXQWhLWlNINjFNUlZ2NjlDM1dtWTNoODVWM0tpd1BRZUhMSVZz?=
 =?utf-8?B?RnpBM3JmZHJqQk1zY01lV2tvTUoraGRiR1dqWExLQ0lsOEhVT1JmQkRtV0dH?=
 =?utf-8?B?SmJwL2tyQ2RweXV3MDNqQnJreFo5YWVjeFRLMzZvWXdYOWxYTVUyY0pLL3dZ?=
 =?utf-8?B?WkJyOVJiQzVTR0tlcU1YNTRZK2xXYjNZRjhFSit2dkJzcEt5UkgzY1JQSkNv?=
 =?utf-8?B?a0JFU3NLKy8yV216UWNRUjFzb0EyYzJFV1YveXpJSXVmNGZWRCtIalNValhF?=
 =?utf-8?B?b3N3SzZUSzZaaC9pSjl3cVlKN2s3U2xFeWxQUHRpUytMbyt2eEh4ZkMwcGJR?=
 =?utf-8?B?RW5Ic282YXk4QlhxaGZIUThrU3lMM2tSelFwS1VuaWduL1NtVFZlQTZ0V2hr?=
 =?utf-8?B?Uk5oQ2NCRURWNGZNSDk1K2xqYzNCcCsyeG1PRmhyWFJYUHUzZHpheDVxSVpy?=
 =?utf-8?B?Q2puM3JTNFloNHBlTlpIU0pKTFRyanI3Y0dtSnREdGpSV0Z5dkgxZEFTMkJq?=
 =?utf-8?B?RkRnTmhWYmtqMkNtaHpBYllWOUw3NWxmSTlLSFNsRnRxZnF1NmtLQ3loZTdK?=
 =?utf-8?B?Zzl0SDhpTG42RkIvMUFDaGErbjVoK1JwYWczYWxLQTMwQzFlY0Z6WmM1VVVM?=
 =?utf-8?B?dWZNaGx2L0wzWVV5cGtQUFlwRkNWeFp6a1Azcm9GYk1JSjg5bXRKZnhjK3Rv?=
 =?utf-8?B?WExzTjl0NXNOZVFldjR6MjJsMWs5aStLYUNNSkhZVVpqeTRSSmRTblBoOCt4?=
 =?utf-8?B?T1VaY1NOQlM4TGYweGozbGRnVDVxbk40S2d1anZxM3o0MmIxcjREZ0l0NUtr?=
 =?utf-8?B?S0tHd2NVc2R5YWJ4aFgxdVk1S3lnblU0WUNsbnZlcFZtMmlTeWw3ZVE2U1Z5?=
 =?utf-8?Q?ETmy2n0Zwdjra92TlUNj9DWuF?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 329c2d5f-25ac-43f8-a843-08dc69a915a4
X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB2869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 May 2024 06:36:51.4634
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: lzBIq6VWzMcAgnfmxtzAAlRhBTpQhC3HpKUExCwcNrzEuNsncmSefMnnpFpaMjVA7Lv3HBckkpZePzicCU7kbg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6410

On 4/26/2024 8:34 PM, Ira Weiny wrote:
> BIOS can configure memory devices as firmware first.  This will send CXL
> events to the firmware instead of the OS.  The firmware can then inform
> the OS of these events via UEFI.
> 
> UEFI v2.10 section N.2.14 defines a Common Platform Error Record (CPER)
> format for CXL Component Events.  The format is mostly the same as the
> CXL Common Event Record Format.  The difference lies in the use of a
> GUID as the CPER Section Type which matches the UUID defined in CXL 3.1
> Table 8-43.
> 
> Currently a configuration such as this will trace a non standard event
> in the log omitting useful details of the event.  In addition the CXL
> sub-system contains additional region and HPA information useful to the
> user.[0]
> 
> The CXL code is required to be called from process context as it needs
> to take a device lock.  The GHES code may be in interrupt context.  This
> complicated the use of a callback.  Dan Williams suggested the use of
> work items as an atomic way of switching between the callback execution
> and a default handler.[1]
> 
> The use of a kfifo simplifies queue processing by providing lock free
> fifo operations.  cxl_cper_kfifo_get() allows easier management of the
> kfifo between the ghes and cxl modules.
> 
> CXL 3.1 Table 8-127 requires a device to have a queue depth of 1 for
> each of the four event logs.  A combined queue depth of 32 is chosen to
> provide room for 8 entries of each log type.
> 
> Add GHES support to detect CXL CPER records.  Add the ability for the
> CXL sub-system to register a work queue to process the events.
> 
> This patch adds back the functionality which was removed to fix the
> report by Dan Carpenter[2].
> 
> Cc: Ard Biesheuvel <ardb@kernel.org>
> Cc: Rafael J. Wysocki <rafael@kernel.org>
> Cc: Tony Luck <tony.luck@intel.com>
> Cc: Borislav Petkov <bp@alien8.de>
> Suggested-by: Dan Carpenter <dan.carpenter@linaro.org>
> Suggested-by: Dan Williams <dan.j.williams@intel.com>
> Link: http://lore.kernel.org/r/cover.1711598777.git.alison.schofield@intel.com [0]
> Link: http://lore.kernel.org/r/65d111eb87115_6c745294ac@dwillia2-xfh.jf.intel.com.notmuch [1]
> Link: http://lore.kernel.org/r/b963c490-2c13-4b79-bbe7-34c6568423c7@moroto.mountain [2]
> Reviewed-by: Dan Williams <dan.j.williams@intel.com>
> Signed-off-by: Ira Weiny <ira.weiny@intel.com>
> ---

Sorry, I couldn't get a chance to follow up with all revisions. But 
tested this and it looks good to me.

Tested-by: Smita Koralahalli <Smita.KoralahalliChannabasappa@amd.com>