Received-SPF: pass (google.com: domain of linux-kernel+bounces-165032-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <fb0293d85dbf82341c6b7e4d56fe8f1d23f7768a.camel@physik.fu-berlin.de>
Subject: Re: [PATCH] Revert "sh: Handle calling csum_partial with misaligned
 data"
From: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
To: Guenter Roeck <linux@roeck-us.net>, Yoshinori Sato
	 <ysato@users.sourceforge.jp>
Cc: Rich Felker <dalias@libc.org>, linux-sh@vger.kernel.org, 
	linux-kernel@vger.kernel.org
Date: Wed, 01 May 2024 10:28:11 +0200
In-Reply-To: <1e77ade4fb1d924ffaf226cb946ba3314ba59a1d.camel@physik.fu-berlin.de>
References: <20240324231804.841099-1-linux@roeck-us.net>
	 <059d03a5da257660fa0bc188c6cc8d0152e97704.camel@physik.fu-berlin.de>
	 <a9ac59cd-82db-45a0-9f85-ec3880c54dbf@roeck-us.net>
	 <cb8d3d2a-b843-49d5-a219-10a29b5877d0@roeck-us.net>
	 <1e77ade4fb1d924ffaf226cb946ba3314ba59a1d.camel@physik.fu-berlin.de>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.52.0 
Precedence: bulk
MIME-Version: 1.0

Hi Guenter,

On Tue, 2024-04-02 at 16:09 +0200, John Paul Adrian Glaubitz wrote:
> On Tue, 2024-04-02 at 07:06 -0700, Guenter Roeck wrote:
> > Hi,
> >=20
> > On Mon, Mar 25, 2024 at 07:34:00AM -0700, Guenter Roeck wrote:
> > > On 3/25/24 00:39, John Paul Adrian Glaubitz wrote:
> > > > Hi Guenter,
> > > >=20
> > > > On Sun, 2024-03-24 at 16:18 -0700, Guenter Roeck wrote:
> > > > > This reverts commit cadc4e1a2b4d20d0cc0e81f2c6ba0588775e54e5.
> > > > >=20
> > > > > Commit cadc4e1a2b4d ("sh: Handle calling csum_partial with misali=
gned
> > > > > data") causes bad checksum calculations on unaligned data. Revert=
ing
> > > > > it fixes the problem.
> > > > >=20
> > > > >      # Subtest: checksum
> > > > >      # module: checksum_kunit
> > > > >      1..5
> > > > >      # test_csum_fixed_random_inputs: ASSERTION FAILED at lib/che=
cksum_kunit.c:500
> > > > >      Expected ( u64)result =3D=3D ( u64)expec, but
> > > > >          ( u64)result =3D=3D 53378 (0xd082)
> > > > >          ( u64)expec =3D=3D 33488 (0x82d0)
> > > > >      # test_csum_fixed_random_inputs: pass:0 fail:1 skip:0 total:=
1
> > > > >      not ok 1 test_csum_fixed_random_inputs
> > > > >      # test_csum_all_carry_inputs: ASSERTION FAILED at lib/checks=
um_kunit.c:525
> > > > >      Expected ( u64)result =3D=3D ( u64)expec, but
> > > > >          ( u64)result =3D=3D 65281 (0xff01)
> > > > >          ( u64)expec =3D=3D 65280 (0xff00)
> > > > >      # test_csum_all_carry_inputs: pass:0 fail:1 skip:0 total:1
> > > > >      not ok 2 test_csum_all_carry_inputs
> > > > >      # test_csum_no_carry_inputs: ASSERTION FAILED at lib/checksu=
m_kunit.c:573
> > > > >      Expected ( u64)result =3D=3D ( u64)expec, but
> > > > >          ( u64)result =3D=3D 65535 (0xffff)
> > > > >          ( u64)expec =3D=3D 65534 (0xfffe)
> > > > >      # test_csum_no_carry_inputs: pass:0 fail:1 skip:0 total:1
> > > > >      not ok 3 test_csum_no_carry_inputs
> > > > >      # test_ip_fast_csum: pass:1 fail:0 skip:0 total:1
> > > > >      ok 4 test_ip_fast_csum
> > > > >      # test_csum_ipv6_magic: pass:1 fail:0 skip:0 total:1
> > > > >      ok 5 test_csum_ipv6_magic
> > > > >   # checksum: pass:2 fail:3 skip:0 total:5
> > > > >   # Totals: pass:2 fail:3 skip:0 total:5
> > > > > not ok 22 checksum
> > > >=20
> > > > Can you tell me how the tests are run so I can try to verify this o=
n real hardware?
> > > >=20
> > >=20
> > > Enabling CONFIG_KUNIT and CHECKSUM_KUNIT and booting with those tests=
 enabled
> > > should do it.
> > >=20
> >=20
> > Did you have time to test this on real hardware ?
>=20
> Not yet. I just returned from Easter holidays and need to get synced with=
 work first.

I might have to skip this for v6.10 as I haven't been able to test this yet=
.

I agree with the change in general, but I want to make sure I can reproduce
this on real hardware.

Adrian

--=20
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer
`. `'   Physicist
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913