Received: by 2002:ab2:60d1:0:b0:1f7:5705:b850 with SMTP id i17csp338921lqm; Wed, 1 May 2024 02:02:02 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCW+qaf+7GQBThUaMdolzsDjW9Uys8T6xjKfU7gXkccEq9wnfpeGaT2s0HV96tIQ2H8sV7kDnqPTCN1oibt6FBfTuKZVbG41Seq9VaDhmw== X-Google-Smtp-Source: AGHT+IEwZloqw3u/ME1wCacRr89H2oWVYm9AoGbO8FQpeGGqPJYqppHgfos7l1udXeQV9S++Hx1c X-Received: by 2002:a50:a696:0:b0:56e:1dda:5c2a with SMTP id e22-20020a50a696000000b0056e1dda5c2amr1955717edc.16.1714554121828; Wed, 01 May 2024 02:02:01 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1714554121; cv=pass; d=google.com; s=arc-20160816; b=ykj8UCPAuJMlzkpOV3Ql27eVmpjRI9plLk9QvquE/Y45hvE/LiD4jxBWkYzK38Yd2t jvB+a7kLbxOvrlh+FnASnOOxOQc1Wclj25rFKj61JHzBnzPHt5C7MIoyyGRG+E1GSa3v 6zT9xjpnIn9KaWv3jG0uYoC3qC4a3ZUVQahu38KMlzxbSsBOADOlqf4pnVD/pHaOQHyv /8UgjUI02U/pQPYfez+QyhFwpdSZpn0aQ5u7AxM23cdRlXdniTNLmvSiK5TDROe1TljF bWjnSNwKe966e/ZTxvruSzMIwawJl+O702TipfplIw626Vb+0OP0ntfF4DeQcbHfs3iI oagw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=HVf+4ZQ4Imh+RkWB6AT2WtZQ623w3oYQq+TISB4ThZM=; fh=9As8rStP0eF12Phv7dCHH/Le5M/eeeFFBQP1tXsIxq8=; b=RlpGu7GMJeOn1JLXS+iqhOiSJM15UN7XaycHnMdExMqpidgcJt8t5wzLznAwXkBTK1 sF8MAXmX8eYBF//JSGVczVoDwEVvZES7eTMdXkbjC2dyB35aqyK1/dbHteVC37ka4Exb xRGaFhjVMEchAQFFlnCbhvLgzmP0gqDvbkGyXSZXZNCef+q3Tg18TxaPXwlg4dkKoulM sMWqV4ZH/ERbthVUOVQBZhUVFA1Hl3eKvM5EnqW6LiJxt6dhtkKLcCsFO3Q6KTswgaH8 10ZFYWvzv30tFANiTjU/GbuYQrnVTz5ZWPE3XcxgLDtFytL7EPFs/fTd57FErcyHYeNM x+Qw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=hMyozbQi; arc=pass (i=1 dkim=pass dkdomain=infradead.org); spf=pass (google.com: domain of linux-kernel+bounces-164910-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-164910-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id u22-20020a05640207d600b00572af11a0c8si341417edy.148.2024.05.01.02.02.01 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 May 2024 02:02:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-164910-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=hMyozbQi; arc=pass (i=1 dkim=pass dkdomain=infradead.org); spf=pass (google.com: domain of linux-kernel+bounces-164910-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-164910-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id CEF041F26C71 for ; Wed, 1 May 2024 04:14:22 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D94003CF65; Wed, 1 May 2024 04:14:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="hMyozbQi" Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CB16022F19; Wed, 1 May 2024 04:14:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=90.155.50.34 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714536852; cv=none; b=UOEdeWdk9sOzsoBr+Eh/tE4QlPLrkB/OJOryiCKyuOVXIjbWPh1LNrUnCzmT3ZCs5zapZ7QwW5Nb1o1FAq+dHSd6p7euPtLnX6NIJCEg1s3wabhyVM3jerJmeoBVWv2pghJRkcBQ4J0uXYhxvCt8+h3hINPYSCE/F1BzretU/T0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714536852; c=relaxed/simple; bh=h6rKiW0img3etNLEAGqXiIzqSAgz6tYBryIkSyqrYf4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=F14XTzEd3HLk6UJfZ8qAHz2fbB7WFSOD9CqcK6coEOLSRDzOVVMQxKV9P7fGm42FI6MlqqhveIWUhlaOhCAuydtlPvmScRaffmpwBekC1wQEI93sqLOF6LUncbUmVNAvTefFuiUd5vnOP1RQN96VnVlKDPC45wxVQG1noHg+vhk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=hMyozbQi; arc=none smtp.client-ip=90.155.50.34 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=HVf+4ZQ4Imh+RkWB6AT2WtZQ623w3oYQq+TISB4ThZM=; b=hMyozbQiEMJ6TFFO2IInPbCVA6 H1sabx9aEHhdO0qvCKGOlCb9+l6cq1jKHRe/vtYa8J5usz+YcioXOwKtO1YlEaFrOPFUd6zEj4zNE 3eJxjAoRMzv8e/9YPQdsBxnvH/MXahvY5mvBHgr7+lTCnLLjrVRtilQ/9/8SGJclW2v2v0oYMmef6 zhNv1S1abnxt0ClpfEAA7IYU5/9gWVPVj/LwKKnSmwUwmONlelDjLKXm9OeuqhFaR4YeBXM9EoWpE Ps7a1XRNnuATcSHNvQwz4CZvk90JQUVeprpv7BfQpMa1CtkgDMXbJLjq0Iu6vVzXbnOBkNHqFLYWm n1DqebJA==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1s21Lz-0000000G9qX-2e7R; Wed, 01 May 2024 04:13:59 +0000 Date: Wed, 1 May 2024 05:13:59 +0100 From: Matthew Wilcox To: Luis Chamberlain Cc: Zi Yan , Andrew Morton , Vlastimil Babka , Sean Christopherson , "Pankaj Raghav (Samsung)" , djwong@kernel.org, brauner@kernel.org, david@fromorbit.com, chandan.babu@oracle.com, linux-fsdevel@vger.kernel.org, hare@suse.de, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-xfs@vger.kernel.org, gost.dev@samsung.com, p.raghav@samsung.com Subject: Re: [PATCH v4 05/11] mm: do not split a folio if it has minimum folio order requirement Message-ID: References: <20240425113746.335530-6-kernel@pankajraghav.com> <6799F341-9E37-4F3E-B0D0-B5B2138A5F5F@nvidia.com> <202988BE-58D1-4D21-BF7F-9AECDC178D2A@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Apr 30, 2024 at 12:27:04PM -0700, Luis Chamberlain wrote: > 2a:* 8b 43 34 mov 0x34(%rbx),%eax <-- trapping instruction > RBX: 0000000000000002 RCX: 0000000000018000 Thanks, got it. I'll send a patch in the morning, but I know exactly what the problem is. You're seeing sibling entries tagged as dirty. That shouldn't happen; we should only see folios tagged as dirty. The bug is in node_set_marks() which calls node_mark_all(). This works fine when splitting to order 0, but we should only mark the first entry of each order. eg if we split to order 3, we should tag slots 0, 8, 16, 24, .., 56.