Received-SPF: pass (google.com: domain of linux-kernel+bounces-165073-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Precedence: bulk
MIME-Version: 1.0
References: <20240204044143.415915-1-qiujingbao.dlmu@gmail.com>
 <20240204044143.415915-3-qiujingbao.dlmu@gmail.com> <IA1PR20MB49533772D594D18204E9F9EEBB192@IA1PR20MB4953.namprd20.prod.outlook.com>
 <CAJRtX8Rz0BhbtBJq+gSRTU3vsOwfyWjrqJ-Q1fqr7ZFeY2uaNQ@mail.gmail.com> <IA1PR20MB495377FCD5101F85B02BB5BCBB192@IA1PR20MB4953.namprd20.prod.outlook.com>
In-Reply-To: <IA1PR20MB495377FCD5101F85B02BB5BCBB192@IA1PR20MB4953.namprd20.prod.outlook.com>
From: Jingbao Qiu <qiujingbao.dlmu@gmail.com>
Date: Wed, 1 May 2024 17:14:43 +0800
Message-ID: <CAJRtX8Ruh4BethYcGM2RueNBDioXpn8dJ3yvUD4iW_1cmiVFqg@mail.gmail.com>
Subject: Re: [PATCH v8 2/2] rtc: sophgo: add rtc support for Sophgo CV1800 SoC
To: Inochi Amaoto <inochiama@outlook.com>
Cc: alexandre.belloni@bootlin.com, robh+dt@kernel.org, 
	krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, 
	paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, 
	linux-rtc@vger.kernel.org, devicetree@vger.kernel.org, 
	linux-kernel@vger.kernel.org, dlan@gentoo.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, May 1, 2024 at 3:43=E2=80=AFPM Inochi Amaoto <inochiama@outlook.com=
> wrote:
>
> On Wed, May 01, 2024 at 01:03:58PM GMT, Jingbao Qiu wrote:
> > Hi, Inochi
> >
> > On Wed, May 1, 2024 at 10:19=E2=80=AFAM Inochi Amaoto <inochiama@outloo=
k.com> wrote:

> > > Another thing is that I do not think is a good way to let the
> > > rtc driver access RTC_CTRL area directly. You have already
> > > know there is a 8051 device in the 0x05025000. It is necessary
> > > to make some room for this device. Maybe you want to implement
> > > them all in the rtc driver? If so, I do think it is a bad idea.
> >
> >
> > Do you mean that RTC drivers should not directly access the 0x05025000 =
address?
> > Because there is an 8051 subsystem on this address.
>
> Yes. At least we need some mechanism to share these address between
> this devices.
>
> > Firstly, I do not intend to implement 8051 in the RTC driver,
> > but the 8051 subsystem is located within a module independently
> > powered by the RTC.
> > So if we want to implement the 8051 subsystem in the future, it can be
> > used as a node in RTC? I'm not sure.
>
> Yes, this is what I care about.
>
> > Then, Alexandre told me that there are operations related to PM in
> > RTC, such as the following files.
> > This matches the description of address 0x05025000.
> >
> > drivers/rtc/rtc jz4740. c
> >
>
> I do not think this is something related to the PM. 8051 is more
> like remoteproc. So it is necessary to arrange them carefully.
>

You are right.
I learned from official documents that 8051 works in the RTC domain.
Linux does not provide relevant interfaces to operate 8051,
Just providing a mailbox for communication between them, or through
interruptions.
I don't understand how 8051 works, so I shouldn't write to the
corresponding registers in RTC.

https://milkv.io/docs/duo/getting-started/8051core


> > > > 2.25.1
> > > >