Received-SPF: pass (google.com: domain of linux-kernel+bounces-165087-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240430-fix-ipu6-v1-0-9b31fbbce6e4@chromium.org>
 <20240430-fix-ipu6-v1-2-9b31fbbce6e4@chromium.org> <42svo2ykapj3atpds3dedqzybp4vh7vcvje622n4cxz6geaw2w@mfazrgyw6653>
In-Reply-To: <42svo2ykapj3atpds3dedqzybp4vh7vcvje622n4cxz6geaw2w@mfazrgyw6653>
From: Ricardo Ribalda <ribalda@chromium.org>
Date: Wed, 1 May 2024 11:22:26 +0200
Message-ID: <CANiDSCsJvTV81H_jUWufFGp0TqE7u9t=6MKO8BU294aanomm-Q@mail.gmail.com>
Subject: Re: [PATCH 2/4] media: intel/ipu6: Switch to RUNTIME_PM_OPS() and SYSTEM_SLEEP_PM_OPS
To: Hidenori Kobayashi <hidenorik@chromium.org>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>, Florian Fainelli <florian.fainelli@broadcom.com>, 
	Ray Jui <rjui@broadcom.com>, Scott Branden <sbranden@broadcom.com>, 
	Broadcom internal kernel review list <bcm-kernel-feedback-list@broadcom.com>, 
	Sakari Ailus <sakari.ailus@linux.intel.com>, Bingbu Cao <bingbu.cao@intel.com>, 
	Tianshu Qiu <tian.shu.qiu@intel.com>, linux-media@vger.kernel.org, 
	linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, 
	linux-kernel@vger.kernel.org, Hans Verkuil <hverkuil@xs4all.nl>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, 1 May 2024 at 11:20, Hidenori Kobayashi <hidenorik@chromium.org> wr=
ote:
>
> On Tue, Apr 30, 2024 at 12:55:34PM +0000, Ricardo Ribalda wrote:
> > Replace the old helpers with its modern alternative.
> > Now we do not need to set '__maybe_unused' annotations when we are not
> > enabling the PM configurations.
> >
> > Fixes:
> > drivers/media/pci/intel/ipu6/ipu6.c:841:12: warning: =E2=80=98ipu6_runt=
ime_resume=E2=80=99 defined but not used [-Wunused-function]
> > drivers/media/pci/intel/ipu6/ipu6.c:806:12: warning: =E2=80=98ipu6_resu=
me=E2=80=99 defined but not used [-Wunused-function]
> > drivers/media/pci/intel/ipu6/ipu6.c:801:12: warning: =E2=80=98ipu6_susp=
end=E2=80=99 defined but not used [-Wunused-function]
> >
> > Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
> > ---
> >  drivers/media/pci/intel/ipu6/ipu6.c | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/media/pci/intel/ipu6/ipu6.c b/drivers/media/pci/in=
tel/ipu6/ipu6.c
> > index 4b1f69d14d71..ff5ca0c52781 100644
> > --- a/drivers/media/pci/intel/ipu6/ipu6.c
> > +++ b/drivers/media/pci/intel/ipu6/ipu6.c
> > @@ -803,7 +803,7 @@ static int ipu6_suspend(struct device *dev)
> >       return 0;
> >  }
> >
> > -static int ipu6_resume(struct device *dev)
> > +static int __maybe_unused ipu6_resume(struct device *dev)
>
> Doesn't this contradict your commit message?
Ups, good catch!

I started by adding __maybe_unused everywhere and then decided to use
a different macro. Will upload a new revision later today.

>
> >  {
> >       struct pci_dev *pdev =3D to_pci_dev(dev);
> >       struct ipu6_device *isp =3D pci_get_drvdata(pdev);
> > @@ -860,8 +860,8 @@ static int ipu6_runtime_resume(struct device *dev)
> >  }
> >
> >  static const struct dev_pm_ops ipu6_pm_ops =3D {
> > -     SET_SYSTEM_SLEEP_PM_OPS(&ipu6_suspend, &ipu6_resume)
> > -     SET_RUNTIME_PM_OPS(&ipu6_suspend, &ipu6_runtime_resume, NULL)
> > +     SYSTEM_SLEEP_PM_OPS(&ipu6_suspend, &ipu6_resume)
> > +     RUNTIME_PM_OPS(&ipu6_suspend, &ipu6_runtime_resume, NULL)
> >  };
> >
> >  MODULE_DEVICE_TABLE(pci, ipu6_pci_tbl);
> >
> > --
> > 2.44.0.769.g3c40516874-goog
> >
> >


--=20
Ricardo Ribalda