Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1763185AbYA1XDK (ORCPT ); Mon, 28 Jan 2008 18:03:10 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1761844AbYA1XCs (ORCPT ); Mon, 28 Jan 2008 18:02:48 -0500 Received: from wa-out-1112.google.com ([209.85.146.183]:44526 "EHLO wa-out-1112.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1762302AbYA1XCp (ORCPT ); Mon, 28 Jan 2008 18:02:45 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:cc:subject:references:in-reply-to:x-enigmail-version:content-type:content-transfer-encoding; b=RGg5RcPGVS8wba66j23VLrRjuo7DJ1pypy4tk1EyG6PoktrbLMpzT3ekauhjzxwvBBanpjEDi4fK8I3zSnkR/KbIBP/7453oIiLTE8drkNHxNmBTiM6w8gw9FqvClucl9GLtj/xplF0xylNgZJLgyVMBjqjDOoeYfyEYWRxNxRY= Message-ID: <479E5F04.3000009@gmail.com> Date: Tue, 29 Jan 2008 08:02:28 +0900 From: Tejun Heo User-Agent: Thunderbird 2.0.0.9 (X11/20070801) MIME-Version: 1.0 To: Adrian Bunk CC: Jeff Garzik , linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [2.6 patch] ata_piix.c: make piix_merge_scr() static References: <20080128221019.GN8767@does.not.exist> In-Reply-To: <20080128221019.GN8767@does.not.exist> X-Enigmail-Version: 0.95.5 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1029 Lines: 32 Adrian Bunk wrote: > piix_merge_scr() can become static. > > Signed-off-by: Adrian Bunk > > --- > f272ad2ac4274a59f0b43cfd65488c51855132d4 > diff --git a/drivers/ata/ata_piix.c b/drivers/ata/ata_piix.c > index a65c8ae..1a5c3bf 100644 > --- a/drivers/ata/ata_piix.c > +++ b/drivers/ata/ata_piix.c > @@ -1068,7 +1068,7 @@ static void piix_sidpr_write(struct ata_device *dev, unsigned int reg, u32 val) > iowrite32(val, hpriv->sidpr + PIIX_SIDPR_DATA); > } > > -u32 piix_merge_scr(u32 val0, u32 val1, const int * const *merge_tbl) > +static u32 piix_merge_scr(u32 val0, u32 val1, const int * const *merge_tbl) > { > u32 val = 0; > int i, mi; Ah.. right. Thanks. I somehow forgot static in front of it. Acked-by: Tejun Heo -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/