Received: by 2002:ab2:60d1:0:b0:1f7:5705:b850 with SMTP id i17csp374136lqm; Wed, 1 May 2024 03:27:46 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWHweVzXqzM9F5g96d1jheYyGy8kaEWorW/z/zkGnaTAKFfL4HXTaOlC83hqsJKjzGNpeyvvkzoMo8LEGshzgIbYcuieGZvn5KV3B4x/g== X-Google-Smtp-Source: AGHT+IGRZj6iXC2wXxQ5ss3k0j2kPmF9uXZ7iOIhg6bNlksZJGhvWgr+aNQmvrqkl50VqikCQmhw X-Received: by 2002:a17:906:b351:b0:a52:53f2:5ae0 with SMTP id cd17-20020a170906b35100b00a5253f25ae0mr1420449ejb.74.1714559266790; Wed, 01 May 2024 03:27:46 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1714559266; cv=pass; d=google.com; s=arc-20160816; b=HtEYePmd7oR/omVW/gBvBAfSEcmkNVDEnxbWQBO1K8hc/uwdqPCOjp0rBPOdHVooV7 LmkX3eqOdaNdMqCfCvFazXvfRdZ4AKf2hIz8a6AKbUH68p9RBbrRqmK6C4jYZMIJ3B6Z 90yzzE325wUrE1oN3w5dy94LCsQMYHofhnovLHvGBU61mKcI+1NBfcj0k7uCssTJCLtD JXuPQMDImQLmZ3e0OQ5IVhU56K1jVzSA9HHrnmFC9sdoraqCShQsEs0DzA4qP0PpUmgU nXzgi+sCsx2Y9NCfX0/oeP+m7lzW8t4yMO3/8aPv/hmbF9njuXiuWwI4uolUYMrypIxu BAxA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id; bh=cGWvhIgXrNI2O6VT23pX5aJQXgnkmeYOaGQGYm6iAHE=; fh=QIAJQZ/AuZ7uW1Ow9cIZz2X1af9zkyYUtxpbAp9ck8c=; b=MJrcdUmAZjVhfL+R+GR1xCqzCqVig0/nueWtLTVxw+vGlpjbosoNe9d8pwC3dM01Tz KzEgTl24lybPm5JD0yTr2ptLnYokysLccEWQlLv80JQMlh8WvuqyjyYmzt1enABI6LPS ggF4ocDCz/IEWFdslwAb3IhoxFqHz5B3OTiodFZWW6gWXD6zoh1G4KrIUpVVMad8mIJR XYyqZGxrjMQ76KhnWtQwbA1Nbqrz5Bcy2N2PMIgKqR3hTnVMyreP9qJdzYi4zYM/EFYO nf7AIaglJMFeFfeiu5YhltlPY2W4IcIWn9kbcW6Sbw2I5vVsSxxUUxnatYJPdjXesdIa z46A==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-165142-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-165142-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id a22-20020a170906245600b00a556407c0a4si16178582ejb.281.2024.05.01.03.27.46 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 May 2024 03:27:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-165142-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-165142-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-165142-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 8553C1F23DCF for ; Wed, 1 May 2024 10:27:46 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 14B49535B7; Wed, 1 May 2024 10:27:40 +0000 (UTC) Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EE5A8524DC for ; Wed, 1 May 2024 10:27:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714559259; cv=none; b=H240EHVmRaF+jeUiAXZxPc+Zfmh0U4YmfWM05ogd2RSmeUyqfXkj3xjY644cG2NalCWQNJ9yRTdD/RIrZO5zn9YXQKY39rxQJSaq4mBjI/1KUcSqCPWd3XMxRMLyzN3a57aOLwtRNguegG6Wkj2cjnvXgeFjJdvZ7TL1m3WeYHI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714559259; c=relaxed/simple; bh=cGWvhIgXrNI2O6VT23pX5aJQXgnkmeYOaGQGYm6iAHE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=f9o7nSdKpBhkHNvaWLysmToPq6uvOp2bCy327lUNppnvoajJgB0iU3mApQRo8T/zNI/vlSrQJy9/BQZxqUXPaxlZYUp2kSjpoTW66cPEl2yCmjgaWt0JolQ634zytbhfs7duLSpAWM6XtsOx9/0VIogmUKJyxWuJ3Ace0APxYNs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=grimberg.me; spf=pass smtp.mailfrom=gmail.com; arc=none smtp.client-ip=209.85.221.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=grimberg.me Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-34aa836b948so1133726f8f.3 for ; Wed, 01 May 2024 03:27:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714559256; x=1715164056; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=cGWvhIgXrNI2O6VT23pX5aJQXgnkmeYOaGQGYm6iAHE=; b=PJnJaEyFZWhLvFYk56rgUYQc+xEcLU2T4TDyYGkigkaSxsL4D4VsJbgTgdktYdAXl6 QHmV5HHqqBU/mShJCw2LBfnR4BnBLSRBlpo1j9fkz5Y3TkQdMw9X+DhWllxCU3r0hb0I ymbSGxP0EK4hHHFbJPBUabFW77SPIMv/LUIxchavUPBvcJifIqXJxV3+YMbNa6NYBKqf 09pYJeskd7wV0oGx/e1OcPYMvK80xMeztRSKb4x9nBhNtxL1Tk3eKa7NHMD9dGbfc/OZ PJ1H+c7D1QkRKZhjcZX8d/HnLXR/ZkRbJhp7KF2D+R4OW1j492OzFS7JzFAf8ONcoC/Q O3qQ== X-Forwarded-Encrypted: i=1; AJvYcCUs0dH4T9cLtIqEAmPBwwKv9fdpJ3uE8FZKBhP72ahsYC9xQVG7AjCMnBPeQ/CtE4nhRz3dNUVwMq1bH/tM3UHT/Kv+IDsQjJPdWZ9t X-Gm-Message-State: AOJu0YyZufTfewx0bUDb31gVTyM4EECpl3ef52UooxUHr8drT5y1mQsW dvY/NdfQTCSrEiKlkud/CEUKYFywQrQDwpKPryRYBsvZweRm/B9Y X-Received: by 2002:a05:600c:138d:b0:41b:fdf9:98b5 with SMTP id u13-20020a05600c138d00b0041bfdf998b5mr1507047wmf.4.1714559256137; Wed, 01 May 2024 03:27:36 -0700 (PDT) Received: from [10.50.4.180] (bzq-84-110-32-226.static-ip.bezeqint.net. [84.110.32.226]) by smtp.gmail.com with ESMTPSA id v17-20020a05600c471100b0041abdaf8c6asm1755829wmo.13.2024.05.01.03.27.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 May 2024 03:27:35 -0700 (PDT) Message-ID: <8f7fae86-414a-455c-8e5d-332c3c78cc60@grimberg.me> Date: Wed, 1 May 2024 13:27:34 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 5/5] nvme: do not retry authentication failures To: Daniel Wagner , Christoph Hellwig Cc: Keith Busch , James Smart , Hannes Reinecke , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org References: <20240430131928.29766-1-dwagner@suse.de> <20240430131928.29766-6-dwagner@suse.de> Content-Language: he-IL, en-US From: Sagi Grimberg In-Reply-To: <20240430131928.29766-6-dwagner@suse.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 30/04/2024 16:19, Daniel Wagner wrote: > When the key is invalid there is no point in retrying. Because the auth > code returns kernel error codes only, we can't test on the DNR bit. I still think that this patch has issues in the sense that in certain cases the controller can suddenly disappear.