Received-SPF: pass (google.com: domain of linux-kernel+bounces-165156-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <33700d9d-08d3-4fad-8ca4-e6beb3529bcb@oracle.com>
Date: Wed, 1 May 2024 11:48:59 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v3 10/21] xfs: Update xfs_is_falloc_aligned() mask for
 forcealign
To: Dave Chinner <david@fromorbit.com>
Cc: djwong@kernel.org, hch@lst.de, viro@zeniv.linux.org.uk, brauner@kernel.org,
        jack@suse.cz, chandan.babu@oracle.com, willy@infradead.org,
        axboe@kernel.dk, martin.petersen@oracle.com,
        linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
        tytso@mit.edu, jbongio@google.com, ojaswin@linux.ibm.com,
        ritesh.list@gmail.com, mcgrof@kernel.org, p.raghav@samsung.com,
        linux-xfs@vger.kernel.org, catherine.hoang@oracle.com
References: <20240429174746.2132161-1-john.g.garry@oracle.com>
 <20240429174746.2132161-11-john.g.garry@oracle.com>
 <ZjGAN8g3yqH01g1w@dread.disaster.area>
Content-Language: en-US
From: John Garry <john.g.garry@oracle.com>
Organization: Oracle Corporation
In-Reply-To: <ZjGAN8g3yqH01g1w@dread.disaster.area>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?eVVGdEExaU1PajBlZU8xUzZySk1JWGFjaGo5bEJlN0VuR1FMTnp0OXg5VXlT?=
 =?utf-8?B?YWdYdTJudFdEMGt5UVpGd0M5LzJ1WXN0dTNXQVpHdTliRzVSbzhFalFEUms0?=
 =?utf-8?B?a0FBM3BYSXAxTU1WZkV0bG1JbFpUWlFSNHFqQ1hWSmRJSC92WEMyTUlzNlRV?=
 =?utf-8?B?bzg2T3FvMUdwZU5uK1ZaaGYwSzZvTFV4SE9WWFJzOFMrVm9aU2gwZUlWcExF?=
 =?utf-8?B?S0ZXN0YyY2NPaG9JQ3NIelZ5dnYya2w0alBYUjVTZVZaSEZGVFgzRGNQVXNC?=
 =?utf-8?B?UFZsWFpoVEtxemtjSEVmZmxiMW0yUUNCY3R2amZ2TnBlQnM5c0pIYWMxSG9N?=
 =?utf-8?B?bmNmYkFCK1M3YytGaTBGT0FmK08wcmJqaWI3U05pQ1kzUzdwMHNWTktxdCsv?=
 =?utf-8?B?YVF3VEZFRi9nK003Z3JMa1FnMFpsWWlobThrdFFRcDU3VzhVOUJXSmtrYUlR?=
 =?utf-8?B?MkIyNVBJUUpDaHlXVkcrc3pCSFA0ZUNGb3NUdFFyV1ZtOXF5czNGQUt1emdK?=
 =?utf-8?B?L1BXZEk2cVpyQVNVWGFVTXFjeWNkZUxvSGpUSWdhTVRuck5iRFl4T0NBZm1S?=
 =?utf-8?B?ZFVWeGhoUERqcWdTQUVxaWVwWllFaUJSMEtQQWhuVEpDbzc5K2tkb1UrNW1M?=
 =?utf-8?B?Z1NDMDJqakVJVUpTVkVlSytjdjNwYk10TWM2R2NySG1zbStkNkt1Y3VFUDN0?=
 =?utf-8?B?MWZLWXUzaUMvdmxaUGFCOXpuaHBYY3JaWDFCN1krY2EvYU9hWWttTExyNUxT?=
 =?utf-8?B?K0hYUkY5WEdBS2U2d3ZaUTVqV3ZzVDhUdzZhQmRZanV2aXpFYW9HbWR1VkdB?=
 =?utf-8?B?WlJaZDZXYnVvWjlHQUlKdWhZckVKWnBESFErZ2xyd1NvZ1hLck52MldzdjRJ?=
 =?utf-8?B?Z3RGZ1B4V0I1ckdVVHNTbEJDL2VlRG1vUjlMZDVMN1g1ZytXQS9ZSmtsRUZM?=
 =?utf-8?B?dlZsL0FWODZOdUpxTjBpUmc5am1sUXhqS0ViWm1DMWZDM2FYSVNoc3hyZEJz?=
 =?utf-8?B?eWVWZEFkcy9rVXFSRFJ4dHVVbi9uQ21QZDZ3dVFQMDhPeXQ3WHd3bG1LWHNS?=
 =?utf-8?B?MTEzOG42b1h4Mk15d0VaTEd5ODBzTHpabE1na0Jvd1d4Z1hKYm52VjVRR0ty?=
 =?utf-8?B?aHlzTTF2K1NVaE8zaFl2Y3l3amhrT0hJTzhnMkpyTDdvZHgyZ05ZMDNuTnlC?=
 =?utf-8?B?ckFFWG9COXdEd1RMZlBENkx0RHhrVzNJZGV6NWMvLzVpUnJ6aVVBVUN1aGJr?=
 =?utf-8?B?ZllaQ0NzQ1BjeEp2ZHE1QnNEVzdhMW9TaDJwUkJrUThZNFZQM3BXdjFLM3Ez?=
 =?utf-8?B?RFQ4ODErUlptZ0RJZ21ZVzJIdUxZVXJDcUhEdjdlSFRVaEU1eTU2aEs2V0Fu?=
 =?utf-8?B?eWZhMG94L1l2NnZEZHY2dlVMRGhxcnBCWEVYcGdod2tpUVlFcTdsemV6SHY0?=
 =?utf-8?B?YnJhSDAyMnFVazFxRHBHQy9LNklEUGhtYU84VzVJMTJsU2RtWTFSUE5sNG9m?=
 =?utf-8?B?aE9uVGFrV25qeHhqODRhclFQVk1UKzNJSDRENmgya1RLcm5DWGU5dmtIeHVC?=
 =?utf-8?B?amljUlc2NVFEcW5HMmdWeVIyL2JwNlhyejFvYndBN01Ba2diWTZWNDhVOGZR?=
 =?utf-8?B?M3J5MVJZcndXbVRodzdmN2xPQ1lRaGpORG5VYUN0bzlleGZyS1hoQ2lBQitn?=
 =?utf-8?B?N0lCamUyMDNJb3pObm5CSGtUTGpxSjVYbHh3OVJiUG1MQ3NaNFdNWTg5ZnNL?=
 =?utf-8?B?b2xPWDJCaEtxMjE0TkhXWHlqU3pQbVBuY1NKS3l3RExYdVdRQUY1NDMyMkp5?=
 =?utf-8?B?RWliMXRUQnpaY0c2OGxiQXFMNE5GMkMvV1pHcEMreXZqWW4xYkovdnFjalA3?=
 =?utf-8?B?TmhLZ0FQZVRuRFVRZmowdk45ME9KeDNQUzBPQW9RNmpvNW5lRGRMeHo4bHEy?=
 =?utf-8?B?S3FvNjBpRG1JNnlLZTZjZ25Bd1VuSmlVdlA5anFJdWtLQmVhRlQrU3FDQXFF?=
 =?utf-8?B?Sy8xTko5S0pqbjJZRGJnZmtQckpDUlcrVWRVaE41aktIU1N5N2tLSWNhVGZy?=
 =?utf-8?B?WVhBZi9VdmtDV2krM1ltSjh4OGdSN1dzSUltUzVnSUc5MElLdVRyWUY4WVM0?=
 =?utf-8?B?Vi9MUjdyVjZPMitjMWlGb2RPcjNqOUdtRmxoVnA2Ynp0NExiMGM1YXJEQ1lI?=
 =?utf-8?B?RkE9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	1cJSl3UIWEiFf2HebMjQ3zVs/OoN0R6Q4Y078G8r+CQju0c/mVkK/oZkDYnlz2Ygt3qyiJw6nBRw8914SHU3DsSxtAey1mW1lZ+wMLoBDVISSP3knFUQ7ByMtBA/1ZXrs+omfR0Fv/zt4ZFQndYCE+j82VLSPniZgm0gUmea7JDBEScVrI1wV0s9n0kg3zM76uSYYAbLretLrWuNEBXX+j7bL6BkvgD0ZSf++hyaqJ7JfwQI2wIH9rzFqcC8cEmTT/iFpb5wYcDpOwmfvoSkt/a0qPLYao64xl852WvGHi+s1kqtANtt4wFcw+q9kXnNB5TYsNkR3Wyklwx3UItb6pYfJxMkRacU0hbDRwUILAAUYJQ0b5nM1wY0lMAKdYsdi9rNFgCj8h6x1K353XFrdyq2A8JhIrosSV+Kii440p4ln/VTNkgTWgFtAghAM+qyXsSclpoPZFczIYxTIcuRz+cCBlnN9NyyXuVcYJ23pL12dAoCuwAFI10GUM5trykirgYTNn0fP1vdyOhfbUaBWKgZWXKL6krx3oNE9mIxLpte9o9dfOWOiD+IZEWlKd2ilEFCD67dramukVatgskzFMWmFEKYPlT6eiX9YOnvvvs=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 85b2f7c2-6a39-46a0-69b8-08dc69cc52cd
X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 May 2024 10:49:06.5558
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: HuN5nQU/xiOr2SL1PmtrxIJImljG/cTo2XXhMsnjXl6uXb0shE5xDwVnYFNoFGqUZIW7zyGRXxF9CJ2ndoRCVw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR10MB6836
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1011,Hydra:6.0.650,FMLib:17.11.176.26
 definitions=2024-05-01_10,2024-04-30_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 malwarescore=0
 phishscore=0 spamscore=0 bulkscore=0 suspectscore=0 adultscore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2404010000 definitions=main-2405010076
X-Proofpoint-GUID: jZIMQilDrOGMUVTS6TFK0jYrmKe-hTAw
X-Proofpoint-ORIG-GUID: jZIMQilDrOGMUVTS6TFK0jYrmKe-hTAw

On 01/05/2024 00:35, Dave Chinner wrote:
>>   	return !((pos | len) & mask);
> I think this whole function needs to be rewritten so that
> non-power-of-2 extent sizes are supported on both devices properly.
> 
> 	xfs_extlen_t	fsbs = 1;
> 	u64		bytes;
> 	u32		mod;
> 
> 	if (xfs_inode_has_forcealign(ip))
> 		fsbs = ip->i_extsize;
> 	else if (XFS_IS_REALTIME_INODE(ip))
> 		fsbs = mp->m_sb.sb_rextsize;
> 
> 	bytes = XFS_FSB_TO_B(mp, fsbs);
> 	if (is_power_of_2(fsbs))
> 		return !((pos | len) & (bytes - 1));
> 
> 	div_u64_rem(pos, bytes, &mod);
> 	if (mod)
> 		return false;
> 	div_u64_rem(len, bytes, &mod);
> 	return mod == 0;

ok, but I still have a doubt about non-power-of-2 forcealign extsize 
support.

Thanks,
John