Received: by 2002:ab2:60d1:0:b0:1f7:5705:b850 with SMTP id i17csp386127lqm; Wed, 1 May 2024 03:58:33 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCV5JsH3nHxvCGW2GKsarYtTWvH5kMnrCltMIQEgrVakGA4Hp00CKJF5LzMRypjr3v8NXEcsr9bMBn03BH3F4LUZpWf3BIqvgIPnCcTfyA== X-Google-Smtp-Source: AGHT+IGtcAOiCqEuYOlnZiAsVJcscEgaVf0Mk6wHe2bgWzH8Nt1xYO0Yko9R9mwkpxxv9KYB6MeO X-Received: by 2002:a05:622a:1206:b0:43a:78df:479e with SMTP id y6-20020a05622a120600b0043a78df479emr2249873qtx.63.1714561112722; Wed, 01 May 2024 03:58:32 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1714561112; cv=pass; d=google.com; s=arc-20160816; b=uwBenpn4DbYC4NeVNrkB8heBv4qWb87/Ao/7ukh0EltE1zb32fCB8zf2Hsd1CvmVKu NlZvv8h+TEuHv2wuRC/ag/Xd6kEluAo+IJTGQxG98zQor7ElTTkphtLnA7Y0XdxggqOA PgRCuDNGzWSI4BmWtfTq4n7qhcgF/ta2BvibPelBi7RkN7Z70bvNN4N06uCK00dHrimj A3YY3nZfr/HqitG9xn7pC3s19RW5n5w/pVi3eBr78ZseTAVO8h0YI/258C3Ck2o8YuIv EKIJl206xaQqA+Ij0mLEzqyfReeObsFof8BPQxY+GaeidM6Vp6izcDx2gROTwXz9shV+ b/2g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:list-unsubscribe:list-subscribe :list-id:precedence:dkim-signature; bh=j/Xajgm4NK/lzgqgFTaDH7ZeBAQsVIQsUpgLf7xd+18=; fh=Yko4yEfNvLvw7WbZHl7IzmeaL04OPMgw7V5QjUIpsiI=; b=DonWVVNoyTITUcxbzuqkujevgxWgbVIO+nbmSFhTipU2u1Vnk06KDJF3WIAWbkS6AS JdVG287VbWKpwWO+WDhYaiK7baerJ/WBnHpvlJ+V+FCQdeu/dFAXqPOutjIAeQmAz0Wq OvromLXNaEDSy/p3A5ikBKK718ApxkELro94MGK9P3VoA51D9eraNpoJrqDsUUBR/uHM ZS4TcqA9pOEOXcSRYERBY+jhzqUKgfYxRlRFy6m+dIqNeyZFDju23Ls5Ljah5g6oKoJl +nooIzlWPC3+ImShdXmt/sl3rDdBznoRU2MAakD8cOPozhqzubrbV9uqDuOQaODs66rV 3Caw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=D6rD372u; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com dmarc=pass fromdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-165161-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-165161-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id b6-20020a05620a270600b00791026f6102si4881797qkp.116.2024.05.01.03.58.32 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 May 2024 03:58:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-165161-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=D6rD372u; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com dmarc=pass fromdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-165161-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-165161-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 7565E1C22CFF for ; Wed, 1 May 2024 10:58:32 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6519D56759; Wed, 1 May 2024 10:58:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="D6rD372u" Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2273633CD1; Wed, 1 May 2024 10:58:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.65 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714561104; cv=none; b=XMWOjnl7YN/rSg03HKGsGHNJHV1egGFxqI+avEkjwJg4b8qYGeMI+H/pFQoYnQ0q7IsGF+vpUREXe5paMpemWMITRBp4ECearBcBAfsMhGVLcr6qABjD06yqo1Ew3CkKDSWFmmYENqUXG++Rsb9ojA4KkLAGNLE4jUm0NckK6ks= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714561104; c=relaxed/simple; bh=j/Xajgm4NK/lzgqgFTaDH7ZeBAQsVIQsUpgLf7xd+18=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=CD/z5xlI0pFk19sDJiMMz/jiat45mB8ovNBt9IrZLWgua05dwFDW5SyuxiJWFxo/3omjVKY7QNF1AjvBKGz0Yr5cWwI6FQAAZj2gqdHDipHzgGT5EtsUAH766XHwh9vqOGj99TpGPdGUrw597DG+YOMfQStnvVbeo4l/tu7N4ME= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=D6rD372u; arc=none smtp.client-ip=209.85.221.65 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wr1-f65.google.com with SMTP id ffacd0b85a97d-34d7b0dac54so383507f8f.0; Wed, 01 May 2024 03:58:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1714561101; x=1715165901; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=j/Xajgm4NK/lzgqgFTaDH7ZeBAQsVIQsUpgLf7xd+18=; b=D6rD372uAobSJnckyljWWc4bOJed71WAjo6tB5TaKkWcw8NcWr986Mk745bH15nD2T R5NzIEkLToTr7jtjgVPa79T9OTHIg5kyHWE5S7u+4H229YLLQ2yE/FtQto82YRIQYDZR JqpSpH7kg1zHh5oKITNx44XhDBW1cbWZ7JG6gh00ylXNBQ2+yk8Q/3qxdYTFX3yCeZTd DO0nOJnHoIDhXpGqjO0k7Y3n/BCD4iA+k0l0jChBFpX2CsnN4Hze8VFguiUfdKTB7SVi QEGQ3tsWda/GcUMlrV5g70Biq3rT9jvv6X0T2hOmuG+1PzwFQZCEj1E5uDufVU0pEwTq bI9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714561101; x=1715165901; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=j/Xajgm4NK/lzgqgFTaDH7ZeBAQsVIQsUpgLf7xd+18=; b=fWWB+dh3xGN2ZRfmlESM4v6hl3+DQYT4ewdtlwO5dmjK171wkPHp0GFW4K4RuqpEQm 92M8UC8PS77rbv/BsaLEwjg2IcMnoJGoJy6hVXJNnx2itGDtYlZ/rvbDLb4enFlw6HyL 60QY9WLcWCbE9+WdQvWzE5iy6WAkQrIww9XnQdkQ7wAYRkCdf0YesiJ1+1nDAPC4G3SD cmIsDrYyr2bE0zgPGss8I00mSrcmba8e4yTUGJjR60PSWXYCmOb/JDwwFwZToRSVIkDR KHcbmPXQtQFVoEaL2M53bSFMpmsTmwxEsusXama4C8PKTEe7Gpc1Qy7lsaWUroWJWwMx RTKQ== X-Forwarded-Encrypted: i=1; AJvYcCW0Yp1KEhu/OHfYzCIH8q9zSgbf/zVWeCcK8l31mIcfKxS7bKBj20EYD231W4+b3NZUNsENRaxfmXi/VkGmksscPVd6UiJ7WezUqic6bUFvaNoZmOSpHV3rFLj/OfCUSBqwbcG7Fkov6Q== X-Gm-Message-State: AOJu0YxMAlPcbZUO9MH8uI572Umgs3xsiJ96dxkJxh1owqzzLfsIu0Ff Ipbj1cJzZscWuCYexN/KWijOWGiUwqNh3iyO1PenDXXc37/uQTOG2OJslBJLSdMkD7lpNUEQF9i 6eYjWo/HA0rP7N4FXcAxA/79852s= X-Received: by 2002:adf:f44a:0:b0:34c:c53e:f2ca with SMTP id f10-20020adff44a000000b0034cc53ef2camr2046993wrp.14.1714561101245; Wed, 01 May 2024 03:58:21 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: In-Reply-To: From: Petar Stoykov Date: Wed, 1 May 2024 12:58:10 +0200 Message-ID: Subject: Re: [PATCH v2 0/3] Add support for Sensirion SDP500 To: Krzysztof Kozlowski Cc: linux-iio@vger.kernel.org, Jonathan Cameron , Krzysztof Kozlowski , Lars-Peter Clausen , Rob Herring , Andy Shevchenko , Angel Iglesias , Conor Dooley , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, May 1, 2024 at 11:45=E2=80=AFAM Krzysztof Kozlowski wrote: > > On 30/04/2024 17:27, Petar Stoykov wrote: > > functions in use so it should be fine here too. > > > > All feedback is appreciated! Thank you for taking the time to review th= is. > > > > v1->v2: > > Many fixes suggested by Jonathan Cameron and Krzysztof Kozlowsk. > > No, be specific. What EXACTLY changed. This is way too generic. > Considering entire indentation is broken, I could assume you actually > did not implement feedback. > > Best regards, > Krzysztof > Hi Krzysztof, I'll include all changes in v3 then (or as a response here?). I just thought it was too much to list all changes. And about the indentation, can you elaborate please?