Received-SPF: pass (google.com: domain of linux-kernel+bounces-165198-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Wed, 1 May 2024 04:39:23 -0700
From: Adam Goldman <adamg@pobox.com>
To: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Cc: linux1394-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] firewire: ohci: mask bus reset interrupts between ISR
 and bottom half
Message-ID: <ZjIp68AqHhegFmDv@iguana.24-8.net>
References: <ZfqpJ061hLtPT8XL@iguana.24-8.net>
 <20240325005828.GB21329@workstation.local>
 <20240401121800.GA220025@workstation.local>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240401121800.GA220025@workstation.local>

Hi Takashi,

On Mon, Apr 01, 2024 at 09:18:00PM +0900, Takashi Sakamoto wrote:
> I sent an additional patch[1] to handle the bus-reset event at the first
> time. I'd like you to review and test it as well, especially under your
> environment in which 1394:1995 and 1394a phys exist.
> 
> [1] https://lore.kernel.org/lkml/20240401121200.220013-1-o-takashi@sakamocchi.jp/

I'm sorry for another very late reply.

Now that we eliminated the IRQ storm, it makes sense to always enable 
the bus-reset interrupt at startup. I tested your patch with various 
devices, with a FW800 repeater, with a FW400 hub, without a hub, etc. 
Everything works OK. However, I only tested with XIO2213B OHCI.

-- Adam