Received-SPF: pass (google.com: domain of linux-kernel+bounces-165202-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Precedence: bulk
MIME-Version: 1.0
References: <CADFWO8EQUkGcbE=RXjxXbub2tZge9+ss=gB-Q6wngFAvwFygRg@mail.gmail.com>
 <ZjEQ8LBxftcr0Z0t@smile.fi.intel.com>
In-Reply-To: <ZjEQ8LBxftcr0Z0t@smile.fi.intel.com>
From: Petar Stoykov <pd.pstoykov@gmail.com>
Date: Wed, 1 May 2024 13:48:24 +0200
Message-ID: <CADFWO8HL_pwEQwYn0K9AkPV=HZyWN3NSOs8k4dRrB40w_1KdCw@mail.gmail.com>
Subject: Re: [PATCH v2 2/3] iio: pressure: Add driver for Sensirion SDP500
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-iio@vger.kernel.org, Jonathan Cameron <jic23@kernel.org>, 
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Lars-Peter Clausen <lars@metafoo.de>, 
	Rob Herring <robh+dt@kernel.org>, Angel Iglesias <ang.iglesiasg@gmail.com>, 
	Conor Dooley <conor+dt@kernel.org>, linux-kernel@vger.kernel.org, 
	devicetree@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, Apr 30, 2024 at 5:40=E2=80=AFPM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> On Tue, Apr 30, 2024 at 05:27:24PM +0200, Petar Stoykov wrote:
> > From 6ae7537517f551540121ca6fb3b99080b7580410 Mon Sep 17 00:00:00 2001
> > From: Petar Stoykov <pd.pstoykov@gmail.com>
> > Date: Mon, 15 Jan 2024 12:21:26 +0100
> > Subject: [PATCH 2/3] iio: pressure: Add driver for Sensirion SDP500
> >
> > Sensirion SDP500 is a digital differential pressure sensor. The sensor =
is
> > accessed over I2C.
>
> Any Datasheet: tag can be added?
>

Ok. I see some drivers also include the pdf link in the driver's code.
I can do that as well.

> ...
>
> > +config SDP500
> > +    tristate "Sensirion SDP500 differential pressure sensor I2C driver=
"
> > +    depends on I2C
> > +    help
> > +      Say Y here to build support for Sensirion SDP500 differential pr=
essure
> > +      sensor I2C driver.
> > +      To compile this driver as a module, choose M here: the core modu=
le
> > +      will be called sdp500.
>
> You patch is broken. Fix the way how you send patches.
>
> ...
>
> > +static int sdp500_start_measurement(struct sdp500_data *data, const
> > struct iio_dev *indio_dev)
>
> Here is more visible.
>
> --
> With Best Regards,
> Andy Shevchenko
>
>

I finally figured it out. Gmail has a hard word-wrap at 80 characters per l=
ine.
At first I thought it was word-wrap on the receiving side but I was wrong.
I will try to convince IT to change things so I can use b4 or git send e-ma=
il.
If that doesn't work then I guess my code will have shorter lines in next p=
atch.