Received-SPF: pass (google.com: domain of linux-kernel+bounces-165207-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Wed, 1 May 2024 14:55:59 +0300
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
Cc: linux-media@vger.kernel.org,
	Florian Fainelli <florian.fainelli@broadcom.com>,
	Ray Jui <rjui@broadcom.com>, Scott Branden <sbranden@broadcom.com>,
	Broadcom internal kernel review list <bcm-kernel-feedback-list@broadcom.com>,
	Naushir Patuck <naush@raspberrypi.com>,
	Dave Stevenson <dave.stevenson@raspberrypi.com>,
	Sakari Ailus <sakari.ailus@linux.intel.com>,
	linux-rpi-kernel@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] media: bcm2835-unicam: Include v4l2-subdev.h
Message-ID: <20240501115559.GI17852@pendragon.ideasonboard.com>
References: <20240430213146.23187-1-laurent.pinchart@ideasonboard.com>
 <20240430213633.23767-1-laurent.pinchart@ideasonboard.com>
 <20240430213633.23767-2-laurent.pinchart@ideasonboard.com>
 <CAPybu_2xjWg8sUW9jk7n1UXLTsoGXfftxVqLaZcWzn+ZcCRhOg@mail.gmail.com>
 <20240501114715.GG17852@pendragon.ideasonboard.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20240501114715.GG17852@pendragon.ideasonboard.com>

On Wed, May 01, 2024 at 02:47:15PM +0300, Laurent Pinchart wrote:
> On Wed, May 01, 2024 at 01:07:29PM +0200, Ricardo Ribalda Delgado wrote:
> > Hi Laurent
> > 
> > I have to send a v2 of
> > https://patchwork.linuxtv.org/project/linux-media/list/?series=12759 I
> > can include this patch in that set if you want
> 
> Fine with me.

Assuming your v2 will be merged in v6.10.

> > On Tue, Apr 30, 2024 at 11:39 PM Laurent Pinchart wrote:
> > >
> > > The unicam driver uses the v4l2_subdev structure. Include the
> > > corresponding header instead of relying on indirect includes.
> > >
> > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > > Reported-by: kernel test robot <lkp@intel.com>
> > Reviewed-by: Ricardo Ribalda <ribalda@chromium.org>
> > > Closes: https://lore.kernel.org/oe-kbuild-all/202404302324.8aTC84kE-lkp@intel.com/
> > > ---
> > >  drivers/media/platform/broadcom/bcm2835-unicam.c | 1 +
> > >  1 file changed, 1 insertion(+)
> > >
> > > diff --git a/drivers/media/platform/broadcom/bcm2835-unicam.c b/drivers/media/platform/broadcom/bcm2835-unicam.c
> > > index c590e26fe2cf..3c7878d8d79b 100644
> > > --- a/drivers/media/platform/broadcom/bcm2835-unicam.c
> > > +++ b/drivers/media/platform/broadcom/bcm2835-unicam.c
> > > @@ -55,6 +55,7 @@
> > >  #include <media/v4l2-ioctl.h>
> > >  #include <media/v4l2-fwnode.h>
> > >  #include <media/v4l2-mc.h>
> > > +#include <media/v4l2-subdev.h>
> > >  #include <media/videobuf2-dma-contig.h>
> > >
> > >  #include "bcm2835-unicam-regs.h"

-- 
Regards,

Laurent Pinchart