Received-SPF: pass (google.com: domain of linux-kernel+bounces-165208-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Wed, 1 May 2024 08:02:05 -0400
From: Johannes Weiner <hannes@cmpxchg.org>
To: Usama Arif <usamaarif642@gmail.com>
Cc: tj@kernel.org, lizefan.x@bytedance.com, nphamcs@gmail.com,
	corbet@lwn.net, linux-mm@kvack.org, cgroups@vger.kernel.org,
	linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
	kernel-team@meta.com
Subject: Re: [PATCH] cgroup: Add documentation for missing zswap memory.stat
Message-ID: <20240501120205.GB2538005@cmpxchg.org>
References: <20240501095349.1407643-1-usamaarif642@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240501095349.1407643-1-usamaarif642@gmail.com>

On Wed, May 01, 2024 at 10:53:49AM +0100, Usama Arif wrote:
> This includes zswpin, zswpout and zswpwb.

Good idea adding these!

> Signed-off-by: Usama Arif <usamaarif642@gmail.com>
> ---
>  Documentation/admin-guide/cgroup-v2.rst | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/Documentation/admin-guide/cgroup-v2.rst b/Documentation/admin-guide/cgroup-v2.rst
> index 17e6e9565156..48ec54627814 100644
> --- a/Documentation/admin-guide/cgroup-v2.rst
> +++ b/Documentation/admin-guide/cgroup-v2.rst
> @@ -1454,6 +1454,15 @@ PAGE_SIZE multiple when read back.
>  	  zswapped
>  		Amount of application memory swapped out to zswap.
>  
> +	  zswpin
> +		Number of pages moved in to memory from zswap.
> +
> +	  zswpout
> +		Number of pages moved out of memory to zswap.
> +
> +	  zswpwb
> +		Number of pages written from zswap to swap.
> +

They should go between pglazyfreed and thp_fault_alloc to match the
output ordering (they're event counters, not memory counters).

>  	  file_mapped
>  		Amount of cached filesystem data mapped with mmap()
>