Received-SPF: pass (google.com: domain of linux-kernel+bounces-165214-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
From: Peng Fan <peng.fan@nxp.com>
To: Cristian Marussi <cristian.marussi@arm.com>
CC: Rob Herring <robh@kernel.org>, "Peng Fan (OSS)" <peng.fan@oss.nxp.com>,
	Linus Walleij <linus.walleij@linaro.org>, Krzysztof Kozlowski
	<krzk+dt@kernel.org>, Conor Dooley <conor+dt@kernel.org>, Shawn Guo
	<shawnguo@kernel.org>, Sascha Hauer <s.hauer@pengutronix.de>, Pengutronix
 Kernel Team <kernel@pengutronix.de>, Fabio Estevam <festevam@gmail.com>, Peng
 Fan <peng.fan@arm.com>, Sudeep Holla <sudeep.holla@arm.com>,
	"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"imx@lists.linux.dev" <imx@lists.linux.dev>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v2 1/2] dt-bindings: firmware: arm,scmi: Add properties
 for i.MX95 Pinctrl OEM extensions
Thread-Topic: [PATCH v2 1/2] dt-bindings: firmware: arm,scmi: Add properties
 for i.MX95 Pinctrl OEM extensions
Thread-Index: AQHakTp0F0gZzKwEJ0KLehvuXBXWtLF32SuAgADPKOCACauUAIAAClDg
Date: Wed, 1 May 2024 12:11:41 +0000
Message-ID:
 <DU0PR04MB9417B9CD74A1E15F2515ECA588192@DU0PR04MB9417.eurprd04.prod.outlook.com>
References: <20240418-pinctrl-scmi-oem-v1-v2-0-3a555a3c58c3@nxp.com>
 <20240418-pinctrl-scmi-oem-v1-v2-1-3a555a3c58c3@nxp.com>
 <20240424193007.GA329896-robh@kernel.org>
 <DU0PR04MB9417C67342B1DD6CC299B4CE88172@DU0PR04MB9417.eurprd04.prod.outlook.com>
 <ZjIoMJOAxtC-nkZO@pluto>
In-Reply-To: <ZjIoMJOAxtC-nkZO@pluto>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?rIp8JMg+5xUk+YNLUP3cY57KUTJTYqxwxnX2ZL3keINrXdYJScpApcUsxLFi?=
 =?us-ascii?Q?UxZeN4KAxlhy93HyQZln/SzcwZfJ36zra4LPOSqtpAbdsvuTmRCCKJWFL2or?=
 =?us-ascii?Q?WlmH9KGWwZM+v1EA8PNnXNBbwbw4NBEtRwCB0rj9H9+lrmPhrJxOvZRFndvR?=
 =?us-ascii?Q?Giij/JhancQkTH3yrXUqQ/twtxR73e+yQ0csw7OhsFMvcPx9+sP67uAYsKA5?=
 =?us-ascii?Q?51siz+fDzgvbAIJveiDHBm7iwgnG00N79M0+Wt2J8DRztB7Ga9yWP5e4GLhO?=
 =?us-ascii?Q?rCsHr2vnpJQ1rPBT41vOxj1m1EVZyaBr1tL/Gb9Z6l/AgkZUydma8A/it7MV?=
 =?us-ascii?Q?N5jujyyMxfNJiWUsRoPZJCdxu1EN/ghXBvN/SF3OjYJKrGSkiOLSD2RhfO+K?=
 =?us-ascii?Q?32D+HKvAYaWKvbEAkGBHENitDzrkAPfHaIuTXR5YSVOrE2rK1pwLkYeSVmXM?=
 =?us-ascii?Q?f94yhgcQJ5iXy5OHL+iVqAcLTiSNsdp3S7zA6fDI/ZRkSAE/d3jm0tOY6SDN?=
 =?us-ascii?Q?T+bSadR1DiNJOu2QO3gVHyJEwq5llSYHIXtk8R7IjIpe/9NwSKa6TeiGuv1W?=
 =?us-ascii?Q?+EMdbNx0XSNtNDGDDrAeFEo0idWSoN6J96W0CYHND4ohZqzU7FM3q4WEj0MA?=
 =?us-ascii?Q?+m0GplkNfeT/pWFhii5yimz6l8qRpygtEFWL9uAR9UFP11wZTY3bYWVKyMs4?=
 =?us-ascii?Q?nmgem03A/gpzlF5wE1Hm0Hwy0Z9sewxpeSIKjx9tTPzOTywjQT+Tyt3naQos?=
 =?us-ascii?Q?juh+Ldkv4hEQfMITt01gI6cXcna1tMVzJftsAj0mhuSvRegvIy12RgNCu0Lx?=
 =?us-ascii?Q?hTnVnKwiZn64CRXNJaa/nJHpgbAxgvBg4YJv6CGZwKmwTGxKTmy3JftE44D7?=
 =?us-ascii?Q?+00J3rh/75/MQx9yElAN1vHryqivAKHjWf67cTjWptjmiOw61ypZ51/B3nAv?=
 =?us-ascii?Q?2vF5OOhd840EFk1i7w/dbNjnKIgyFo07AZ4YttWB9RWJbVufOAFGWo6iyEWN?=
 =?us-ascii?Q?d6EJ61vmP7RWMrofAlTf99j52UuZdP7ooycKxGRcSy1bN9t5PGpVHw/VGyW9?=
 =?us-ascii?Q?0HrrDqndds2NwcbwGrtre1KwFfyEy0XUcK46N5J2QY82VNeG+4QnxJ/iuplh?=
 =?us-ascii?Q?RHJ3pTxWzAZTUhgxXwdYU8gzZC6RlT+Aq6yr/2TAvi0lm6IF10OpngHXxFIY?=
 =?us-ascii?Q?xE6sFmEjy8mrFdVo7PUjGIP4orPnSfIPzu8HiA+ce7EQ5czwdRq2XFf4ie/b?=
 =?us-ascii?Q?eCRsgryiLLpbBCHMtlPF5Y+zMkL4k8t4VVpPH9gQB1oO2UCErcrkgjgzV9dQ?=
 =?us-ascii?Q?CojhD7Po3pHxdCNMK2q2Zc+LHUz/Chi+YZ0jnUrWouAlvCyF4RAqe/E0Togh?=
 =?us-ascii?Q?44LYcr0UZh6WwQjGWbf/J0KAgct37UvsnuSFXp6GHwRvuE9LQNLh7qU9CapS?=
 =?us-ascii?Q?ULAae5lgR60Ueg8Wsx/JsFhob/c3EngDePR0I5Geg283h626C8rbWa+rxpZH?=
 =?us-ascii?Q?1rVwBBjJkPLToGeRVlIKzX5v/iqtHG0fmpc5dVRCJ12JY6q4quXleWiu4PQE?=
 =?us-ascii?Q?wWhAcWwp5VyWpv6TMs0=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2fd3d8ac-752e-4d4c-be1c-08dc69d7dc9a
X-MS-Exchange-CrossTenant-originalarrivaltime: 01 May 2024 12:11:41.9645
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: qwvfVEygf4zoFMoKAtj/uhWYsvorI6u+0VXT8K6pl0MdKxWyYJ6AcVb/5N4j4Dmby2wk5ibzChoHFS3OMKREhQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8930

> Subject: Re: [PATCH v2 1/2] dt-bindings: firmware: arm,scmi: Add properti=
es
> for i.MX95 Pinctrl OEM extensions
>=20
> On Thu, Apr 25, 2024 at 09:06:00AM +0000, Peng Fan wrote:
> > Hi Rob,
> >
> > > Subject: Re: [PATCH v2 1/2] dt-bindings: firmware: arm,scmi: Add
> > > properties for i.MX95 Pinctrl OEM extensions
> > >
> > > On Thu, Apr 18, 2024 at 10:53:17AM +0800, Peng Fan (OSS) wrote:
> > > > From: Peng Fan <peng.fan@nxp.com>
> > > >
> > > > i.MX95 Pinctrl is managed by SCMI firmware using OEM extensions.
> > > > This patch is to add i.MX95 Pinctrl OEM extensions properties.
> > > >
> > > > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > > > ---
> > > >  .../devicetree/bindings/firmware/arm,scmi.yaml     |  9 ++-
> > > >  .../bindings/firmware/nxp,imx95-scmi-pinctrl.yaml  | 66
> > > > ++++++++++++++++++++++
> > > >  2 files changed, 72 insertions(+), 3 deletions(-)
> > > >
> > > > diff --git
> > > > a/Documentation/devicetree/bindings/firmware/arm,scmi.yaml
> > > > b/Documentation/devicetree/bindings/firmware/arm,scmi.yaml
> >
> > ....
> >
> > > > +
> > > > +title: i.MX System Control and Management Interface (SCMI)
> > > > +Pinctrl Protocol
> > > > +
> > > > +maintainers:
> > > > +  - Peng Fan <peng.fan@arm.com>
> > > > +
> > > > +patternProperties:
> > > > +  '[a-f0-9]+$':
> > > > +    type: object
> > > > +    unevaluatedProperties: false
> > > > +
> > > > +    properties:
> > > > +      pins:
> > > > +        $ref: /schemas/types.yaml#/definitions/string
> > > > +        description: name of the pin
> > > > +        items:
> > > > +          enum: [ daptdi, daptmsswdio, daptclkswclk, daptdotracesw=
o,
> > > > +                  gpioio00, gpioio01, gpioio02, gpioio03,
> > > > + gpioio04,
> > >
> > > ioio?
> >
> > Yes. The name is exported from SCMI firmware.
> >
> > >
> > > > +                  gpioio05, gpioio06, gpioio07, gpioio08, gpioio09=
,
> > > > +                  gpioio10, gpioio11, gpioio12, gpioio13, gpioio14=
,
> > > > +                  gpioio15, gpioio16, gpioio17, gpioio18, gpioio19=
,
> > > > +                  gpioio20, gpioio21, gpioio22, gpioio23, gpioio24=
,
> > > > +                  gpioio25, gpioio26, gpioio27, gpioio28, gpioio29=
,
> > > > +                  gpioio30, gpioio31, gpioio32, gpioio33, gpioio34=
,
> > > > +                  gpioio35, gpioio36, gpioio37, ccmclko1, ccmclko2=
,
> > > > +                  ccmclko3, ccmclko4, enet1mdc, enet1mdio, enet1td=
3,
> > > > +                  enet1td2, enet1td1, enet1td0, enet1txctl, enet1t=
xc,
> > > > +                  enet1rxctl, enet1rxc, enet1rd0, enet1rd1, enet1r=
d2,
> > > > +                  enet1rd3, enet2mdc, enet2mdio, enet2td3, enet2td=
2,
> > > > +                  enet2td1, enet2td0, enet2txctl, enet2txc, enet2r=
xctl,
> > > > +                  enet2rxc, enet2rd0, enet2rd1, enet2rd2, enet2rd3=
,
> > > > +                  sd1clk, sd1cmd, sd1data0, sd1data1, sd1data2, sd=
1data3,
> > > > +                  sd1data4, sd1data5, sd1data6, sd1data7, sd1strob=
e,
> > > > +                  sd2vselect, sd3clk, sd3cmd, sd3data0, sd3data1,
> > > > +                  sd3data2, sd3data3, xspi1data0, xspi1data1, xspi=
1data2,
> > > > +                  xspi1data3, xspi1data4, xspi1data5, xspi1data6,
> > > > +                  xspi1data7, xspi1dqs, xspi1sclk, xspi1ss0b, xspi=
1ss1b,
> > > > +                  sd2cdb, sd2clk, sd2cmd, sd2data0, sd2data1, sd2d=
ata2,
> > > > +                  sd2data3, sd2resetb, i2c1scl, i2c1sda, i2c2scl, =
i2c2sda,
> > > > +                  uart1rxd, uart1txd, uart2rxd, uart2txd, pdmclk,
> > > > +                  pdmbitstream0, pdmbitstream1, sai1txfs, sai1txc,
> > > > +                  sai1txd0, sai1rxd0, wdogany, fccuerr0 ]
> > > > +
> > > > +      nxp,func-id:
> > > > +        $ref: /schemas/types.yaml#/definitions/uint32
> > > > +        description: Indicates the PAD connections which function
> > > > + module
> > >
> > > The description makes no sense...
> >
> > I will use below description in v3:
> > For each pin, there are up to 8 muxing options (called ALT modes). For
> example:
> > Select 1 of 5 iomux modes to be used for pad: DAP_TCLK_SWCLK.
> > 000b - Select mux mode: ALT0 mux port: JTAG_MUX_TCK of instance:
> > jtag_mux 010b - Select mux mode: ALT2 mux port: CAN4_RX of instance:
> > imx95_wakeupmix_top 100b - Select mux mode: ALT4 mux port:
> > FLEXIO1_FLEXIO30 of instance: imx95_wakeupmix_top 101b - Select mux
> > mode: ALT5 mux port: GPIO3_IO30 of instance: imx95_wakeupmix_top
> 110b
> > - Select mux mode: ALT6 mux port: LPUART5_CTS_B of instance:
> imx95_wakeupmix_top The nxp,func-id property is selecting one ALT mode.
> >
> > >
> > > > +
> > > > +      nxp,pin-conf:
> > > > +        $ref: /schemas/types.yaml#/definitions/uint32
> > > > +        description: The PAD configuration
> > >
> > > PAD stands for? Or is it pin configuration as the property name says?
> >
> > It is pin configuration which includes pull up/down, drive strength and=
 etc.
> >
> > >
> > > This is just a raw register values?
> >
> > Yes.
> >
> > Why can't standard pinctrl properties be
> > > used here. What's the point of using SCMI pinctrl if you are just
> > > shuttling register values to SCMI?
> >
> > Standard pinctrl properties will need more memory in our SCMI firmware
> > design. We have limited on-chip memory for SCMI firmware usage.
> >
>=20
> So you sort of strip-down the server due to hw constraints, but is it the=
 SCMI
> server still compliant with the spec ? (as in supporting all the mandator=
y
> commands and features for the protocols you decided to
> support)

Yes, the SCMI server is compliant with the spec. It is the SCMI firmware
returns num function with value zero, num group with value zero.

And only OEM pin configure type supported in our SCMI firmware.

I have posted out v3 following Rob's suggestion, using property
'pinmux', but now we could not reuse pinctrl-scmi.c

Thanks,
Peng.

>=20
> Thanks,
> Cristian