Received-SPF: pass (google.com: domain of linux-kernel+bounces-165270-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
Date: Wed, 01 May 2024 20:56:00 +0800
Subject: [PATCH 02/21] pinctrl: tegra: Use scope based of_node_put()
 cleanups
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Message-Id: <20240501-pinctrl-cleanup-v1-2-797ceca46e5c@nxp.com>
References: <20240501-pinctrl-cleanup-v1-0-797ceca46e5c@nxp.com>
In-Reply-To: <20240501-pinctrl-cleanup-v1-0-797ceca46e5c@nxp.com>
To: Linus Walleij <linus.walleij@linaro.org>, 
 Thierry Reding <thierry.reding@gmail.com>, 
 Jonathan Hunter <jonathanh@nvidia.com>, Dvorkin Dmitry <dvorkin@tibbo.com>, 
 Wells Lu <wellslutw@gmail.com>, Maxime Coquelin <mcoquelin.stm32@gmail.com>, 
 Alexandre Torgue <alexandre.torgue@foss.st.com>, 
 Emil Renner Berthing <kernel@esmil.dk>, 
 Jianlong Huang <jianlong.huang@starfivetech.com>, 
 Hal Feng <hal.feng@starfivetech.com>, Orson Zhai <orsonzhai@gmail.com>, 
 Baolin Wang <baolin.wang@linux.alibaba.com>, 
 Chunyan Zhang <zhang.lyra@gmail.com>, Viresh Kumar <vireshk@kernel.org>, 
 Shiraz Hashim <shiraz.linux.kernel@gmail.com>, soc@kernel.org, 
 Krzysztof Kozlowski <krzk@kernel.org>, 
 Sylwester Nawrocki <s.nawrocki@samsung.com>, 
 Alim Akhtar <alim.akhtar@samsung.com>, 
 Geert Uytterhoeven <geert+renesas@glider.be>, 
 Patrice Chotard <patrice.chotard@foss.st.com>, 
 Heiko Stuebner <heiko@sntech.de>, Damien Le Moal <dlemoal@kernel.org>, 
 Ludovic Desroches <ludovic.desroches@microchip.com>, 
 Nicolas Ferre <nicolas.ferre@microchip.com>, 
 Alexandre Belloni <alexandre.belloni@bootlin.com>, 
 Claudiu Beznea <claudiu.beznea@tuxon.dev>, 
 Dong Aisheng <aisheng.dong@nxp.com>, Fabio Estevam <festevam@gmail.com>, 
 Shawn Guo <shawnguo@kernel.org>, Jacky Bai <ping.bai@nxp.com>, 
 Pengutronix Kernel Team <kernel@pengutronix.de>, 
 Chester Lin <chester62515@gmail.com>, Matthias Brugger <mbrugger@suse.com>, 
 Ghennadi Procopciuc <ghennadi.procopciuc@oss.nxp.com>, 
 Sean Wang <sean.wang@kernel.org>, Matthias Brugger <matthias.bgg@gmail.com>, 
 AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>, 
 Sascha Hauer <s.hauer@pengutronix.de>, 
 Andrew Jeffery <andrew@codeconstruct.com.au>, Joel Stanley <joel@jms.id.au>, 
 Dan Carpenter <dan.carpenter@linaro.org>
Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, 
 linux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org, 
 linux-stm32@st-md-mailman.stormreply.com, linux-samsung-soc@vger.kernel.org, 
 linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, 
 linux-riscv@lists.infradead.org, linux-mediatek@lists.infradead.org, 
 imx@lists.linux.dev, linux-aspeed@lists.ozlabs.org, 
 openbmc@lists.ozlabs.org, Peng Fan <peng.fan@nxp.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: DU0PR04MB9417:EE_|DB9PR04MB9284:EE_
X-MS-Office365-Filtering-Correlation-Id: cb754a66-66c0-4c35-06b2-08dc69dd0f54
X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam:
	BCL:0;ARA:13230031|1800799015|376005|52116005|7416005|366007|38350700005|921011;
X-Microsoft-Antispam-Message-Info:
	=?utf-8?B?STVPWXpXTnlCVEdMaFEwcUkxMnE4K0FzQ3hkaWdZL0tMeHh1S2hRMnl1WmFn?=
 =?utf-8?B?MjVHWHcwWFNPeUFtRnY5U1VyY2R6MnM0R2VaMEZSWEQwbXdibXNXUjlMSWl0?=
 =?utf-8?B?MmtjZGFwbHBkT0RISGc0aXlvTXFQNkU0QlJhTUk0Z2RzRVJRdDhaRHZYRGEx?=
 =?utf-8?B?NFp0bE9icWh4dnV3YnhYMktWOHNIOElqRDNIcVd2Z0ZVUDRpanM5cWpyZHIz?=
 =?utf-8?B?WERqa2c2dCszcE5aV254eDl0U2xKMmhWSlEwUFVYVFFOaWc1NSt3eDhZak9y?=
 =?utf-8?B?djNzaWNrMGhEa3dUeXVidFp5ditiY3VOTTdEQ0hUWmdlTi9uMzY0MTZxZFJa?=
 =?utf-8?B?dTd6ek9rZFFqT2p5ek1tTkVtWk9OS3V4ZmlrRXFtWlh6b1RHNmRsdGVEeHZE?=
 =?utf-8?B?YXpPY3VBcWpIeG1FQTBIRHJRS3Q4NHhaYXYvQmFCUURCVFIrQzZwZE94aXFs?=
 =?utf-8?B?WXh6VjU4Vk1EbGk5RUFIQjR3V2ZoS2FJSXdEeDBXZWwxL2tHYzVaVUY0b3pX?=
 =?utf-8?B?TWttNG9PYVR3QkpRZUNwSzZsYjFrWWdHWnJZajFDaFpldzNwcXB0Ry9kSXo4?=
 =?utf-8?B?dVFJTmVPSjN2VEpnbWRSM0dKMlppaHFCTUMweFl1WXdqWXJKK0hJMUREK1A3?=
 =?utf-8?B?ZzlUVjN2QWpwbS8yUFRQRHRKN1E1KzkyNTd2c3BJdVZRMURicy9qaEVVbWRW?=
 =?utf-8?B?U0JkOGxmZW02UjVFb1pDaFJnWDdEV21MZXZNdHhCRTM1bHJNdS90bE1WOXRF?=
 =?utf-8?B?bnlnRnZCQUFvMzNmaUhvU3NCRzBIZ2pxdHRrUVlJcU9IVEx3NS9WYVJMMkZC?=
 =?utf-8?B?RTNTaFJKVUhOZ0RCT2VHamd1S3ZHbDVrMHhpdzYvZ1NrbTJ2eUdjUFJGTWF0?=
 =?utf-8?B?S2NnZEl0d3l2Tk1vMitkV0FlYWl4aGxsY3d4ZEUzc1RqdDRUam43d1NpclY5?=
 =?utf-8?B?Ti9pcnhPbUVUcFRUbkkvMTN0bzVIUi9IQU1WdmlZWkhCMTJmdWZhTUlNcUtk?=
 =?utf-8?B?YncrK3ROZlNNa3laa2tXOWd5WUg0MHlVRDRVZ2dQZnhOZVlFUjlzY0tQWTcv?=
 =?utf-8?B?bFNPTENPR0JXZ0FPd2dkQmpTakpxQmZod1h3VmtLMmFJMEgwZEhka2tYNWtj?=
 =?utf-8?B?VjFCQjdhUzNNcE1ISzJnTkI2S0d1VFFiVHJpUDlVT3dXK0psRXFlVVZ6ZXpE?=
 =?utf-8?B?WDVBZ1V4Ni9aMFN2LzlabW1vZjIwL1A4TEZnUFpDQWI0T2tFU2wvOVpWUmRu?=
 =?utf-8?B?NmRaRzdZOCtSTkIzalNmRVdYN05jNFh1aVVoVU4vZnR4cjJ2eTJHR0xSN05G?=
 =?utf-8?B?cVBLZXllSmdnc1pUS2wwY2hyTXpXYjZiNVpJd0tXYmZhRHVQdVd0NTE1TkxT?=
 =?utf-8?B?NHlDbjRtenA0MWU5eG5XellkVEdzY0VaV3VtN1prTzQ3WUl2b2tOamREV2pS?=
 =?utf-8?B?VGZ1YlIwS0hCNEVpTTdFOSt1Q0ZjZFhabDI3clViTW5LOVV6d09hRy9FOGZR?=
 =?utf-8?B?ZW1Kc1VCeFpCaHdQN2JVdFlWNUh0ZGxENXFsVmlWMWtQMktCbnlyRWNBeHBN?=
 =?utf-8?B?MCtHNUhIV1NIMmdpMHRkNmhPZGdXRU13LzVKODd2VVBwbjhrUjFqaFNDNVli?=
 =?utf-8?B?SUhkYWJvZENXZDFCcDNVUXFIaTM4RWJxZEVNRFUrOGhFTFhvbmlVVXpxVW5r?=
 =?utf-8?B?TFVHU2FMTWtreW9XK2tId0NRZ0FtR0MvaE5IcjF5VHJTN0RSdXJ2TkxxajVZ?=
 =?utf-8?B?OFBqTTZCczRBUXZVUVE5NlZaUkJEWUNzQ0pReGtTcUxBaWVlM1pMZ1VSOHpK?=
 =?utf-8?Q?NBHyk/BdX144Jr7lIO319PH2tblDoxpvagH34=3D?=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR04MB9417.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(1800799015)(376005)(52116005)(7416005)(366007)(38350700005)(921011);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?bG5VTTNkRTRsaTRYbWFoYlJjVVR4RHgxYlJEV2VQMzMwYVk2cU1ZQm9IZENu?=
 =?utf-8?B?aEdTaC9qcnJOczhqb2F6NC9nenY2SjliRGpwSEVweTZOZTJGYXVYM0xZK2pL?=
 =?utf-8?B?S1p4NGgrOG5pRjNiTE82cjdCSkhWNE9aWEt4TWVqR0xnbEhkb21jMHUzQ0g3?=
 =?utf-8?B?TnVhcEFnQ1Q4ZGZZd0VYSTJkUHdneXBHS0tLNzA4bWxaeERVczEzV05pdFlI?=
 =?utf-8?B?VllFUXBxU1I5cDQxRS9PQy9Hemc5QW1wWU93b1drL1JHWmpLRC9OQ3VlUzdx?=
 =?utf-8?B?UmJCWUdsUk5LM3ZvMDNxeHZiNThnaHQySlY5MTZFbGVmUUhtOEJkck1jSktM?=
 =?utf-8?B?MTFTMkROTmw5MFpnVWI0V29IN28yUnNRZzh4Mm1NRlp6ZnpSdlJRQndNTzhq?=
 =?utf-8?B?eTBsSnFxYUg4S3BWSFZnT1VscURCZ3Q3MDdjNGRYVU9rWnBoRzZZV2VqTXJL?=
 =?utf-8?B?ZGYxSG9HSUd0R3ZIVUZLc0xFYkxMOGw0ZjcrS0lJMjJzbXJMRGdpZzcramM0?=
 =?utf-8?B?L203SHJ6T3FIZ1U3N09jWGk0cVgxSzVTajhic1UyVzdVQWE4Z0RJZlZreFRr?=
 =?utf-8?B?cUtEODhsN3k1c0RNSkdTcEFzanFhUFZ4R0pQZ1hzRElEeXFPUXIrN0Q5M3Vs?=
 =?utf-8?B?QVJibGpUTTNNT21COWtEVmV3aXdZS2NUUFNnLytoM0VVeEdFMjlQT256YXhi?=
 =?utf-8?B?d1hkalJuVlo1dmoycmZacUpFM05icktxUkVkOXlPYTdjcFB2U2IxNDFRaHRB?=
 =?utf-8?B?cHdyMjlBaXcvYmxPaUVMSTk4bCtlZUZQUGlmN3V6dWNpY1BRRDhUd0toOGZ1?=
 =?utf-8?B?dVh6dURtenVYY21ycUJXQkpwQlBnMDJiVno2M3A2NDNUeDU3SkxwcDVDdE03?=
 =?utf-8?B?ZzdsSGRMdkJGU01VMFRKV1FQWFdGbHUwOHBBSzFsOWJNNCtUeG9CZnJtZGRU?=
 =?utf-8?B?cnlMT0FYY3kxc3lMZURydEdLQ3ZtakpXbnFuVCswaUhpQ0hFV0Z5eDZrQTQz?=
 =?utf-8?B?N285Ky9USXpscE9mcS9wMzFtbjh1MHdZcXFHZWJQMWRsclJjUTFrWWo1azJT?=
 =?utf-8?B?QkcxMHFVM2VVMDNsb0xWTkliNUNiTEcwMXFXYzNoeHZFL2lGWWJyMC85RFdT?=
 =?utf-8?B?cGVCSk9qdHdMbkk3bHdKZmFqRFovQURLVlhEREZ2RUF6UnRwOHErUkFtWGt4?=
 =?utf-8?B?WmhYcFFCN0NOWWc2WjJDNUxnK0g5R3VMd3h3VHEvYUZobCtDZm1TM0hzdDJB?=
 =?utf-8?B?OFgrcHRSd1lvc3hWQ1pHSndjRnJTSW5udHBYTHF5bTV1MmluK1NVOXoyZmxM?=
 =?utf-8?B?cFBBMThMcFJtQTRiUVdXYXlHd2VtQS9vR1FPU1Z5MC9JM0ZrRTBRV05TNkFT?=
 =?utf-8?B?MHpsT0l1N2ZENGZIQ2JFZ0JpTVA3OUo5WEp3QUF3MXo0YzNHTVdIbmNMNCta?=
 =?utf-8?B?M05kVTlYR0FGdWdPZ1l2ekpkV2YzZWxxOENMZzZMQlhTT1RjWENtdDlHQzJD?=
 =?utf-8?B?UFE3OGRkcmI4Ujc1ZzNhUmhhNWgzZDVLSS9ka2dKeW1BQUhsTXFqN0l3WkZX?=
 =?utf-8?B?YmtobEZTSTJYVFRmajhTUCs5bUlkWWxXVlZXUElZWjllYk5mYTZ0N2RudVps?=
 =?utf-8?B?RUNSaXB6MVg1VGQ3QTVmK1lLc2ZCaVlFbU1yaXZ2NWZGNEJ2QUE5eFJWb2pX?=
 =?utf-8?B?N1ZpMFRyMm5NZ1N1QTJtVzJhY1B6SWtHMk13UGxqUHo4N1BBTlVFTm9IOEds?=
 =?utf-8?B?bWZoZlNRQTlNeFgxV05mOUJ4V0JnTjAyekFSQjQ1T2t2NnJDZVhVaDFRMTE4?=
 =?utf-8?B?c3lJeWorYkxwcXlXd0dsQ2VKZ0hWQlo0YnpyMVpMRUx0TFgwa3RBM0xNN2RB?=
 =?utf-8?B?bW1paU5USVFGSWpiWXZZTDFNTStEMUpMbk9zRWt0SXdOOXZjZHNiNTZlYmZV?=
 =?utf-8?B?RW82NEFscWQrc0RZbElRTmRCUGVtaU1ocFVIank5aEk2ZTExOFlNa1g5bGg5?=
 =?utf-8?B?NER6Si9EY0Fod215WUd0K1FJbHl3RHNDdUxYalZBdHhWUjRQMkJabFZKTlIz?=
 =?utf-8?B?RS9lOGtUeWlMQWk5ZWJucTZ1R254SWtoYmE5Ri96ckFvUWFIaWZSTWZFa0Ra?=
 =?utf-8?Q?VjjTG4PhdTvwTPBK9XJROdLxE?=
X-OriginatorOrg: oss.nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cb754a66-66c0-4c35-06b2-08dc69dd0f54
X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 May 2024 12:48:54.6730
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: FT/DQq33uv22k5h2D/q7d0r+R/Pqjofvm3IEi18jKGnU56jr/GVnE2Loef6PhAtU5CmwT2c9e2bct2uKi9tMmw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB9284

From: Peng Fan <peng.fan@nxp.com>

Use scope based of_node_put() cleanup to simplify code.

Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
 drivers/pinctrl/tegra/pinctrl-tegra-xusb.c |  7 ++-----
 drivers/pinctrl/tegra/pinctrl-tegra.c      | 10 +++-------
 2 files changed, 5 insertions(+), 12 deletions(-)

diff --git a/drivers/pinctrl/tegra/pinctrl-tegra-xusb.c b/drivers/pinctrl/tegra/pinctrl-tegra-xusb.c
index 96ef57a7d385..49c5edeba87f 100644
--- a/drivers/pinctrl/tegra/pinctrl-tegra-xusb.c
+++ b/drivers/pinctrl/tegra/pinctrl-tegra-xusb.c
@@ -238,20 +238,17 @@ static int tegra_xusb_padctl_dt_node_to_map(struct pinctrl_dev *pinctrl,
 {
 	struct tegra_xusb_padctl *padctl = pinctrl_dev_get_drvdata(pinctrl);
 	unsigned int reserved_maps = 0;
-	struct device_node *np;
 	int err;
 
 	*num_maps = 0;
 	*maps = NULL;
 
-	for_each_child_of_node(parent, np) {
+	for_each_child_of_node_scoped(parent, np) {
 		err = tegra_xusb_padctl_parse_subnode(padctl, np, maps,
 						      &reserved_maps,
 						      num_maps);
-		if (err < 0) {
-			of_node_put(np);
+		if (err < 0)
 			return err;
-		}
 	}
 
 	return 0;
diff --git a/drivers/pinctrl/tegra/pinctrl-tegra.c b/drivers/pinctrl/tegra/pinctrl-tegra.c
index ccfa3870a67d..69088609a0c8 100644
--- a/drivers/pinctrl/tegra/pinctrl-tegra.c
+++ b/drivers/pinctrl/tegra/pinctrl-tegra.c
@@ -188,20 +188,18 @@ static int tegra_pinctrl_dt_node_to_map(struct pinctrl_dev *pctldev,
 					unsigned *num_maps)
 {
 	unsigned reserved_maps;
-	struct device_node *np;
 	int ret;
 
 	reserved_maps = 0;
 	*map = NULL;
 	*num_maps = 0;
 
-	for_each_child_of_node(np_config, np) {
+	for_each_child_of_node_scoped(np_config, np) {
 		ret = tegra_pinctrl_dt_subnode_to_map(pctldev, np, map,
 						      &reserved_maps, num_maps);
 		if (ret < 0) {
 			pinctrl_utils_free_map(pctldev, *map,
 				*num_maps);
-			of_node_put(np);
 			return ret;
 		}
 	}
@@ -759,17 +757,15 @@ DEFINE_NOIRQ_DEV_PM_OPS(tegra_pinctrl_pm, tegra_pinctrl_suspend, tegra_pinctrl_r
 
 static bool tegra_pinctrl_gpio_node_has_range(struct tegra_pmx *pmx)
 {
-	struct device_node *np;
+	struct device_node *np __free(device_node) =
+		of_find_compatible_node(NULL, NULL, pmx->soc->gpio_compatible);
 	bool has_prop = false;
 
-	np = of_find_compatible_node(NULL, NULL, pmx->soc->gpio_compatible);
 	if (!np)
 		return has_prop;
 
 	has_prop = of_find_property(np, "gpio-ranges", NULL);
 
-	of_node_put(np);
-
 	return has_prop;
 }
 

-- 
2.37.1