Received-SPF: pass (google.com: domain of linux-kernel+bounces-165343-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <745cc56b-0ef4-4cf9-9051-cae318866672@web.de>
Date: Wed, 1 May 2024 15:55:32 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
To: Shenghao Ding <shenghao-ding@ti.com>, alsa-devel@alsa-project.org,
 kernel-janitors@vger.kernel.org, Mark Brown <broonie@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
 Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
 Baojun Xu <Baojun.Xu@fpt.com>, Baojun Xu <baojun.xu@ti.com>,
 Bard Liao <bard.liao@intel.com>, Bard Liao
 <yung-chuan.liao@linux.intel.com>,
 Cameron Berkenpas <cameron.berkenpas@gmail.com>, Gergo Koteles
 <soyer@irl.hu>, Jaroslav Kysela <perex@perex.cz>, Kevin Lu
 <kevin-lu@ti.com>, Liam Girdwood <lgirdwood@gmail.com>,
 Liam Girdwood <liam.r.girdwood@intel.com>, mimperial@lenovo.com,
 Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
 Shenghao Ding <13916275206@139.com>, Takashi Iwai <tiwai@suse.de>
References: <20240501122252.1215-1-shenghao-ding@ti.com>
Subject: Re: [PATCH v2] ALSA: ASoc/tas2781: Fix wrong loading calibrated data
 sequence
Content-Language: en-GB
From: Markus Elfring <Markus.Elfring@web.de>
In-Reply-To: <20240501122252.1215-1-shenghao-ding@ti.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:G76/HUMR6xA=;H06TuOOrw5lW9fWGLZgvBGyaf8X
 O1nq13maYQPevtHwMcJueYQQnADEojURhq9Ki8CXofg8Kpfyy4zGwoeXqpmJezdrA3PvgwE++
 26hRi0FlMEt7ORTlluriHHZkiJRTv9ZC+sBkX5733AV30RwBktyo6GN6qvpisGrvuxFZRTPy6
 no1JScLRuH8tZd4T+DXG+UZaAPV41IvhVRnicrEkxaNx9/wt8vdBu8F0xQBSS1ghL7F1cPqaD
 kQeYBbXIVdIlLaeXe8nNNHeh9mP3FhY0mxGzisw+lw8zBqTSfztw/KwSYLNKcTqcZswlAxXRz
 4yDbFEtiZVG6GBUHi4a3OctfsYfVmYfnfvNh0Nk/pHcj9D9bOkrOg6mEA6/XB5DZemuYr+5pl
 E5W1c0nzTkaBwVlZPKWz3fxFlX9oaS3TJEd8PwI7BLuWOkLX6656IsFVoO1WvZPT56kugP0dv
 zrFf5QOhX7SL8hMLRP6OC/oyMAsyZ2wTGCoDndMgc7pYBd7nPJ4jILDBJMFtAkhRkXlNxm03p
 yt7ewUmPXSpC/rosJKrx+zyVvUfDBtv1RDKK2dQ///3a84vOICk7VFUNwDMNu9Z8aP8JKn9xI
 /0TjDpkz6c6bxNAhUexgqmfboi9CqiFZPhu4ewUT7q6X3iV1erUfSenTQ/MQY7pbMDa7HWObX
 LUoSfIO8Qi7sJvhjjfRnw+KEr/ui3HKlZS3HC+wPn61FSLSi91KJre8lCxAK7XUt47tKsiz7x
 oeIPRW0plNaRYG/9uvsjsyrbNlRbqwAjRlxGJAU2ATXPAL0+khcdGd4GVS3fDFLzwODcPgeN6
 Vc91a+7LcKArYW7CIqRAROJgzhm/yil/EUmulyTZFgR18=

=E2=80=A6
> +++ b/sound/soc/codecs/tas2781-fmwlib.c
=E2=80=A6
> @@ -2151,6 +2151,20 @@ static int tasdevice_load_data(struct tasdevice_p=
riv *tas_priv,
>  	return ret;
>  }
>
> +static void tasdev_load_calibrated_data(struct tasdevice_priv *priv,
> +	int i)

Please put the second function parameter into the previous line.


=E2=80=A6
> +	if (cal_fmw) {
> +		struct tasdevice_calibration *cal =3D cal_fmw->calibrations;
> +
> +		if (cal)
> +			load_calib_data(priv, &cal->dev_data);
> +		return;

Would this statement be redundant at the moment?


> +	}
> +}


Regards,
Markus