Received: by 2002:ab2:60d1:0:b0:1f7:5705:b850 with SMTP id i17csp496348lqm; Wed, 1 May 2024 07:09:55 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVOrqoHvJVPYcuWwVZvvoFc6IP4DjoWTj83ezDpVL1U+RFNqLf25yZecxpK/sqSv5YaR7Vrq7HEkF3I5czfefAVnk6H5/bpanCv5kBahA== X-Google-Smtp-Source: AGHT+IFKOV6t2V9aJe1Jh0UYFuGQfpi7EOKRcUHfMzYGxNM9YpDn9VjPGjVDE7pKtywVejafLuyc X-Received: by 2002:a05:6214:20a4:b0:6a0:5c80:71f5 with SMTP id 4-20020a05621420a400b006a05c8071f5mr2337342qvd.4.1714572595404; Wed, 01 May 2024 07:09:55 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1714572595; cv=pass; d=google.com; s=arc-20160816; b=Mvj22RJHsTCmBb9YjThTSLf0QGH+HDxdgkmjXg1bTdgc4Ki98DkrI06baUvCTZhk6g yMZ3WPQRYa20hoZmgsoga3i4sTAS+23gj2hzKxUc99Rxm9JQb3I8OkWpy67WeF+KU10M JKwDBqfmMD3Yr/05ljwVKN1nPR59lvXT0ntKJiAeiyHIZ0bbZ46pK4q3pB94uL8xafhh Cw1QlHXBBVUZfMCM75okp1tlEJWsUjJz9mPdPzdGZV+jQ6GoF/8r9BlWOYrhNBCDR6eE DAcpC/bUVlzNhY8Y3433gJhG8YRjPLHUk+PR+7lQVkcuzRxrc/XqVIGEl5lipXwH2Npq /sGg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=O1qoEIkOLck4Sa8ZT+0G2TYNAGl2HaO45P/SMXLf4vc=; fh=JBG6XNAJNV6CEylqZz0LAbGJBfmes9Ud4SVEZlgAKE0=; b=eYGAMJfTrtgcaqeKiRmdVk6Y3MAqSMD21RfGMnoZnFQnE9Uw5uH1QxxILnxpGV8xwe LaqgAPDu1/dfzUc9zM+7dsK7KyTb3BiHzFk2LMpHAQLA1Q411HPoOEQIh6uWnWRHWLLx OCfkTIBprH6mzhJ/+WHPNsJXXFPKWvuJsSVfx8eLvK7GzWuD8yehNipVxipTA35LJxII NcrpFQn+fMgzs3V4k6S2l7Q/kohV+/n0ZmpWZEzqATY3AT2TnIqnKd4zVhGiLU9HiAYN WVA516XFUQG5tMpE8sqTcfYzGeLD1wm8NZc04KeQtKhqHR53EiIoebsxiR8gMM/r9tTq rjkw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@ziepe.ca header.s=google header.b=gR4Z9xKb; arc=pass (i=1 spf=pass spfdomain=ziepe.ca dkim=pass dkdomain=ziepe.ca); spf=pass (google.com: domain of linux-kernel+bounces-165357-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-165357-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id pt16-20020a056214049000b0069948077216si31528084qvb.267.2024.05.01.07.09.55 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 May 2024 07:09:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-165357-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@ziepe.ca header.s=google header.b=gR4Z9xKb; arc=pass (i=1 spf=pass spfdomain=ziepe.ca dkim=pass dkdomain=ziepe.ca); spf=pass (google.com: domain of linux-kernel+bounces-165357-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-165357-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 1C8E41C20CB8 for ; Wed, 1 May 2024 14:09:55 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 57EEC12F36D; Wed, 1 May 2024 14:09:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="gR4Z9xKb" Received: from mail-qk1-f179.google.com (mail-qk1-f179.google.com [209.85.222.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 16F9750248 for ; Wed, 1 May 2024 14:09:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714572586; cv=none; b=kgbyLSPBlf6LgRX2PBGyXpI6yE+1266yEupNu7B68Y8n4RamRW9SqkCV7tsd/7ro/+QriYG0gApQTUHN1daLvkexccS4FWi2Goe0HHBXlkdWxZno9TktA41+hfnFhGSFiNR9oszv18EhBvPjDfY9Ls4Bwm1SzlQVz1L4IAhJqGE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714572586; c=relaxed/simple; bh=lWkPcYzM0IS2ZNLUbMpap349Ov8pUe/jEyQ1UbI3Lno=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=nzxqkFA2xiGBKqpIKw+ZdR5dQTg7JpBcO+T8wE65pjLjGKOSVjnFL4PI0O6UtRy7NTiqPD3eXhZFLWMRdZbeKOMqqzdbm8oq2oQQqQwXeNmn54ivvwN/WFxEy57w/cuV3oNUPdUUKp7cwqM0ZSQWFXfWs+TPJ5dyr2MrkPQgb58= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=gR4Z9xKb; arc=none smtp.client-ip=209.85.222.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Received: by mail-qk1-f179.google.com with SMTP id af79cd13be357-78f02c96c52so488939985a.1 for ; Wed, 01 May 2024 07:09:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1714572584; x=1715177384; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=O1qoEIkOLck4Sa8ZT+0G2TYNAGl2HaO45P/SMXLf4vc=; b=gR4Z9xKbPjGulU9aDeXTQ1HwF4TAnwkWDu4GMq7PFKMfWkbDbfvBuEb2arghwDki0S 7e1sZnY1kUoBdHUTe0WsmPC1rc6Sx7VdF1MWMcoyHw0mM89jDielDXvzkNFjrFJ8wFmk eNssaHJaqDObF3uLY3UjquJNzXs5SWhD4WcrCsPQe2m7NMQx2+eBMqyhtOZ5eX4k+JqU /OgnbZgfsWS9th8xyANwkwj1iFejr+cxFzfcSEOsJPw3PoJ0Skn+3cVuudEA+Kdomqg6 WxB2SckZB3bvkA0DiE1HEM1Su8RP6O/VbI7Wh7gkEP7Ji/9M2+GxG9TY3LxICxCmXHuW teLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714572584; x=1715177384; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=O1qoEIkOLck4Sa8ZT+0G2TYNAGl2HaO45P/SMXLf4vc=; b=Z3C4kMAHfXb8qSezZpu3rTlMU8jesA5lRYCCLYC6lkszls98Y8EotA0wWxmWxFkqSP ohaTHzUVVIBlZL56ROqmEVmPS72B05wpdK1smnXDqq1hF3mI1/UfZAWs1aKTH55OGs2I Yq/N5vdf0vvZ81gbZi0ghrMgTeNsTmnvM1QbiIv1TBKUfkTqQb9dlxs8wJsLqCMmhC1O knh5Se8dkXXxPUOUP08tOUnrSCIT26KJEwJCtd/t+lF56ixHaRXOugTdRhvRdgvXi514 9JMddHve/6KpZd/0lgDuH0Sg85ofll6maqvI9vLEX2+h/ASWLe4WTE9MFnKXYJUzupYO 9AVQ== X-Forwarded-Encrypted: i=1; AJvYcCWZv/JREVznR801PzAImbLrj5jyFUelKLdpx2WlXXfeFmCqaIqGzeHT0LULIKBnVDKIxsEF5Ow96amFaN/ImD5z4Wo/Ka3W19w/o/Zr X-Gm-Message-State: AOJu0Yy5biuqlCnVe8P7zTbYVWxjy3hIlkLHcZQDnWbTVtWNrJ3LDk7B KrkDhO2q3annYdI0w2lFt3f1PjOmpP87Dq9Sqe3d+OV/ldSxFFF5k7gZdbeWrjk= X-Received: by 2002:a05:620a:4304:b0:790:944d:65b3 with SMTP id u4-20020a05620a430400b00790944d65b3mr2980242qko.62.1714572583947; Wed, 01 May 2024 07:09:43 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-68-80-239.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.68.80.239]) by smtp.gmail.com with ESMTPSA id pe16-20020a05620a851000b007883184574esm12405228qkn.98.2024.05.01.07.09.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 May 2024 07:09:43 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.95) (envelope-from ) id 1s2AeU-00DPni-Mh; Wed, 01 May 2024 11:09:42 -0300 Date: Wed, 1 May 2024 11:09:42 -0300 From: Jason Gunthorpe To: Shivaprasad G Bhat Cc: mpe@ellerman.id.au, tpearson@raptorengineering.com, alex.williamson@redhat.com, linuxppc-dev@lists.ozlabs.org, aik@amd.com, npiggin@gmail.com, christophe.leroy@csgroup.eu, aneesh.kumar@kernel.org, naveen.n.rao@linux.ibm.com, gbatra@linux.vnet.ibm.com, brking@linux.vnet.ibm.com, aik@ozlabs.ru, ruscur@russell.cc, robh@kernel.org, linux-kernel@vger.kernel.org, joel@jms.id.au, kvm@vger.kernel.org, msuchanek@suse.de, oohall@gmail.com, mahesh@linux.ibm.com, jroedel@suse.de, vaibhav@linux.ibm.com, svaidy@linux.ibm.com Subject: Re: [RFC PATCH v2 0/6] powerpc: pSeries: vfio: iommu: Re-enable support for SPAPR TCE VFIO Message-ID: <20240501140942.GA1723318@ziepe.ca> References: <171450753489.10851.3056035705169121613.stgit@linux.ibm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <171450753489.10851.3056035705169121613.stgit@linux.ibm.com> On Tue, Apr 30, 2024 at 03:05:34PM -0500, Shivaprasad G Bhat wrote: > RFC v1 was posted here [1]. As I was testing more and fixing the > issues, I realized its clean to have the table_group_ops implemented > the way it is done on PowerNV and stop 'borrowing' the DMA windows > for pSeries. > > This patch-set implements the iommu table_group_ops for pSeries for > VFIO SPAPR TCE sub-driver thereby enabling the VFIO support on POWER > pSeries machines. Wait, did they previously not have any support? Again, this TCE stuff needs to go away, not grow. I can grudgingly accept fixing it where it used to work, but not enabling more HW that never worked before! :( Jason