Received-SPF: pass (google.com: domain of linux-kernel+bounces-165364-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Wed, 1 May 2024 10:19:18 -0400
From: Alan Stern <stern@rowland.harvard.edu>
To: Michael Grzeschik <mgr@pengutronix.de>
Cc: Eric Van Hensbergen <ericvh@kernel.org>,
  Latchesar Ionkov <lucho@ionkov.net>,
  Dominique Martinet <asmadeus@codewreck.org>,
  Christian Schoenebeck <linux_oss@crudebyte.com>,
  Jonathan Corbet <corbet@lwn.net>,
  Greg Kroah-Hartman <gregkh@linuxfoundation.org>, v9fs@lists.linux.dev,
  linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
  linux-usb@vger.kernel.org, kernel@pengutronix.de
Subject: Re: [PATCH v4 1/3] usb: gadget: function: move u_f.h to
 include/linux/usb/
Message-ID: <96fe85f7-eaf1-4231-985b-14514cf53f3d@rowland.harvard.edu>
References: <20240116-ml-topic-u9p-v4-0-722ed28b0ade@pengutronix.de>
 <20240116-ml-topic-u9p-v4-1-722ed28b0ade@pengutronix.de>
 <1fb801bf-3bef-4f95-8036-fc8634679141@rowland.harvard.edu>
 <ZjH_cx_0uBLc6M6L@pengutronix.de>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZjH_cx_0uBLc6M6L@pengutronix.de>

On Wed, May 01, 2024 at 10:38:11AM +0200, Michael Grzeschik wrote:
> On Mon, Apr 29, 2024 at 09:51:20PM -0400, Alan Stern wrote:
> > On Tue, Apr 30, 2024 at 01:33:26AM +0200, Michael Grzeschik wrote:
> > > We move the u_f.h header to include/linux/usb to be
> > > able to compile function drivers outside of the
> > > drivers/usb/gadget/function directory.
> > > 
> > > Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de>
> > 
> > Given that you're moving a private header file to a public location,
> > don't you think it should now have a name that's more meaningful to
> > general kernel developers than "u_f.h"?
> 
> Fair point.
> 
> How about func_utils.h instead?

Yes, that would be a lot better.  Especially if you put it in 
include/linux/usb/gadget rather than include/linux/usb.

Thanks.

Alan Stern