Received-SPF: pass (google.com: domain of linux-kernel+bounces-165365-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Wed, 1 May 2024 16:19:42 +0200 (CEST)
From: Julia Lawall <julia.lawall@inria.fr>
To: Daniel Thompson <daniel.thompson@linaro.org>
cc: R Sundar <prosunofficial@gmail.com>, Lee Jones <lee@kernel.org>, 
    Jingoo Han <jingoohan1@gmail.com>, Helge Deller <deller@gmx.de>, 
    dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, 
    linux-kernel@vger.kernel.org, skhan@linuxfoundation.org, 
    javier.carrasco.cruz@gmail.com, Julia Lawall <julia.lawall@inria.fr>, 
    Shresth Prasad <shresthprasad7@gmail.com>
Subject: Re: [PATCH] backlight: sky81452-backlight: replace of_node_put with
 __free
In-Reply-To: <20240501140144.GA10180@aspen.lan>
Message-ID: <alpine.DEB.2.22.394.2405011618351.3278@hadrien>
References: <20240501125146.33648-1-prosunofficial@gmail.com> <20240501140144.GA10180@aspen.lan>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII


On Wed, 1 May 2024, Daniel Thompson wrote:

> On Wed, May 01, 2024 at 06:21:46PM +0530, R Sundar wrote:
> > Use the new cleanup magic to replace of_node_put() with
> > __free(device_node) marking to auto release when they get out of scope.
> >
> > Suggested-by: Julia Lawall <julia.lawall@inria.fr>
> > Signed-off-by: R Sundar <prosunofficial@gmail.com>
>
> Thanks for the patch but I think this one is a more appropriate
> solution to this issue:
> https://lore.kernel.org/all/20240421104916.312588-2-shresthprasad7@gmail.com/

Maybe neither one is perfect?  The one I see at that link has:

 	if (!pdata) {
-		of_node_put(np);
 		return ERR_PTR(-ENOMEM);
 	}

which has unneeded {}

julia


>
>
> Daniel.
>