Received-SPF: pass (google.com: domain of linux-kernel+bounces-165412-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <c5e5f49295350ada2cdb280a77b1c877058d4d64.camel@apitzsch.eu>
Subject: Re: [PATCH v2 2/3] leds: sy7802: Add support for Silergy SY7802
 flash LED controller
From: =?ISO-8859-1?Q?Andr=E9?= Apitzsch <git@apitzsch.eu>
To: Lee Jones <lee@kernel.org>
Cc: Pavel Machek <pavel@ucw.cz>, Rob Herring <robh@kernel.org>, Krzysztof
 Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley
 <conor+dt@kernel.org>, Kees Cook <keescook@chromium.org>, "Gustavo A. R.
 Silva" <gustavoars@kernel.org>,  Bjorn Andersson <andersson@kernel.org>,
 Konrad Dybcio <konrad.dybcio@linaro.org>, linux-leds@vger.kernel.org, 
 devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, 
 linux-hardening@vger.kernel.org, linux-arm-msm@vger.kernel.org, 
 ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org
Date: Wed, 01 May 2024 16:59:34 +0200
In-Reply-To: <20240411124855.GJ1980182@google.com>
References: <20240401-sy7802-v2-0-1138190a7448@apitzsch.eu>
	 <20240401-sy7802-v2-2-1138190a7448@apitzsch.eu>
	 <20240411124855.GJ1980182@google.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.52.1 
Precedence: bulk
MIME-Version: 1.0

Hi Lee Jones,

thanks for the feedback. I will address your comments in the next
version. I have a few comments/questions though, see below.

Best regards,
Andr=C3=A9

Am Donnerstag, dem 11.04.2024 um 13:48 +0100 schrieb Lee Jones:
> On Mon, 01 Apr 2024, Andr=C3=A9 Apitzsch via B4 Relay wrote:
> >=20
> > [..]
> > +
> > +#define SY7802_TIMEOUT_DEFAULT_US	512000U
> > +#define SY7802_TIMEOUT_MIN_US		32000U
> > +#define SY7802_TIMEOUT_MAX_US		1024000U
> > +#define SY7802_TIMEOUT_STEPSIZE_US	32000U
> > +
> > +#define SY7802_TORCH_BRIGHTNESS_MAX 8
> > +
> > +#define SY7802_FLASH_BRIGHTNESS_DEFAULT	14
> > +#define SY7802_FLASH_BRIGHTNESS_MIN	0
> > +#define SY7802_FLASH_BRIGHTNESS_MAX	15
> > +#define SY7802_FLASH_BRIGHTNESS_STEP	1
>=20
> Much nicer to read if everything was aligned.

Using tab size 8, SY7802_FLASH_BRIGHTNESS_* look aligned to me. Do you
refer to SY7802_TORCH_BRIGHTNESS_MAX here?=20

>=20
> > [..]
> > +
> > +	/*
> > +	 * There is only one set of flash control logic, and this
> > flag is used to check if 'strobe'
>=20
> The ',' before 'and' is superfluous.
>=20
> > +	 * is currently being used.
> > +	 */
>=20
> Doesn't the variable name kind of imply this?
>=20
> > +	if (chip->fled_strobe_used) {
> > +		dev_warn(chip->dev, "Please disable strobe first
> > [%d]\n", chip->fled_strobe_used);
>=20
> "Cannot set torch brightness whilst strobe is enabled"

The comment and the warn message are taken from 'leds-mt6370-flash.c'.
But I think using the warn message you suggested the comment can be
removed.

>=20
> > +		ret =3D -EBUSY;
> > +		goto unlock;
> > +	}
> > +
> > +	if (level)
> > +		curr =3D chip->fled_torch_used | BIT(led->led_no);
> > +	else
> > +		curr =3D chip->fled_torch_used & ~BIT(led->led_no);
> > +
> > +	if (curr)
> > +		val |=3D SY7802_MODE_TORCH;
> > +
> > +	/* Torch needs to be disabled first to apply new
> > brightness */
>=20
> "Disable touch to apply brightness"
>=20
> > +	ret =3D regmap_update_bits(chip->regmap, SY7802_REG_ENABLE,
> > SY7802_MODE_MASK,
> > +				 SY7802_MODE_OFF);
> > +	if (ret)
> > +		goto unlock;
> > +
> > +	mask =3D led->led_no =3D=3D SY7802_LED_JOINT ?
> > SY7802_TORCH_CURRENT_MASK_ALL :
>=20
> Why not just use led->led_no in place of mask?

I might be missing something, but I don't know how to use led->led_no
in place of mask, when
led->led_no is in {0,1,2} and
mask is in {0x07, 0x38, 0x3f}.

>=20
> Easier to read if you drop SY7802_TORCH_CURRENT_MASK_ALL to its own
> line.
>=20
> > +	=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 SY7802_TORCH_CURRENT_MASK(led->l=
ed_no);
> > +
> > [..]
> > +
> > +static int sy7802_probe(struct i2c_client *client)
> > +{
> > +	struct device *dev =3D &client->dev;
> > +	struct sy7802 *chip;
> > +	size_t count;
> > +	int ret;
> > +
> > +	count =3D device_get_child_node_count(dev);
> > +	if (!count || count > SY7802_MAX_LEDS)
> > +		return dev_err_probe(dev, -EINVAL,
> > +		=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "No child node or node count ov=
er max led
> > number %zu\n", count);
>=20
> Split them up and report on them individually or combine the error
> message:
>=20
> "Invalid amount of LED nodes"

This snippet was also taken from 'leds-mt6370-flash.c'.

>=20