Received: by 2002:ab2:60d1:0:b0:1f7:5705:b850 with SMTP id i17csp549784lqm; Wed, 1 May 2024 08:31:55 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXYT9ozOxKeMFbMeiW8vH6MVuo4HvPVaU0qn1Gvvc6i7YOsQwVtnlIfbHsip2j1RFWhs6EFmoT1Io128s3CvcsbFrKbjGQGHptKZydlBQ== X-Google-Smtp-Source: AGHT+IG3Z1HuIadw9REE+N/45+CougCfGDlw++Lwn+aPu6q8V++Gswobj9f4zldNCG1PK6WhsXhX X-Received: by 2002:a17:906:d195:b0:a58:7304:9cd6 with SMTP id c21-20020a170906d19500b00a5873049cd6mr2714456ejz.24.1714577515087; Wed, 01 May 2024 08:31:55 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1714577515; cv=pass; d=google.com; s=arc-20160816; b=VqnF8CbGdjCEL7GU9oZ77+q+4ujA+tQXHFdZ/Zpbpg0O3r/S0HOh2IM0/8pbBmPnbu jyj9r++A5ddWnA19A84pkJl15tbRShb/M2h7EGqxUoqrhGn86xsz9kLm0qMxhLdRJzUW O3L1JUkCvumT4G6+CQl/sSNDcJTqJeX+Z6xufokxYqG/8fvVfszWtust/tDU5XfXhxHl MTwVn9HMdq23b83W2ZGFobm+ICsboPqxTaOoWLssQb3YyGGKmxJFFfOj3rc+ddewJZ9Z L+NmfJVaSe1irWP8kiPB2rj8BkyGvCgkfIISoYc1uNR6m3vWlJwEEnJBID6JaADoHn+h B5Vg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=DCgAgHlEMGBMjcN16C1bbheZthQRfCGTfl1ll6guAKc=; fh=ng0FUFwPgHHqIHtWcUlLUSBs0e7fHIUGeuUhfcQSRgA=; b=Rac+5IFQpobIW4QEnk3431z8FxtqVDUNjJiRFYZLOWM0m2BWbyjgy48R8Z6dDym9sm uYCjj2NQZYtf/eEkwRLb9ma09JIYNML3hs0ZVUMPZDEvgv9EBSxlAbMDAF97vsMG7OGF OhrotrrV5orl//hHveYc7Qe9w5ifheRZH0+jXPDN/7magSSRqd7zI8sA0DFMhVrpieK+ LgzzqYPfY+Ls2vs3FwhPNqKGMkfGJQYsHeAwIbFfM7TjTjAx1Sx63Tw+0tHOXgcvRCoR /ZcjYynlieD5yFaYz3rP2FGDPTGqd0FFvIBgtvWU5dsaJvBKclTZz4e6ILOO/WBKdgZc 2zIA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=fail header.i=@luigi311.com header.s=x header.b=RAN2i+ez; arc=pass (i=1 spf=pass spfdomain=luigi311.com dkim=pass dkdomain=luigi311.com); spf=pass (google.com: domain of linux-kernel+bounces-165465-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-165465-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id x18-20020a170906297200b00a526b8e4a28si15921821ejd.975.2024.05.01.08.31.55 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 May 2024 08:31:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-165465-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=fail header.i=@luigi311.com header.s=x header.b=RAN2i+ez; arc=pass (i=1 spf=pass spfdomain=luigi311.com dkim=pass dkdomain=luigi311.com); spf=pass (google.com: domain of linux-kernel+bounces-165465-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-165465-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id AAB031F26976 for ; Wed, 1 May 2024 15:25:22 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 1F72912F589; Wed, 1 May 2024 15:25:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=luigi311.com header.i=@luigi311.com header.b="RAN2i+ez" Received: from mail-108-mta1.mxroute.com (mail-108-mta1.mxroute.com [136.175.108.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E94263D60 for ; Wed, 1 May 2024 15:25:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=136.175.108.1 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714577116; cv=none; b=rwyOVKptThAXYDqUICxnAcTDuRbeoLIZUiQUAkmic+xnQ7IcfbJ/fkjdvWtkv624zTLFcbuxZKNVn8hyJ9PKPRys05CPT6R9zn8ZU856R6kBEQwVoSdFERH+S698D/+N+zv+wJpbEsCUDG3XKBdbk7Agz+vhoWs4asIaynBky0w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714577116; c=relaxed/simple; bh=g6reCIRH0/JcMBOnGIeqjTP1oTROyutPaPbhmdHf1Dg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=bnw+zm6llrkzVZuqnE9T20wWJ99XoeDPrASW4Qe33oLiKDgmlgav72HDVO5nmet3wmklAIGI49A9X1CH+bcpPSHuTcdNi/JL8YWWZuzR/gsp1khCs5gjVkk8PcRWjaXs/vLyotlz4/eDYMF2ATp0WYWmpDfqwa37wOsGgvzmPko= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=luigi311.com; spf=pass smtp.mailfrom=luigi311.com; dkim=pass (2048-bit key) header.d=luigi311.com header.i=@luigi311.com header.b=RAN2i+ez; arc=none smtp.client-ip=136.175.108.1 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=luigi311.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=luigi311.com Received: from filter006.mxroute.com ([136.175.111.2] filter006.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta1.mxroute.com (ZoneMTA) with ESMTPSA id 18f34c244460008ca2.010 for (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Wed, 01 May 2024 15:24:57 +0000 X-Zone-Loop: 5273bfbdd6c07c253d0efb070aa31e6602d820f3d77e DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=luigi311.com; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=DCgAgHlEMGBMjcN16C1bbheZthQRfCGTfl1ll6guAKc=; b=RAN2i+ezla/GVtNIFYi/2OO57O OAOaO9iff47iJ90hN+5XNUre0VaAp2HR30i6jU75O7mh5ry2YZhNr/5vHUJc3IK6DAJkTolg97uHD VsqxnNsyauMu6Wq2mKlqLarQWn3YBldQ7d9BUic249oPF65EiUo2ktvIMmmxcEPH8h7iJbZMjKbdN cFMqwTLIwK0ZaNoz1HYZdUbj07HEAgXSsWzd/cAXI/FwUDD4bItJkFo3vcp89/ltiuibt+92CCCv+ VD/wwr1hhJbaaxlKwEzs1od+0NMA/W+OG9lfeFpVHPURhkJdWNy5Y6a/Jf8PcXbJIWhY4DelIzosZ OD4bt8aw==; From: git@luigi311.com To: linux-media@vger.kernel.org Cc: dave.stevenson@raspberrypi.com, jacopo.mondi@ideasonboard.com, mchehab@kernel.org, robh@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, sakari.ailus@linux.intel.com, devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, pavel@ucw.cz, phone-devel@vger.kernel.org, Luis Garcia Subject: [PATCH v5 03/25] media: i2c: imx258: Disable digital cropping on binned modes Date: Wed, 1 May 2024 09:24:20 -0600 Message-ID: <20240501152442.1072627-4-git@luigi311.com> In-Reply-To: <20240501152442.1072627-1-git@luigi311.com> References: <20240501152442.1072627-1-git@luigi311.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Authenticated-Id: personal@luigi311.com From: Dave Stevenson The binned modes set DIG_CROP_X_OFFSET and DIG_CROP_IMAGE_WIDTH to less than the full image, even though the image being captured is meant to be a scaled version of the full array size. Reduce X_OFFSET to 0, and increase IMAGE_WIDTH to the full array. Signed-off-by: Dave Stevenson Signed-off-by: Luis Garcia Reviewed-by: Pavel Machek --- drivers/media/i2c/imx258.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/media/i2c/imx258.c b/drivers/media/i2c/imx258.c index 4a7048d834c6..0ae4371940ca 100644 --- a/drivers/media/i2c/imx258.c +++ b/drivers/media/i2c/imx258.c @@ -340,11 +340,11 @@ static const struct imx258_reg mode_2104_1560_regs[] = { { 0x0404, 0x00 }, { 0x0405, 0x20 }, { 0x0408, 0x00 }, - { 0x0409, 0x02 }, + { 0x0409, 0x00 }, { 0x040A, 0x00 }, { 0x040B, 0x00 }, { 0x040C, 0x10 }, - { 0x040D, 0x6A }, + { 0x040D, 0x70 }, { 0x040E, 0x06 }, { 0x040F, 0x18 }, { 0x3038, 0x00 }, @@ -459,11 +459,11 @@ static const struct imx258_reg mode_1048_780_regs[] = { { 0x0404, 0x00 }, { 0x0405, 0x40 }, { 0x0408, 0x00 }, - { 0x0409, 0x06 }, + { 0x0409, 0x00 }, { 0x040A, 0x00 }, { 0x040B, 0x00 }, { 0x040C, 0x10 }, - { 0x040D, 0x64 }, + { 0x040D, 0x70 }, { 0x040E, 0x03 }, { 0x040F, 0x0C }, { 0x3038, 0x00 }, -- 2.44.0