Received: by 2002:ab2:60d1:0:b0:1f7:5705:b850 with SMTP id i17csp552872lqm; Wed, 1 May 2024 08:36:47 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUjYzL7iIx6sN35rrLHLYjWxdmmKITEXbJZXNcRrYp2R5JBVX12YYPD0CxUDUY6UgYg1izxJCNuuWGvYLdQxMo0X3wLtEv5OAErycHyIw== X-Google-Smtp-Source: AGHT+IFHFQhvIuRYHlmv6isoH5+VQt5OAN1qwce/rf2loyBwjT3GmjNjP3Nt4HfRThF+yoLiZDRd X-Received: by 2002:ad4:5baa:0:b0:6a0:b3ff:1e7b with SMTP id 10-20020ad45baa000000b006a0b3ff1e7bmr2891238qvq.18.1714577806866; Wed, 01 May 2024 08:36:46 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1714577806; cv=pass; d=google.com; s=arc-20160816; b=Yd8x3j4b6DMLZYYlBvqR/vVS16UAcEpSplzuY3dxtihdG/buT7w7Jg9E4ESGYFPfcR LAx/uY9v/mbmbaGD2o8MRLOI75nc0ipg09DNUxx/17pBmyfbNkynssYSkqxJGxDv0Xu5 MmO+JjYmbZwb//nTiESi6aZRR/e//7svavz0CEW7kHLqyLIiUiYDcZXgF6ZHz0g8cmU7 fSvKTVTSkewF9dB8OiaRh4y/5EsOSRdl0+XvM7dUB6IJUkhFxZL91iHAnP/rzmQUC5gN oc8dniHVri+2lq5HhFfc0QTItN7VGFD20Q/L9nU8ar0lvHj3dLVaioQbOEM9O0p/9Ei3 IHQA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=l4xjBgCfjnOzd7+CFjKpXoct8jxcDRnErTduE7TIjwU=; fh=V+nYuVHbDZEzOeWbq7fXC7EenZJIMTuDHTwfAnS8JtA=; b=UzAuO/UB7RUbodNtDRxrMWUCKqjD4DQw4OPKdYI+hmcGBDa5dksZIwH0YY2qIlU6S/ 4sLY3jvyR0GYBDwkBydJ6WbqCr1gk9jK0Iag2+KPOdJh1/Y53BicxGF6iO6/OYCXQBWh QWcFbQe6tuTMpS4BRTbPWZL3sEKb1fqj8CER9p+m9zHlF4RRBNm+ZzyJgpEdOwloVdAr ncLIhpnvYU5NiXsDoPEV4RpONtLhrwlg8UWL/HC6RrXDPja+bvSQSx4Cd0QZv20DlzQP tcQWHQk6Qq08R7Wj5WlK6cmvOM/bh1ZnQA6VPtGTPzThVyAxmv1bzx7Choo1+BD2UG3Z lx8g==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=fail header.i=@luigi311.com header.s=x header.b=Bq4LSKwX; arc=pass (i=1 spf=pass spfdomain=luigi311.com dkim=pass dkdomain=luigi311.com); spf=pass (google.com: domain of linux-kernel+bounces-165496-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-165496-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id j15-20020a05621419cf00b006a084760d0dsi22836137qvc.368.2024.05.01.08.36.46 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 May 2024 08:36:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-165496-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=fail header.i=@luigi311.com header.s=x header.b=Bq4LSKwX; arc=pass (i=1 spf=pass spfdomain=luigi311.com dkim=pass dkdomain=luigi311.com); spf=pass (google.com: domain of linux-kernel+bounces-165496-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-165496-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 1097B1C22938 for ; Wed, 1 May 2024 15:36:46 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 46EDF130E40; Wed, 1 May 2024 15:32:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=luigi311.com header.i=@luigi311.com header.b="Bq4LSKwX" Received: from mail-108-mta127.mxroute.com (mail-108-mta127.mxroute.com [136.175.108.127]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E907B130E3F for ; Wed, 1 May 2024 15:32:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=136.175.108.127 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714577539; cv=none; b=L7XnhjTnF4i4kf+B5LZ1E06XNtxHKwXtMtrqrgitJns/9RJMkg7N9tRuDShztjXFDvDgWmpl5rSJUr01o+FosofDRKezsM3baf7xd4BhGUHtAKfE/KeCwbrQttkNTagqVHiuiZg523KQNZxN8sG3Rvn6L4EDGJlXH8m81DK+Djk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714577539; c=relaxed/simple; bh=UTScrY5dDltq3774NcIr4xHvkWcHteXfo0G5OFlhITw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=UYXMIG+hfTzpaBVtk4KN+j4jUDaUomrwteTV+DwK8t3/yeGq9efqmojkS6MCJHuKgmp2n+9e/hhyYPZYcDmSCEm7zsymRdAcKHBWKd4AmWHtP2oa3+9n2uMqqyHiXOWbUG99GW6p006sL2TXy2yO2Lx1RHHyTo4slYv6Zv/mVFY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=luigi311.com; spf=pass smtp.mailfrom=luigi311.com; dkim=pass (2048-bit key) header.d=luigi311.com header.i=@luigi311.com header.b=Bq4LSKwX; arc=none smtp.client-ip=136.175.108.127 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=luigi311.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=luigi311.com Received: from filter006.mxroute.com ([136.175.111.2] filter006.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta127.mxroute.com (ZoneMTA) with ESMTPSA id 18f34c2fe270008ca2.012 for (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Wed, 01 May 2024 15:25:45 +0000 X-Zone-Loop: b2d495bc92b5bf09cc38129a127d450f788039bc204c DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=luigi311.com; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=l4xjBgCfjnOzd7+CFjKpXoct8jxcDRnErTduE7TIjwU=; b=Bq4LSKwXtEA8x7efCRyZEphZWo bg+bEfMpQ6QQsS3WvgmvcQ1gP3b1GNbSq1XC/FD/LhpMC5QLmqD9cJYKUsACQfTfpA1wzxHL0fgCq rh6Ds8xHts/AjN3xOeMANhIi/YVBqbfbBTFfHwtTdJslvaKsu6lLiqGkGjsIHGim6MBvCfn8j2G60 fWsHz4TJ7nIbbCBsUhyP88Dbt9RlSnNhT2Yzz7lYjApHCQJr/7yfLE5QyRjQFELq6RbItATgJEL/q 4J7hLnZTzEWa8SwvLbg3syOCgTQse61EPux6PdQAzatGUOky/Xlc6yUab8gp92SqLigxplak4fA48 WO607o4A==; From: git@luigi311.com To: linux-media@vger.kernel.org Cc: dave.stevenson@raspberrypi.com, jacopo.mondi@ideasonboard.com, mchehab@kernel.org, robh@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, sakari.ailus@linux.intel.com, devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, pavel@ucw.cz, phone-devel@vger.kernel.org, Ondrej Jirman , Ondrej Jirman , Luis Garcia , Tommaso Merciai Subject: [PATCH v5 23/25] media: i2c: imx258: Add support for reset gpio Date: Wed, 1 May 2024 09:24:40 -0600 Message-ID: <20240501152442.1072627-24-git@luigi311.com> In-Reply-To: <20240501152442.1072627-1-git@luigi311.com> References: <20240501152442.1072627-1-git@luigi311.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Authenticated-Id: personal@luigi311.com From: Ondrej Jirman It was documented in DT, but not implemented. Signed-off-by: Ondrej Jirman Signed-off-by: Luis Garcia Reviewed-by: Pavel Machek Reviewed-by: Tommaso Merciai --- drivers/media/i2c/imx258.c | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/drivers/media/i2c/imx258.c b/drivers/media/i2c/imx258.c index f0bd72f241e4..74a8f3ed1ab5 100644 --- a/drivers/media/i2c/imx258.c +++ b/drivers/media/i2c/imx258.c @@ -699,6 +699,7 @@ struct imx258 { unsigned int csi2_flags; struct gpio_desc *powerdown_gpio; + struct gpio_desc *reset_gpio; /* * Mutex for serialized access: @@ -1250,7 +1251,10 @@ static int imx258_power_on(struct device *dev) regulator_bulk_disable(IMX258_NUM_SUPPLIES, imx258->supplies); } - return ret; + gpiod_set_value_cansleep(imx258->reset_gpio, 0); + usleep_range(400, 500); + + return 0; } static int imx258_power_off(struct device *dev) @@ -1260,6 +1264,7 @@ static int imx258_power_off(struct device *dev) clk_disable_unprepare(imx258->clk); + gpiod_set_value_cansleep(imx258->reset_gpio, 1); gpiod_set_value_cansleep(imx258->powerdown_gpio, 1); regulator_bulk_disable(IMX258_NUM_SUPPLIES, imx258->supplies); @@ -1573,6 +1578,12 @@ static int imx258_probe(struct i2c_client *client) if (IS_ERR(imx258->powerdown_gpio)) return PTR_ERR(imx258->powerdown_gpio); + /* request optional reset pin */ + imx258->reset_gpio = devm_gpiod_get_optional(&client->dev, "reset", + GPIOD_OUT_HIGH); + if (IS_ERR(imx258->reset_gpio)) + return PTR_ERR(imx258->reset_gpio); + /* Initialize subdev */ v4l2_i2c_subdev_init(&imx258->sd, client, &imx258_subdev_ops); -- 2.44.0