Received: by 2002:ab2:60d1:0:b0:1f7:5705:b850 with SMTP id i17csp557753lqm; Wed, 1 May 2024 08:46:07 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCUZFH3Z/o/JdqyidpIt+9pg9Xs9B0cuSSItLK+IHePIfbueEIxujeZ47EF6bHA9UDoLbqGZtaAab9wHFTXNOJzzcJ1/s+VVUQYPNyl1nw== X-Google-Smtp-Source: AGHT+IFcNK+i5RVIUhqJ4/P636lYoxk3XXyKQw9IF9y0tKhGuUwhenqf4Oq3uWN0FgUS/vZbRNYI X-Received: by 2002:a9d:7756:0:b0:6eb:8435:6d with SMTP id t22-20020a9d7756000000b006eb8435006dmr2791436otl.16.1714578366760; Wed, 01 May 2024 08:46:06 -0700 (PDT) Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id wx28-20020a05620a5a5c00b00790f386054asi7558575qkn.346.2024.05.01.08.46.06 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 May 2024 08:46:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-165510-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@chromium.org header.s=google header.b=QfftHLvu; arc=fail (body hash mismatch); spf=pass (google.com: domain of linux-kernel+bounces-165510-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-165510-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 49DAB1C21086 for ; Wed, 1 May 2024 15:46:06 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 8B1E513174A; Wed, 1 May 2024 15:43:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="QfftHLvu" Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2A20A130E27 for ; Wed, 1 May 2024 15:43:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714578222; cv=none; b=FqwAVat253xDJPEweIB8UHQATEEeavI+tsHwzM//EB+7WVJEGF1l9AJnYcUEc4YK+QdSFpw4f023M6KuPa47NXRs3vNnTbP2ewpfoO0Jsv7XT+Eiy47jQzWHW3SoIippQkbSDoun5EbEde23eZvrtcC6AlVjcykEI569X37TtYE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714578222; c=relaxed/simple; bh=7Yd1PSAW7e+rUqZBTSR1vimgg2dBZCkyx4crswNxR8c=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=h7bv3pSixaoicc6bMc6OJl4Q/llv+tIrHAv/0hX8zHvkKry7cf3njI9QLRa7pxFgLJ+HoWRQqi1jqnA4c9TSRf7zKidiZpD9dIPaoJDMGWFmRTfsAbqtnikDulSV/FQR49ElDthax4U2IRYJxLUX6Hmj7b4Yjd1Q/engIc6RtvU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=QfftHLvu; arc=none smtp.client-ip=209.85.210.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Received: by mail-pf1-f180.google.com with SMTP id d2e1a72fcca58-6f3f6aa1437so3391400b3a.3 for ; Wed, 01 May 2024 08:43:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1714578216; x=1715183016; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=pkwrBbfCjOsJ2BvUtkk0pGwMNhz7eA01MHph4bkgbvM=; b=QfftHLvuzbhip01YY/4mpgMhrtW3ACqv6pVOyNGV67DAylkXrDpHRAFc6B/NfvVDZc E/g+DCXBW0m6gqejREQ5o99e9OR0eAMiL2OA8wRJt0iXZHt05gxfMFPceAQD0ER5AI8t qt2W23wQstU/JAc/yRAebBblM3/NkiclxnxTk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714578216; x=1715183016; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pkwrBbfCjOsJ2BvUtkk0pGwMNhz7eA01MHph4bkgbvM=; b=rX/XLXNyBJYx+AdggsSnMzQkgUqVmZXExxXYkmaDZDjyYmuSBHNlNH4y0ahM0zhva2 H2Iyx7WUQST/Go/3QWEX1bsTrwt63OVe63bjEVSJunAfxtJt1Rcbxia+k7A8c4tFR0TI Evfm+oSe7/5WsGCVXqqjUxXhYafufuI/1FYbrmCHeuT16DOtqh5pHkxhIl0pnN0Xi9S6 aCj5K4j4QeAUMKZnB+hQe9lyVZytqE2uRH8gmbiLZCv5/VlvPK5uN2MvOtKa0GfJmIyk strr/ZMUl2rog8BQ3QoKij0LRiNQufsCbQ9aGKT4fBhQD9Dr3amtGC7kBDVUI2VSX+WH 9SCg== X-Forwarded-Encrypted: i=1; AJvYcCX5HUK0r8g3Req4owKL1QswhWi+Hr2oI0oW1a802vqNL0ESduh/e47lomJO2JemBs2ePkbCHBzH70Dj+eZ9PK0zWn4bug//oqCOXayG X-Gm-Message-State: AOJu0YzFXRLXk/m8QY/uuoS5FZIZeh12i2DeykxHbmnPXHHnd0ZNdtK6 N075qFYPJL/yFk6Ci1AK3AvdjQRKClg8S8DaVIbzOCOnL7RsitMMO12cs3SuQg== X-Received: by 2002:a05:6a21:6d94:b0:1a7:7b92:e0ed with SMTP id wl20-20020a056a216d9400b001a77b92e0edmr2967637pzb.51.1714578215641; Wed, 01 May 2024 08:43:35 -0700 (PDT) Received: from dianders.sjc.corp.google.com ([2620:15c:9d:2:e886:8de:19a2:55b0]) by smtp.gmail.com with ESMTPSA id fb12-20020a056a002d8c00b006f3ec69bc09sm7717924pfb.75.2024.05.01.08.43.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 May 2024 08:43:34 -0700 (PDT) From: Douglas Anderson To: dri-devel@lists.freedesktop.org Cc: Linus Walleij , Jani Nikula , Dmitry Baryshkov , Cong Yang , Hsin-Yi Wang , Brian Norris , Sam Ravnborg , Neil Armstrong , Javier Martinez Canillas , Joel Selvaraj , lvzhaoxiong@huaqin.corp-partner.google.com, Douglas Anderson , Daniel Vetter , David Airlie , Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , linux-kernel@vger.kernel.org Subject: [PATCH v3 7/9] drm/panel: boe-tv101wum-nl6: Don't use a table for initting panels Date: Wed, 1 May 2024 08:41:10 -0700 Message-ID: <20240501084109.v3.7.Ib5030ab5cd41b4e08b1958bd7e51571725723008@changeid> X-Mailer: git-send-email 2.45.0.rc0.197.gbae5840b3b-goog In-Reply-To: <20240501154251.3302887-1-dianders@chromium.org> References: <20240501154251.3302887-1-dianders@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Consensus on the mailing lists is that panels shouldn't use a table of init commands but should instead use init functions. With the recently introduced mipi_dsi_dcs_write_seq_multi() this is not only clean/easy but also saves space. Measuring before/after this change: $ scripts/bloat-o-meter \ .../before/panel-boe-tv101wum-nl6.ko \ .../after/panel-boe-tv101wum-nl6.ko add/remove: 14/8 grow/shrink: 0/1 up/down: 27062/-31433 (-4371) Function old new delta inx_hj110iz_init - 7040 +7040 boe_tv110c9m_init - 6440 +6440 boe_init - 5916 +5916 starry_qfh032011_53g_init - 1944 +1944 starry_himax83102_j02_init - 1228 +1228 inx_hj110iz_init.d - 1040 +1040 boe_tv110c9m_init.d - 982 +982 auo_b101uan08_3_init - 944 +944 boe_init.d - 580 +580 starry_himax83102_j02_init.d - 512 +512 starry_qfh032011_53g_init.d - 180 +180 auo_kd101n80_45na_init - 172 +172 auo_b101uan08_3_init.d - 82 +82 auo_kd101n80_45na_init.d - 2 +2 auo_kd101n80_45na_init_cmd 144 - -144 boe_panel_prepare 592 440 -152 auo_b101uan08_3_init_cmd 1056 - -1056 starry_himax83102_j02_init_cmd 1392 - -1392 starry_qfh032011_53g_init_cmd 2256 - -2256 compoundliteral 3393 - -3393 boe_init_cmd 7008 - -7008 boe_tv110c9m_init_cmd 7656 - -7656 inx_hj110iz_init_cmd 8376 - -8376 Total: Before=37297, After=32926, chg -11.72% Let's do the conversion. Since we're touching all the tables, let's also convert hex numbers to lower case as per kernel conventions. Signed-off-by: Douglas Anderson --- Changes in v3: - Fix spacing of init function. - Remove an unneeded error print. - Squash boe-tv101wum-nl6 lowercase patch into main patch Changes in v2: - New .../gpu/drm/panel/panel-boe-tv101wum-nl6.c | 2792 +++++++++-------- 1 file changed, 1442 insertions(+), 1350 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c b/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c index 0ffe8f8c01de..aab60cec0603 100644 --- a/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c +++ b/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c @@ -17,6 +17,8 @@ #include