Received-SPF: pass (google.com: domain of linux-kernel+bounces-165521-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Wed, 1 May 2024 23:57:05 +0800
From: Kuan-Wei Chiu <visitorckw@gmail.com>
To: Shi-Sheng Yang <fourcolor4c@gmail.com>,
	Shi-Sheng Yang <james1qaz2wsx12qw@gmail.com>
Cc: Simon Horman <horms@kernel.org>, matttbe@kernel.org,
	martineau@kernel.org, davem@davemloft.net, edumazet@google.com,
	kuba@kernel.org, pabeni@redhat.com, geliang@kernel.org,
	netdev@vger.kernel.org, mptcp@lists.linux.dev,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mptcp: subflow.c: fix typo
Message-ID: <ZjJmUcfDioUzX2Gg@visitorckw-System-Product-Name>
References: <20240429225033.3920874-1-james1qaz2wsx12qw@gmail.com>
 <20240430180057.GB2575892@kernel.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240430180057.GB2575892@kernel.org>

On Tue, Apr 30, 2024 at 07:00:57PM +0100, Simon Horman wrote:
> On Tue, Apr 30, 2024 at 06:50:33AM +0800, Shi-Sheng Yang wrote:
> > Replace 'greceful' with 'graceful'.
> > 
> > Signed-off-by: Shi-Sheng Yang <james1qaz2wsx12qw@gmail.com>
> 
> Hi Shi-Sheng Yang,
> 
> Elsewhere in the same file 'earlier' is mispelt as 'eariler'.
> Could you consider fixing that too?
> 
> Better still, could you consider running codespell over
> net/mptcp/ and fixing (the non false-positives) that it flags?
> 
> If you do repost then I think an appropriate prefix
> would be 'mctp: ' rather than 'mctp: subflow.c ',
> as this follows the pattern in git history.
> 
> And I think the target tree should be net-next.
> That is, the patch should be based on net-next and
> it should be designated in the subject.
> 
> e.g. Subject: [PATCH v2 net-next] mptcp: fix typos in comments
> 
> Lastly, please keep in mind that 24h should elapse
> before posting a new version.
> 
> Link: https://docs.kernel.org/process/maintainer-netdev.html
> 
> ...
>

Hi Shi-Sheng,

I also noticed that the email you sent and the email from SoB are not
the same, which causes checkpatch.pl to complain about the following
warning:

WARNING: From:/Signed-off-by: email address mismatch: 'From: Shi-ShengYang fourcolor4c@gmail.com' != 'Signed-off-by: Shi-Sheng Yang james1qaz2wsx12qw@gmail.com'

total: 0 errors, 1 warning, 0 checks, 8 lines checked

Could you please address this issue in the next version as well?

Regards,
Kuan-Wei