Received: by 2002:ab2:60d1:0:b0:1f7:5705:b850 with SMTP id i17csp603367lqm; Wed, 1 May 2024 09:58:06 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCU/qn0kYHad3+hhIRwYeskOH41x1mI1zLzW9iXFBwPRoO+pMu0VP43JXlA40GsYpU7bNEZsFrELnkJPctuExdt0hAkOt4axDBTT1djPlg== X-Google-Smtp-Source: AGHT+IE2jxm/1s99Ty5t8zmQwicx9JWb0c1nzGkJKaBEDft/nu/zpT1pKm18hdWDIjnfU3We5TrH X-Received: by 2002:a05:690c:a8d:b0:61a:d5d0:e10a with SMTP id ci13-20020a05690c0a8d00b0061ad5d0e10amr3170083ywb.44.1714582685775; Wed, 01 May 2024 09:58:05 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1714582685; cv=pass; d=google.com; s=arc-20160816; b=b/fpEZKWWhWWE3ohOxg4y12gursYbPxs4U1PnxNDWsnxmOImYqmpFGsLsKMPPNVjWY jMj/3zGLkoCGyK3rwBjt7b2ehBFwzw5PZOFllImuK0vijcI6NZOzl5WeOhcpWeMQTFlc I75N4DSmd9BjiQsAjmIQEVveZdQS28V++bRSSDM78gOfWRxLb1TLapnJC3cs0+YsKQu1 ZlWktgIZ4bzNSDYsLH0IVj3gIyxLoHVkLTUfBs1utpFptHlkq0cv/E95+GFEaKyPfJb5 lRnprsScl+5rc0J8gyTrxIugJCpxOTP1MdGFzz/JxjMQrBd1RBvIFhZTki3uytGpJ+f7 ustQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:sender:dkim-signature; bh=VQA4lspcA/MWALXjkb0krn9YAGqjCZZVAgbrKw1wBEs=; fh=6dgZlmvT49K2Al9TJ5Kah3eRJP9EDE3RPqKaZTPKt20=; b=OcVLJ6Khj7RQC7IWUW+LPz6vy6t2SP5CekmZFmnh1wi9WzbmTtS7P6UgapoUo0ADoA B2clgAsfS94XaaCwRxTzvKY9Vx+uRqAmx8r3wmHgQTuk8yVjRg01NH0l5pFTIMU4ThF6 5SD1vs1No0xa7oYlZ5TNYvQei4QdIZrweBCGdsDgAxaAwuZKuvgN3LVf00epTfLKdUtI GIyRv5uPoUIBVYYKcQeEFJR5+Jb2mXgMWZJITczCktiTuuP/HxdG8EsT/2q+iHrUbyDz Fd8HFp508kLQVecjLpXf/qOnKNVZBQdJZoYWLBF+JEsLFnlb6vRy+lFZfCE0CuERZ7Z0 oa+g==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=D0ou3njJ; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-165618-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-165618-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id hd9-20020a05622a298900b00434eb4f244asi29401473qtb.586.2024.05.01.09.58.05 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 May 2024 09:58:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-165618-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=D0ou3njJ; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-165618-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-165618-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 7CCCB1C20CA4 for ; Wed, 1 May 2024 16:58:05 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 1606F17722; Wed, 1 May 2024 16:57:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="D0ou3njJ" Received: from mail-oa1-f46.google.com (mail-oa1-f46.google.com [209.85.160.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E140A134BD; Wed, 1 May 2024 16:57:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714582675; cv=none; b=TQ3sPYhOeAuEfWvl12aWaQiO97vLZmZvklUa1elhVeG2P7oATeuDm2xpySbGB9pIhOSJNek+PncaQk0fmYQtv5q1mtTSmClmh3BHDBzITxNX8kSJnaiygNomUKSRBbtJsfZt6im29AO3OFRWlqs9EcYR1pSWBMbkQ0JWdKNTLpc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714582675; c=relaxed/simple; bh=pFx1BWK+X28fURyvOu+0BP7QUcQQFNG1W49Bi4z2gXM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=V2c6s51fU7y7NMhTBoFUXBRI8IBOpKmj577xetQ3j5GnJLoxMBvrC4CYTXFlhoeMSwJsek8kJSR9b6pyEBnZjq/Y6CBXVDyqjQFIg/e4YqtOBmXWrUssDGQ03EKs2qbf4+SqobDhGsrRXxKePQ6FpYvPnKmlGReZBYDKqG+kkZQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=D0ou3njJ; arc=none smtp.client-ip=209.85.160.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-oa1-f46.google.com with SMTP id 586e51a60fabf-2343ae31a9bso3421914fac.1; Wed, 01 May 2024 09:57:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1714582673; x=1715187473; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=VQA4lspcA/MWALXjkb0krn9YAGqjCZZVAgbrKw1wBEs=; b=D0ou3njJa6I0T5SO7BzZTQAEANKMSTQVN6lqP8UR+kwDngOfE3/3i9GjW+WM4ntmVK w4vU1DsF9H1D+gQADlhUGn+x4HHeKWJLburDvYMTKf7XBUmIHjjYUy/eU0RfOIcy+bMh bpkn78xhtiwCX2LbVSCW2IMaZB+TfYCqWX0xVznH+88dg+GqL/N/YJsnEZuG1ecrRbQp K9akrPCRrqi6CYFBqz1lqt9K4SZfLKqyuOheNAmYz182RiPrjejKrFTk7xSSKXxUeYvH jR5r9RyZTYQLvF3WLbtVv6KDwl6Yf7TD1+KHDgps/FvY0OLG0DFcJvdS73DMTHrvHEw+ 8r+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714582673; x=1715187473; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VQA4lspcA/MWALXjkb0krn9YAGqjCZZVAgbrKw1wBEs=; b=fpRCOxOcFm5JXV8P6MLrSOf/rIhQylnzqDknlQ9pSv26jE/p01d3FXY9dBphAlBDoa TyNwLcoCiIJa/8ebfUOUJWsF+rujFAIzX21tdCypmK2ZPQkuMR84HIz1zFWcCLV8gj0C vSYwIFFGwx1IKCZoCCxoi3yo9DuNvd0g74VoRAU9ZHCfll1/kfRkqj1ifhoCEWSlVt06 Tadc+PvzcQ+fj1LGHO4TYUGRhtjSY2NAZauvW635tPalflHcyio9xxQWHLTrQg3Hyozf I+krtInFddWvcSO5TI8VReF9r/GQ9KKPYTyY/ZKwvtPWkHOd3bC/UJXNbnhO9aLyZqXA mFnQ== X-Forwarded-Encrypted: i=1; AJvYcCWs2oXWYvzwpSBfQLnbQfiQ70tmV+waQuPOsVq+Dnz2kQ96xBjSlm5bDYRNMDGzOOhzhq+DCWp0mCLH0bSv8MridAohIIaPAOweBuWYVh1dHIBseUbwzO0R9GlHYfGGCH8ZSb8AqXxen1ertA== X-Gm-Message-State: AOJu0Yxg3ipMK+9k+HuOvCzFujXDh/4YlvpZzJ+AcEIZRrNwzRE5usnU 0NTUJNjcTKD0JxxO1hc85+PFSFYvqVvOPmdOTjonIjTyWyBLRq4D9sPMX8Wi X-Received: by 2002:a05:6871:2b26:b0:23c:3c38:1b93 with SMTP id dr38-20020a0568712b2600b0023c3c381b93mr3422729oac.24.1714582672892; Wed, 01 May 2024 09:57:52 -0700 (PDT) Received: from localhost (dhcp-141-239-159-203.hawaiiantel.net. [141.239.159.203]) by smtp.gmail.com with ESMTPSA id n7-20020a635907000000b0061236221eeesm6773252pgb.21.2024.05.01.09.57.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 May 2024 09:57:52 -0700 (PDT) Sender: Tejun Heo Date: Wed, 1 May 2024 06:57:51 -1000 From: Tejun Heo To: Kemeng Shi Cc: willy@infradead.org, akpm@linux-foundation.org, jack@suse.cz, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 05/10] writeback: call domain_dirty_avail in balance_dirty_pages Message-ID: References: <20240429034738.138609-1-shikemeng@huaweicloud.com> <20240429034738.138609-6-shikemeng@huaweicloud.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240429034738.138609-6-shikemeng@huaweicloud.com> On Mon, Apr 29, 2024 at 11:47:33AM +0800, Kemeng Shi wrote: > Call domain_dirty_avail in balance_dirty_pages to remove repeated code. > This is also a preparation to factor out repeated code calculating > dirty limits in balance_dirty_pages. Ditto, probably better to roll up into the patch which factors out domain_dirty_avail(). Thanks. -- tejun