Received-SPF: pass (google.com: domain of linux-kernel+bounces-165632-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Wed, 1 May 2024 10:14:47 -0700
From: Vanshidhar Konda <vanshikonda@os.amperecomputing.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: liwei <liwei728@huawei.com>, Ionela Voinescu <ionela.voinescu@arm.com>, 
	Beata Michalska <beata.michalska@arm.com>, rafael@kernel.org, al.stone@linaro.org, 
	ashwin.chaugule@linaro.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, 
	liwei391@huawei.com, liaoyu15@huawei.com
Subject: Re: Re: [PATCH] cpufreq/cppc: changing highest_perf to nominal_perf
 in cppc_cpufreq_cpu_init()
Message-ID: <4rgiylbhgl7ds3fzjhpn7miund5c7dd6wi2mxdepbuub7atvpl@mchme5ccs62x>
References: <20240428092852.1588188-1-liwei728@huawei.com>
 <20240429104945.esdukn6ayudgyumc@vireshk-i7>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline
In-Reply-To: <20240429104945.esdukn6ayudgyumc@vireshk-i7>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?Rlma5LPqO7CNd0zQaPl1VXhVEQ08XMSMO+d9Ckc1KjfLvZq3FdgfSywuVqyA?=
 =?us-ascii?Q?yOZgV5u5BI2qkA62nffurgcEIVusSECAye68y5YrMkko1X3BbYoZH5TX9vh2?=
 =?us-ascii?Q?S0h5FcCbU6BTQkff1MiQYBja5WdG/wbVY6/iFLeU4zIGPH/M2DEI0qviB1NE?=
 =?us-ascii?Q?7dVhc5s57f0B93x02rgR1G9dP5Oq/9c38eimMRNoVzSNgBQclKkAmJ/krGFh?=
 =?us-ascii?Q?z8U6D+ELyv4Pm7R4G3+awrLgzzsth7KWSN7LiprYeZubRL9K2wAa4/Vzhq7U?=
 =?us-ascii?Q?puSKNlMV790IG23gLsyyF9qaad6RBUgp9B8N+kxhxYI/J4/BprGnQws+7n49?=
 =?us-ascii?Q?i0/rI2y9sXd78vIHJUb0HLYp1pbsuCF0opzTVAzlKsXCxgirZ+WqDKmwksLg?=
 =?us-ascii?Q?XgqoCbCucCVGkYpyIv4q9UrtoP/UBNBhd1PLY+huCySK1QYR+l0eQGAyvm/7?=
 =?us-ascii?Q?qYZLYwTCulsjbEDqrZUqLXoYamruiiDhMHc7muOTDkMvQ97G2ED6TA/w0a5H?=
 =?us-ascii?Q?0jZZSwPRTDRypVTSck0qvF4L3B5kiW7HHBqqCvrPk1nOhwwhlDcu48Y24y7e?=
 =?us-ascii?Q?hKIFPf45SVKECcjgSSlRy5DZwTb5N0D6c1qsr5x5CYNYb7SqtsDp50/Biaal?=
 =?us-ascii?Q?uhdXP8FRz++WNCiNPlbSdhwUtJX0peQmg+ZRSaaU3IW6dEeyRkhcIe0a12ok?=
 =?us-ascii?Q?wjLAgEmCjn4CQfM/sFx400GNp9HRHP8CavryhVbvso0vRD3RvhTTTSyMSFEH?=
 =?us-ascii?Q?rnBRjCqBuQFvfA+g8noip4wpYN9RuN6uaLV3jjD/rAjgS8t6jiAB/25dAsgF?=
 =?us-ascii?Q?RQ3Q9GGYllr8xX//WTsCJzWAmfGFDQeAfMgnHSXzpzC5bPVmttYO0L7Gh656?=
 =?us-ascii?Q?0xjgWwUs+xfwPAfbpxq/tJaYjld2NXP9WBd16cPW/3tRKnKwJwjq3n1IwYPI?=
 =?us-ascii?Q?TnRns0+bI4VxPhmntzVWrQ0QMdCtcIzrWXdIIxED60bNtxpQwoj9Faxco2pG?=
 =?us-ascii?Q?hCmEIRXTUvGBzXKhi6+yn5Bb1zFTC4pq+Gqq3m03rRWUKRPl544q4W581EYx?=
 =?us-ascii?Q?4MDo8uUZMabXMiS/7Y44x8YBnX/EdA4HQwt8dby374XXe8LBg1TREkb+SJgA?=
 =?us-ascii?Q?nNbFDmAXaOGTS5cRe1LbAnmiWDIhVsar/FNISzxhdX4Yb26DjeRBkJkKbI0N?=
 =?us-ascii?Q?CtwRuIICXz3zE6GwJyZuRM8MjKUp2VrAI/iKzR4umPD7OtSqsj91AF2huguE?=
 =?us-ascii?Q?/zx+ffwAVjTjC8x32N/Ohj8IPIBkgFyJIZozm6dvd0+1y9L8utK0juLOj2k+?=
 =?us-ascii?Q?vSIub2LCTKZoWLCBGHvxzCuMjZUFoKPtjkUkdZqvbyG8qXAi5KfuWUxNO1Up?=
 =?us-ascii?Q?U69DcFAu1xvM1s5eEcWm11zw9+1lDd7xwNWzE1F5/pQHUaY0fgauN5YlvBm0?=
 =?us-ascii?Q?3Jd9ax5xm5B61B6xah3J9OJMaM5qmxC83LWlwYjDLHR/GEgXJt74nVc3e6Kc?=
 =?us-ascii?Q?N5XYKiD0w+n6eMv2F8p+7vyA4D/71vLFPd4sNHotdDUV3nt7kDrbfee+8Ooa?=
 =?us-ascii?Q?NrmtsRMEBh+X6QueHX0RSqJ3BilTq6Qez1lnCjTnL9HG19z7P6+JGp+7nM8k?=
 =?us-ascii?Q?u++MjHSbeVjyF0NHoyziiTeWSB8eYlF2HIVzKCgWjmlt?=
X-OriginatorOrg: os.amperecomputing.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0c502487-5bab-4a20-fb03-08dc6a023647
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR01MB6509.prod.exchangelabs.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 May 2024 17:14:51.5738
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: K0slJUE2BoTka1SkWwq6eOg7xVdDClcvAiaPKQrq9YYNgDlABlNjlmCC55TLiBvmBoFmk0vl8Qi1FBcP7id5L++W+pKVfC1mFERxvgSDNnHADoGsdc4pgF0clngxIC38
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR01MB7285

On Mon, Apr 29, 2024 at 04:19:45PM +0530, Viresh Kumar wrote:
>CC'ing few folks who are working with the driver.
>
>On 28-04-24, 17:28, liwei wrote:
>> When turning on turbo, if frequency configuration takes effect slowly,
>> the updated policy->cur may be equal to the frequency configured in
>> governor->limits(), performance governor will not adjust the frequency,
>> configured frequency will remain at turbo-freq.
>>
>> Simplified call stack looks as follows:
>> cpufreq_register_driver(&cppc_cpufreq_driver)
>> 	...
>> 	cppc_cpufreq_cpu_init()
>> 		cppc_get_perf_caps()
>> 		policy->max = cppc_perf_to_khz(caps, caps->nominal_perf)
>> 			cppc_set_perf(highest_perf) // set highest_perf
>> 			policy->cur = cpufreq_driver->get() // if cur == policy->max
>> 	cpufreq_init_policy()
>> 		...
>> 		cpufreq_start_governor() // governor: performance
>> 			new_freq = cpufreq_driver->get() // if new_freq == policy->max
>> 			if (policy->cur != new_freq)
>> 			cpufreq_out_of_sync(policy, new_freq)
>> 				...
>> 				policy->cur = new_freq
>> 			...
>> 			policy->governor->limits()
>> 				__cpufreq_driver_target(policy->max)
>> 					if (policy->cur==target)
>> 					// generate error, keep set highest_perf
>> 						ret
>> 					cppc_set_perf(target)
>>
>> Fix this by changing highest_perf to nominal_perf in cppc_cpufreq_cpu_init().
>>
>> Fixes: 5477fb3bd1e8 ("ACPI / CPPC: Add a CPUFreq driver for use with CPPC")
>> Signed-off-by: liwei <liwei728@huawei.com>
>> ---
>>  drivers/cpufreq/cppc_cpufreq.c | 8 ++++----
>>  1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/cpufreq/cppc_cpufreq.c b/drivers/cpufreq/cppc_cpufreq.c
>> index 64420d9cfd1e..db04a82b8a97 100644
>> --- a/drivers/cpufreq/cppc_cpufreq.c
>> +++ b/drivers/cpufreq/cppc_cpufreq.c
>> @@ -669,14 +669,14 @@ static int cppc_cpufreq_cpu_init(struct cpufreq_policy *policy)
>>  	if (caps->highest_perf > caps->nominal_perf)
>>  		boost_supported = true;
>>
>> -	/* Set policy->cur to max now. The governors will adjust later. */
>> -	policy->cur = cppc_perf_to_khz(caps, caps->highest_perf);
>> -	cpu_data->perf_ctrls.desired_perf =  caps->highest_perf;
>> +	/* Set policy->cur to norm now. */
>> +	policy->cur = cppc_perf_to_khz(caps, caps->nominal_perf);
>> +	cpu_data->perf_ctrls.desired_perf =  caps->nominal_perf;
>>

This seems like the safer thing to do.

Reviewed-by: Vanshidhar Konda <vanshikonda@os.amperecomputing.com>

>>  	ret = cppc_set_perf(cpu, &cpu_data->perf_ctrls);
>>  	if (ret) {
>>  		pr_debug("Err setting perf value:%d on CPU:%d. ret:%d\n",
>> -			 caps->highest_perf, cpu, ret);
>> +			 caps->nominal_perf, cpu, ret);
>>  		goto out;
>>  	}
>>
>> --
>> 2.25.1
>
>-- 
>viresh