Received: by 2002:ab2:60d1:0:b0:1f7:5705:b850 with SMTP id i17csp621486lqm; Wed, 1 May 2024 10:26:36 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCW1SA6Wg8H2481UcY9FR48CoGtHz9f3aqP59efOsvGzZL08YuiDiN1X5+y8vTODVGTDI/LcksA+1zisVTdizLKP1y70poK9cLbgKrxB0A== X-Google-Smtp-Source: AGHT+IH058cLdt6DSk/qX2IPHnBJXsTNX1oxG5t7WKK2RqNMAo47ew0qEM0CGpI/oUsOCyO367Rq X-Received: by 2002:a05:6871:331e:b0:23c:980e:e40b with SMTP id nf30-20020a056871331e00b0023c980ee40bmr3508072oac.5.1714584396686; Wed, 01 May 2024 10:26:36 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1714584396; cv=pass; d=google.com; s=arc-20160816; b=rmJO9+H+9xBN0sRdX6NMblqBi6n72xFv9venlSdvTq4eB8Jusp68W+Ri2P1LYM3SVW qXS0wcJ/fJlBVuvada1KAtpC42BSkGpyCi9kykz+dgIekVL46I2gO0SPhAwStltD4u32 2ug38IQ+OWGMi26p6r3AVuDjRI97GyvCpiqsyPTY1n9xREQXGo1mYvC+mU6QEnLekgi0 8AS8hpkI6U9ZemQsSF0UewYa9tyECTu979BHYBBljQ+c2iFHnt4SnfqSagpAJPjMxqXv WdDpy/VB8740RUzw40W6EBCHoP+mO2YXYAGuZnGnLIUOM/vCO36OYa77vEIolQmOxsBT 8btA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=3H2isfS8T5ps/+wLdohfpyvRT+Uuu4Hht5kCun0wQ34=; fh=wnfKuHOUY4Mz1NUoc5XDTD1KV85duf1XGuItoJ8zV0s=; b=iXNPKhyoHizOAnZbmBwI8piX1bkiW1bHsCVVK4hh0C1F+AvLw+EGL89r85gKzsXVrg rmm0XEOCxNPFc4UKbRkteRrp2cXTpJN74xE4uDcsOl+Dap/mkYvgzGW/KIEggs9WMcbP e28CSh6W9mZdvbcsYKqJmw3xj9X8yghIaCp+CPxR9GAUt0Vq3/bEH8rApj0ruEwwv52a 3qQXOWDtaeE8aCxoYglUiyoRE7VIrIJCEDIjvpDVMMaccQGVI3iJubFKTXP+rZ8zEg4m fD8CAn5BXsPvm8qGLWA7/0eyEjzpmQwmwsDqN98wf4MmEVUIoOsppuCXXzjVa5z9HESO QLdA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=JyE8xHLG; arc=pass (i=1 spf=pass spfdomain=linux.dev dkim=pass dkdomain=linux.dev dmarc=pass fromdomain=linux.dev); spf=pass (google.com: domain of linux-kernel+bounces-165642-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-165642-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id b130-20020a633488000000b005f7fcfaf7a7si23103642pga.66.2024.05.01.10.26.36 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 May 2024 10:26:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-165642-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=JyE8xHLG; arc=pass (i=1 spf=pass spfdomain=linux.dev dkim=pass dkdomain=linux.dev dmarc=pass fromdomain=linux.dev); spf=pass (google.com: domain of linux-kernel+bounces-165642-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-165642-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 22DD3282E47 for ; Wed, 1 May 2024 17:26:36 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6BB381B285; Wed, 1 May 2024 17:26:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="JyE8xHLG" Received: from out-180.mta0.migadu.com (out-180.mta0.migadu.com [91.218.175.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2853718C08 for ; Wed, 1 May 2024 17:26:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714584389; cv=none; b=VPHQ3PTaBYHfzf84qQvLExzJFgRWq2UvZ6qc2K56C5hkOLVAhdj0Yeva3W3nqfDl+OFzsbxYjVA6Dt/vwOmDIVYBQT2/aDQWCgSx7CUM6Q9ymGe2gduJJ9IVXXp6iWMyxKF8cTvlU5/kvEz1JSD6v+0QYIPBCXhMIvArAJuz+0s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714584389; c=relaxed/simple; bh=vEf49XmcjqN67G4RpIYKjBMMrAp1+oPBWXfTCquUPVc=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=mSYvGKsYylw36/IRL9a25fPBSL09QMhshSyfOoNKg/wLnQGi2HZSqVha13TQ+G2OtJ2C09hXRM01fmnicjks2eOBWx6IMM7x+fPwY2phuDlsNDnhTSDjOP/7Lu5a0GtM7QbxYg8xEGE+o0ASoX/hqOVHfwx9FZsnwl6lpInagl4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=JyE8xHLG; arc=none smtp.client-ip=91.218.175.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1714584384; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=3H2isfS8T5ps/+wLdohfpyvRT+Uuu4Hht5kCun0wQ34=; b=JyE8xHLGkW5gqwjPybskQtVSStPG8kiLG0DNwI/vpeTbL+/bcRIfHvb+unYcWN9cy1RZcF HIIMi3nj1hZfXdL3ZRvdAMZoYmV1LUuszTRbyYgEpC+wsxP/JOC5O/Kn0yYwaA3mxreoz4 NrXRai342e4YNAp/GUnVgenqHevsAJg= From: Shakeel Butt To: Andrew Morton , Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , Yosry Ahmed , "T . J . Mercier" Cc: kernel-team@meta.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH v4 0/8] memcg: reduce memory consumption by memcg stats Date: Wed, 1 May 2024 10:26:09 -0700 Message-ID: <20240501172617.678560-1-shakeel.butt@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT Most of the memory overhead of a memcg object is due to memcg stats maintained by the kernel. Since stats updates happen in performance critical codepaths, the stats are maintained per-cpu and numa specific stats are maintained per-node * per-cpu. This drastically increase the overhead on large machines i.e. large of CPUs and multiple numa nodes. This patch series tries to reduce the overhead by at least not allocating the memory for stats which are not memcg specific. Changelog since v3: Minor changes related to changing macro names and chaning the if conditions orders. Changelog since v2: Using WARN_ONCE() instead of pr_warn_once() and some changes commit log changes. Also included a patch from Roman. Changelog since v1: The main change from the v1 is the indirection approach used in this patchset instead of rearranging the members of node_stat_item. Roman Gushchin (1): mm: memcg: account memory used for memcg vmstats and lruvec stats Shakeel Butt (7): memcg: reduce memory size of mem_cgroup_events_index memcg: dynamically allocate lruvec_stats memcg: reduce memory for the lruvec and memcg stats memcg: cleanup __mod_memcg_lruvec_state mm: cleanup WORKINGSET_NODES in workingset memcg: warn for unexpected events and stats memcg: use proper type for mod_memcg_state include/linux/memcontrol.h | 75 ++---------- mm/memcontrol.c | 244 +++++++++++++++++++++++++++++++------ mm/workingset.c | 7 +- 3 files changed, 222 insertions(+), 104 deletions(-) -- 2.43.0